From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30EA34B048B; Sun, 16 Aug 2026 01:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786842943; cv=none; b=bOJAH2O0rDdWbWdqrCOxle0WJTPXssP8TmGJeuUJ/oEwWbYHW8t3TTf+04HeMTkV0v/znj08s6FW1LryafK4o8ObedZvvHRKvrtCdt9i4vMiwUcGhL1+QbUpTtiA+W/5SGQSlh0gUp84P8VplRV8CA/SL7mS3NGKFH+B1pQnmjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786842943; c=relaxed/simple; bh=N522CeDOigJDs7cUos5wW7HZ9WGlPSgUYP8lBysoDUk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JNptVZ5eCWwG8OC+1WyUUkXR0P7cCXcY4iQGejajfMvz801lZqkam7jdDWdUCVLRP47RRt+KbNdmjuXUdyDXM8ry49Iip2sH1FBpgIq+g44bWx973zSRz+1gknpQGo3OM9tkGot05mV9+eLUlpIDQwTFg885SGat3rvdC5De63k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ecs2r+s/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ecs2r+s/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EDE21F000E9; Sun, 16 Aug 2026 01:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786842941; bh=JFmGP0VJtabRx/4pFXIvCVtLulMVCbvWMx/1YBF3fdM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=ecs2r+s/2ExFbUc3zmpWPXzsPkwLyD4uyeow+63PNcNBszfM5VPFA6WBJJMlC4rp7 ynZ57pGKuXnY0sVbPgo82340LM0cPyuO1oLQPGJ3OHW0H6LziULspZ/uhVV0WHpy+x HFNrm5WL8u6JjmvgxP0DXX8EQ8I+ndQjUUTdPxugOSbVpa8I3R0NLchb0C5pykI/Ki oBF0THPz5kCD0Fbi0NVyEEcuhKDJQJTIQokottACSGek0sOXhAD/jE7JD6ttakrY+3 FDCygu29E7DLsceRzdZJcB4qEJH86FwUeEahAF2oljbNERglR+Q2wMzl3XorOa34Ge JfaWk5Y2OfXRA== Date: Sun, 16 Aug 2026 02:15:39 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: mdshahid03@gmail.com, Andy Shevchenko , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Message-ID: <20260816021539.5f95f403@jic23-huawei> In-Reply-To: References: <20260806023902.8608-1-mdshahid03@gmail.com> <20260806023902.8608-4-mdshahid03@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 10 Aug 2026 11:32:26 +0300 Andy Shevchenko wrote: > On Thu, Aug 06, 2026 at 08:09:02AM +0530, mdshahid03@gmail.com wrote: > > > Replace open-coded dev_err() followed by return with dev_err_probe() > > for probe failures that immediately return. > > > > Leave error paths that jump to cleanup labels unchanged to reduce code > > churn. These paths will be converted separately together with the > > planned devm-managed cleanup using devm_add_action_or_reset(). > > ... > > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > > "adc-syscon"); > > Size note: the above can be also amended (since you have a 'dev') to > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(dev->of_node, > "adc-syscon"); > > But we can go even further (in a separate patch) and move it to > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(dev_of_node(dev), > "adc-syscon"); > > ... > > > adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); > > - if (IS_ERR(adc_priv->adc_clk)) { > > - dev_err(&pdev->dev, > > - "failed getting clock tsc_clk\n"); > > - ret = PTR_ERR(adc_priv->adc_clk); > > - return ret; > > - } > > + if (IS_ERR(adc_priv->adc_clk)) > > + return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), > > + "failed getting clock tsc_clk\n"); > > > ret = clk_prepare_enable(adc_priv->adc_clk); > > - if (ret) { > > - dev_err(&pdev->dev, > > - "clk_prepare_enable failed %d\n", ret); > > - return ret; > > - } > > + if (ret) > > + return dev_err_probe(dev, ret, "failed to enable clock\n"); > > This will be less churn if the previous (new) patch will convert this to use > devn_clk_get_enabled(). But if Jonathan is okay with this patch as is, you > can take my > Reviewed-by: Andy Shevchenko Too much in my backlog for me to keep track so I'll merge what we have here and a follow up bit of devm_ work can be a separate series (this time - look for similar opportunities if you do similar work in future!) Series applied to the testing branch of iio.git. Jonathan >