From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14172146D5A for ; Sun, 16 Aug 2026 04:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786855527; cv=none; b=rHGgx0/cQYjSRR0EPmStElBPYoZz8Q4+XF7QxCJiKFpz18Ggg1do+e983ZOM6ki0yqhf19jt/grrvk+Z/IeR+7ZhF56/BUZATuIIGKkscF/Lp3CZWqK+MifYgrmuIt9PcgQakeWhuF2ajDPg4IeNdCUbkbk2lRdEiRseJUPXZ6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786855527; c=relaxed/simple; bh=VPZwRSomxevHO7ok/WVEp7eMxLHx3jbGcDllWYjpIk0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r5BV5kIogAmcxTE3Sb21gEztoDNy5KXsSInOUE7B4zV9fC2J6NeZWNjh/SE8OHh2j8yC54zoi49YSvd+9S44dYYVz2MZWKb7VXUYkY090Ey6oG8QEVXhfhOSbYTL4d6KlctPBDFNGaL9iE8EdJm+/5OgbMcHPOH8dLJAXmWiJeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qRSqVadc; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qRSqVadc" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-9061a795d76so23278536d6.3 for ; Sat, 15 Aug 2026 21:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786855525; x=1787460325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aXQqM4Uz+B7ErOlECxSpCZ++Y8mo3D64bY4QdYcgNwo=; b=qRSqVadcpAn7biNDanCxu8O7iykcNgRAO46rIZbwxWbcqrfJi1z8kuY6jf8fVar0Z/ KnIGj4FQ4P7SNjpQyZ0XbVMhhFW0mGzYBxWTeh3fUNjhRulGYflWZZ3Dqm3FkCB7Po8W i27/poacJt16rvPraNr7ytlrZNtJHVilbk88ln1RlWSVJjeqxdAVxaowgmPJDZT9tk8g 6QwdeKcEGTl74Jod0yHiWcHjnfhXfJY1uxxpJKrtrI+sticqhZgGGdpUMmaxVzsSd9Y9 xofZMHB0+NTx/HapRBbOHXQpaaQyG00r7UVLNLKcR5KWqvOL/4RJsJeM7pUbU2Ad6WzZ WUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786855525; x=1787460325; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aXQqM4Uz+B7ErOlECxSpCZ++Y8mo3D64bY4QdYcgNwo=; b=J+I8nPrtsYKKpbQ+9lRt0fYyu6rHaLUHY0LYoiqslUH7z1+q6MJP4UgkCepzn8APTV D9IV/bfV9c+i9f97Bwz6Vj45U4d5zJsaOWclV9vCUhStQMxKN2SC9nOUCf+o/+lR2qDx F1ZqVn2X2vvXR5LQMFk5tloD+dnMVm5LO4035KF4MuTGv3JnNfQ1olHaLu5hqjgqC6yq UC2Yy3jCy8y4X3oFjTrbOyVpkThM5wK6b/5Uhg2wGQ1K+YJXZFyqDKbzopPZF3/gLcjQ bK4P7+MIhD5BpAaFopesgzen/ufZ1yHwCrkiPYcbMR4gvAkvtYel0tuF7eEVLVd11jCS 34Fw== X-Forwarded-Encrypted: i=1; AHgh+RrCvr8ZtBVVMFx9SXUSRac6uYyguBQ+nOYFnjWG8e02XuiVaBu2jiVh4y6uHLlxK5qmsbecBskcU0HkdpI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6UWCRQ8Dxw9JozhlS8EkY+wc79wNtvz3nN89XZjB8W87aEGb+ 372eiN8H3MjFgcNlwtSHM6YydpacFCDgJSsIlk0Om0V1zjhdWo7lgIJ6 X-Gm-Gg: AR+sD1343gUuGRkIgfdDKCfd+mcoUGBojS4xS2JZ8i/iw/uKjNQhZt0ArZ9EuRB/uqA fLSD3cR0/LTExYzEaMAhA1KBSAuenU0PuZcerNS2i7ORNYIzk/78V9F6jL8JXbKEHpFLSCs2bDn 2Cel3rBINncEsd5sRqpLQnZqBQSXLMuvpZKees4LwNvMqKKND5h0QKGLXu9sh2m87pnXnSFplZe ty7G73d48oEHWBRUlJq/TcA6iKNbzerjzPxm7He7YxEzFYXMbJqXvoiCTWAWinsaYedS4Loojwv 06x5IIxedLoMS/wulsC4V+rm/WClZBFhlIbwS5kTWFz0Tc456d1FElFGHKLWU+Y5JG0PeU+MnWO 9uYEwiV5fc8uxnRNvjZoBBjVAE1e0Ogdiho94XbLFGacHnvFrPSxvbrN+mQcITvptoUZO9OStYV 1te+WBUNjKzsdGKmbLPPgu0THx3pUri7kK3pW1f68kMNNtqXdAJ8nyfxLnlMVgDuY+DHcYCqqf0 vkHZrC2XKVKKokeGw== X-Received: by 2002:a05:620a:a293:b0:934:970a:beb2 with SMTP id af79cd13be357-936d22ce4d1mr1589429185a.26.1786855524958; Sat, 15 Aug 2026 21:45:24 -0700 (PDT) Received: from i4-l-hqh5357-03.ad.psu.edu ([130.203.139.71]) by smtp.gmail.com with ESMTPSA id af79cd13be357-936ce1ea6cfsm687105385a.27.2026.08.15.21.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 21:45:24 -0700 (PDT) From: Shuangpeng Bai To: yishaih@nvidia.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shuangpeng Bai Subject: [PATCH] IB/mlx4: Fix use-after-free on pkey sysfs registration failure Date: Sun, 16 Aug 2026 00:45:10 -0400 Message-ID: <20260816044510.3848996-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit register_pkey_tree() ignores errors from register_one_pkey_tree() and continues registering the remaining slaves. The per-slave error path has already released the pkey parent kobjects, but their pointers remain stored in the device. A later device cleanup therefore passes the stale pointers to kobject_put(), causing a use-after-free. Clear the parent pointers after releasing a failed slave tree and skip unregistered trees during device cleanup. This preserves the existing best-effort registration behavior while preventing a second cleanup of the failed tree. Fixes: c1e7e466120b ("IB/mlx4: Add iov directory in sysfs under the ib device") Cc: stable@vger.kernel.org Signed-off-by: Shuangpeng Bai --- drivers/infiniband/hw/mlx4/sysfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/infiniband/hw/mlx4/sysfs.c b/drivers/infiniband/hw/mlx4/sysfs.c index e688ad66a895..5438224bf325 100644 --- a/drivers/infiniband/hw/mlx4/sysfs.c +++ b/drivers/infiniband/hw/mlx4/sysfs.c @@ -751,11 +751,13 @@ static int register_one_pkey_tree(struct mlx4_ib_dev *dev, int slave) kobject_put(p); } kobject_put(dev->dev_ports_parent[slave]); + dev->dev_ports_parent[slave] = NULL; err_ports: kobject_put(dev->pkeys.device_parent[slave]); /* extra put for the device_parent create_and_add */ kobject_put(dev->pkeys.device_parent[slave]); + dev->pkeys.device_parent[slave] = NULL; fail_dev: kobject_put(dev->iov_parent); @@ -785,6 +787,8 @@ static void unregister_pkey_tree(struct mlx4_ib_dev *device) return; for (slave = device->dev->persist->num_vfs; slave >= 0; --slave) { + if (!device->pkeys.device_parent[slave]) + continue; list_for_each_entry_safe(p, t, &device->pkeys.pkey_port_list[slave], entry) { -- 2.43.0