From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0A118BC3B for ; Sun, 16 Aug 2026 05:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786856905; cv=none; b=JWJqEdV2PLjBaXWy+sstF8Drwkn7VI3GuturEiwI6yPwT9RaYC5oJfKEizhtVZaVWlovM3YqVOOYl9Wy7OB3LxasHCJ5R0Ezfnyxp9kgh2QD11ZRS0PYB/a1R0hm6hN4y4GMoD8AgLl5hyGLo5mjAGvDf82YfxchxbOf6sxYGuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786856905; c=relaxed/simple; bh=K1+6ZfM3X7b1ZXo4/aHurUoKhIdCkiaITB6aDZA59gM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:MIME-Version: Content-Type; b=F/jDwAn3XVylWWZbyrR2lxD+3FPR43tKcYctZcwschupvxl8jw8CtVbo83m3AsKHuhujEXf/0os+cLVGFIYv6CLbAFTFFe0F43MR98sHj9RFnxoYxJaicQjRe7KyLhIB2/M4nE8Tn9nmAkfj7QF3wKHcL4jKJRkDWtMeD7DLJIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MwOOpWC0; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MwOOpWC0" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c1712a04ddaso382583466b.2 for ; Sat, 15 Aug 2026 22:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786856902; x=1787461702; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S3EGv/bCwZGVn5e0LnVQX15hxgKZ01RYRO4qrI6Efvk=; b=MwOOpWC0Go75EC4WJgPeqetZgu0/tHAyJuIzkOdMuHbfqsxP994NGYsfPclztgOTZn vvbyOoxudHpsxlVb3KvrFW2EIRp5Mxwop11xz1rkC3gTexh/78UY8k+XDn+z2bMHQIHg pVXGyf9qrgtO4/pQfQmYXzmpnxqPy4N7hVtKWTzksuEz9gKAJWTbYocXK7qTxNfrrSEx IZIlFPLMG9WMDTkrsN4Xqj8YVllJ36/8rZW7Ords0NT7r6VZQ44+gqaZH4cW+KA2J+tB /U60rGFR87Mbs4VeNINetfxHXRPZWnwlu+aXKnUo66cfbs5JYHEHdG1lDeMrZh/VJvA4 ML6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786856902; x=1787461702; h=content-transfer-encoding:content-type:mime-version:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S3EGv/bCwZGVn5e0LnVQX15hxgKZ01RYRO4qrI6Efvk=; b=VPqflTB359yhji/fiSd6qblF24JZF/vkjFOwijEk5cvxLiJrntlwpRYT+ZkFCI3xjn II+qTsPKtavGp+m+r0AM+rUokZtQ7NI3Dq9k+tLHRueBXqcrnYTcjdKvzcj5K0fXdeXY S8dxPWp9qhhdyYj2H+r/sXZgI6Bn3Fxjxrq42k6SFxa1Jk+6Lx1VB8krZNVn/jPEwzSi 0foJHJQ3riR9AzwtNsfNWi84g3sk4X8VjHU5uZdaxtoo1bMAIFPd6iuUbDddIlD/E5Kq uE9Ib+DVwND/e4XcKKbA+ywyGXYmMmzaR/QHU6azDDr5VIRcvl7fxstVu3cSm4JCvVX0 ++xg== X-Forwarded-Encrypted: i=1; AHgh+RoPe1HXKGJ+pz1nhqX8YpeqXN6aZa4xZ7uIf0ZXa9L1u/bxEpeaHqBxGeTpEHKDHSkqsl+tg6sdED/sFY0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0VKilt6SnCbOHzgrTsy/LUUAL68+qB5+/6ll2ZG3wqqHxwJJe i5mS5nSCdf/hM3uVSAYjo8xYYn1WznqPlDuaaa7YOhVdsLK/aLavBnDN X-Gm-Gg: AR+sD10rk008k09ZhyVmI//XhLKgMkhI73yJ+ebVqkwl7+HtGfRQ0bjzbYiQQAtASkG /IirB20RrdNVJ1w7BumB/4uideAvl6hfD9AD6TwEIHTefaeKZCPX5EbLXuvQNHwDEYIq0xrIvT6 +brwwbK9N0z9+i1FyiITbM0AwAdyTINFvl3J6BGqs2ndhk7BS7LHbd51kfkNkXnsc53GrPjcHje IqdqEL6Ms1vVJetpl3rVIC7v0Wm5F8nPe20gBCENsRHkOrYvOVnCvz3mtTfitKxnDCcT+ZB8NfY AQ9q5ayujy03++VQYsSFlQsujdm0+wQtTh7i8ryUpax13dcunOo0wkUQueBDXMyoaND4rKKI/uR 9DghiZnFVkwu9rfVKO/XqVeq+aZ5o8hKPJUrRKOg38myUEpIOPSIFTAraga8E9lODvRcfD2Kjoz 0e/Sh0gBKvIrqg1mtQ7T9nN2VZb5BHJLQlAhw2XU0jh+xKWe3bOUgA/xR0gfozsZMp4Ew= X-Received: by 2002:a17:907:ea93:b0:c20:f871:1018 with SMTP id a640c23a62f3a-c212a127aebmr838653266b.21.1786856901726; Sat, 15 Aug 2026 22:08:21 -0700 (PDT) Received: from foxbook (bfg7.neoplus.adsl.tpnet.pl. [83.28.44.7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c21238700aesm296472666b.63.2026.08.15.22.08.18 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 15 Aug 2026 22:08:20 -0700 (PDT) Date: Sun, 16 Aug 2026 07:10:44 +0200 From: Michal Pecio To: frank.li@nxp.com Cc: corbet@lwn.net, dmaengine@vger.kernel.org, hch@infradead.org, imx@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lizhijian@fujitsu.com, mst@redhat.com, rdunlap@infradead.org Subject: Re: [PATCH v2 1/1] docs: dma: correct dma_set_mask() sample code Message-ID: <20260816071044.331a2c51.michal.pecio@gmail.com> In-Reply-To: <20240401174159.642998-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi, > There are bunch of codes in driver like > > if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) > dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)) > > Actually it is wrong because if dma_set_mask_and_coherent(64) fails, > dma_set_mask_and_coherent(32) will fail for the same reason. I encountered similar driver code and found it similarly suspicious. I arrived here searching for reasons to convince myself (and relevant maintainers) that removing this is indeed the right thing to do. But I have a few remaining questions and remarks. > And dma_set_mask_and_coherent(64) never returns failure. No realistic chance of the dev->dma_mask check (below) giving -EIO? > According to the definition of dma_set_mask(), it indicates the width > of address that device DMA can access. If it can access 64-bit > address, it must access 32-bit address inherently. So only need set > biggest address width. > > See below code fragment: > > dma_set_mask(mask) > { > mask = (dma_addr_t)mask; > > if (!dev->dma_mask || !dma_supported(dev, mask)) > return -EIO; > > arch_dma_set_mask(dev, mask); > *dev->dma_mask = mask; > return 0; > } > > dma_supported() will call dma_direct_supported or iommux's > dma_supported call back function. Aapparently, it may also use some 'dma_map_ops' and there is a bunch of those spread over drivers/ and arch/. But I gather they are expected to behave similarly as the functions named above? > --- a/Documentation/core-api/dma-api-howto.rst > +++ b/Documentation/core-api/dma-api-howto.rst > > +The standard 64-bit addressing device would do something like this:: > + > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)) > + > +dma_set_mask_and_coherent() never return fail when DMA_BIT_MASK(64). Typical > +error code like:: > + > + /* Wrong code */ > + if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)) > + > +dma_set_mask_and_coherent() will never return failure when bigger then 32. > +So typical code like:: > + > + /* Recommended code */ > + if (support_64bit) > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > + else > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); > + This text is unclear. Two sentences begin with "Typical error code", then some code is quoted, and the sentences are cut abruptly without actually making any statement about the code in question. Thanks, Michal