From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FAC513B58C for ; Sun, 16 Aug 2026 09:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786872338; cv=none; b=g9RKEx3A4LrS8AmHbk9ADWoKN9wrcoKd6fW1lLhjRh8v+DPtxgqFhq9QOWZiGq+wBlby+LHOMwL7WHDv6L+BRPSxOBU0Zx7Sf3ABF4rxQ+voJvQQWCANg3uAspPExnU44AhZpLwvaLB1/Aa1TtD9IbjERGD66qgri2k2+IN1sBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786872338; c=relaxed/simple; bh=wcuJdLT3TN8sRwBbWhy6fIjmgZuQ3lzITB5DNalDNYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ShmZtA/0s9t13vtk2IG0U2nb3Rb7I6liMb5vagF2/IAwYTHuui/QuDuqWQjefXRH3sUCIpHOWkZJkNfNVjJgSE7utkOfT5gsWTsdb8+egRgb1NAO1/QtRNKqXojvghm8Z47au/WL9/tUopqyUF9r3jRfAynpfCLViofzJJP2gro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qjjCoAHm; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qjjCoAHm" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954dff6536so18221455e9.0 for ; Sun, 16 Aug 2026 02:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786872335; x=1787477135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/vm/j07+KL21gvKlwAnAdnCIMV+QoeEuexJ+hzKNEg8=; b=qjjCoAHm7zAjIDinTA1xijgiGn0BhkV7LzrhJudLnJVkW0Qmg9o7VihmEGLUb7fCdq 1sLQXjn6HZlwr7WCB75FDtZ3mWKLaYkpkfy3lev1TrKaP0vyf8WCuDnng0KaOS2K3V3T NM0z4tojuYr0pfkeCe5wS66XasAO3wnhuD9Fd8GGugfW5wOZ6CTd4XvwJhQw1tREcM0T KYAxaPPSZecZiEX6e8w/JM7GKqUO+xwIMK3xXMohsS5ZWvpsEqqJnlC/hygkxm95GQ+D wlaN/ePZFZp053PeFcV0+5afB2la0pF1XnZOzhjPXVEGS/pLPbq20stfDZjVdjZk6FIp k6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786872335; x=1787477135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/vm/j07+KL21gvKlwAnAdnCIMV+QoeEuexJ+hzKNEg8=; b=PKSmju5MlLQ6ehO7J8TmCM4PqAco0DYbfJEYkaRZAEsutJ+0bUXUkrAsuNx1lCaS/o vNev1Yl//ku0yd0EL8wNMWGez37JL939YAvogfFIlg0cMImINSMmx2sLca8Htt2N3NaG 6frQRrc66G3mzQWr5HzOrrisvkxzx89ureAvSqFNWvzCC/n5oezRekmOAfB9OGnO1muF Ar5h5NrXo1cMLyFXVZRd/PlXnGuVjkP9c0wMl5Gcy/xv4+wYTMIB6w5rUg3y739Wqaab xwMliVYtFXdOUyatbb0DSurjV5A5lUsM0BFVub4xH70wNzfDzlxSJkAFnvOqdNV9eTsu uQ8g== X-Forwarded-Encrypted: i=1; AHgh+RqHrjztMeNBqAYGgLhbf0QFWffuKvib3koHjBmrDpr94/se+tTgo6oMhbV8DsAtajcizAEnKeWvQnPZDV8=@vger.kernel.org X-Gm-Message-State: AOJu0YwoPo0HeB2KjTDNz+3haELT8Oamcc3XLudviHUJ8SUyCRFc3kOo kUrYYmCkLZ9iGBn8eMrfFORbyuW8zaBIBG0arhizzD5q/1vuhVDpYRk4 X-Gm-Gg: AR+sD10iJzT8SUwgMLJvxO8GEW12PvrcKgKmWrsO9VQM2QwU8lqHpZdMz6+IcgoXQcQ 2VBLD1hqsXJCo1W+wfuXjgT7z3zx+EWpIJvNhvCoL8qwRB8d1vERPezNLNdWqBRFBs5v7fkpyKy dvE2M9I9F5KHLU3+CCxdVeccQL9vAPo/WLH8sA9owvbERJ7FB2+qF5C/rf2hoCMnnKGgPSmm6/8 nLlRG6+tFNNGWo7W9aKUc/OeMJyHGt7gJ7mHwSkd1wjeNpuLVCyfi1beAHddhma4fESEakn82dd JQMldmSNMWL1Tw9opZ4C6AqDQyoS63ek14jMCVuKZilL19BDNkn+ylLvRPocFidgUAb/d1xN8i2 QpiP6jj+X9uSHfnkPyjGZK64siLK0heD5GFpLpl/OJTRMt7bQP8DIX4Wq3Jjra4jx5bL7drU7vL B08FeFrJtFjJWLY310s3PLsibWhVQ/Ib3XUlVypiIRsE+Rt5Y7/w1+tMkx X-Received: by 2002:a05:600c:8714:b0:499:8704:242c with SMTP id 5b1f17b1804b1-499878ca13bmr307331535e9.0.1786872335384; Sun, 16 Aug 2026 02:25:35 -0700 (PDT) Received: from zen ([37.203.152.61]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996176b8asm27309575e9.11.2026.08.16.02.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 02:25:35 -0700 (PDT) From: Kiarash Azarnia To: rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org Cc: graf@amazon.com, kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kho: fix signed shift UB in kho_preserved_memory_reserve() Date: Sun, 16 Aug 2026 12:55:34 +0330 Message-ID: <20260816092534.3333563-1-kiarash.azarnia@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816090038.3117276-1-kiarash.azarnia@gmail.com> References: <20260816090038.3117276-1-kiarash.azarnia@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Here is how I reproduced this, in case it is useful for review. Minimal reproducer (prints what the function computes, both ways): #include #define PAGE_SHIFT 12 int main(void) { int order; for (order = 18; order <= 20; order++) { unsigned long long before = 1 << (order + PAGE_SHIFT); unsigned long long after = (unsigned long long)1 << (order + PAGE_SHIFT); printf("order=%2d before=0x%llx after=0x%llx\n", order, before, after); } return 0; } prints: order=18 before=0x40000000 after=0x40000000 order=19 before=0xffffffff80000000 after=0x80000000 order=20 before=0x1 after=0x100000000 Order 19 is a 2 GiB region, reachable from a reserve_mem=2G boot. It also shows on a real boot: with CONFIG_KEXEC_HANDOVER=y, CONFIG_LIVEUPDATE=y, CONFIG_UBSAN unset, and reserve_mem=2G:2G:khotest kho_scratch=128M,128M,128M kho=on liveupdate=on kexec -l -s --reuse-cmdline --append=" luo_stage=2" stage 2 warned in memblock_add_range and lost ~820 MB (MemTotal 5181908 kB vs 6004928 kB in stage 1); after the fix, no WARN, MemTotal 6004884 kB.