From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F175C12D1F1 for ; Sun, 16 Aug 2026 16:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786899547; cv=none; b=G1VesGJ46tqhW+L/fkicCVb6XSN5CeTjngSV3LQnm0lbUu0Z51mVplA6T8n1MneWDJ1nPCzUnKbYWExt3MkofCOXjAF7ydLxaOjKQ9Ha3hfHl6YZpKqEJsWkCxlhy2tJMzzZovlPd1kLSJpaeOMX0IMVpmSdUiigPi4l5lMGnLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786899547; c=relaxed/simple; bh=0H+AWAKxMGWPUgIiM9TkoAqiS8Mj5ime8Yc+DKyvY/o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VClmRdJ//Y0Tg+gjf33g0U7qsblfpK1TdFV+Vvcbpcck2ZY8I7iKDffKf2xBGYenfj/A9LmhgXwj2hHXnoaeUGHJP4fnUsgPzwCFQOs33uB8I6yjcmI1HITmTjE6nl20+2/Kn8JwMQzM/uJjW74js7SWBaNutzSaWDnuixPujJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hcVWXzsU; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hcVWXzsU" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ce98cb8165so23688275ad.1 for ; Sun, 16 Aug 2026 09:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786899545; x=1787504345; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=W/bWkRDD/8tCi2rYvKnRL86bl2Ul1nCW6kBe/h7DI90=; b=hcVWXzsUc7KrEz8tQpAilhI2OgVTtjBUWBYmuDaT6+hvyZ2AeRAlXAqt1y1puhjWTF MPJYNcpxdqkXQ94kIYLjrTUQEjGP2IG+ezHtesoTgHY8Ui6X3rTmTJ/OjY3b/NjlPI/I IkcrUfPnOldiPKjtvIKDB3B4/Vd8FMFbzrrEOUTHDK0+so5fnD+uUMwPdneqx6DNhxcl xM9eIyvZeszhLN0keAqlWjizJ0e258Wyq43lIphVA4c6//AipAkjSAC0rs+/KK9GrnxU n8n2F18V8piX6LWrOy/J7IZZAZJ2MlrbSzp+Y+slJVSmLZQ2BtdcOR1rnyvKWVrdBZS7 cp8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786899545; x=1787504345; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W/bWkRDD/8tCi2rYvKnRL86bl2Ul1nCW6kBe/h7DI90=; b=f9cBgYtB2NFEfdAW3Dq4W69iFZkTqO96XmztotnXVfbb9CZj7IAeplI8ivyo1M7hdK xj2SogSr4tPwMF8DLH0WOHZyXRCg9MAc5iIMhRHxFO1dKQ72H3n9Ix+byCQLAOVJaDgI vS79X351sLTiQfU0jXCdXe7bTfVjeE835PM6s/JjyBD9us7XZ0cl10eDSljlvyp8tE19 aZ7ouvZtyJThhi+QAYiVkWKlRgdbG8LXVsSAkmqSJrsZzD9Ncox5km2ro5d8sxbykcoI +cuvNIW+4bA5Frm8qI3ZIFpbr9oglRSdyUa2EAyy3L/VSaJllnzOysSVxFStkV5HFz2t pX4g== X-Forwarded-Encrypted: i=1; AHgh+Rq8FEiuqFb3wYhi70MY6hyKR5PVMyaM0SsHj1Gywetc7sKCshPfmdK0K60f7P76VQ+ZuTts6PuhdEeEOJg=@vger.kernel.org X-Gm-Message-State: AOJu0YwsIqQQPk+YiUf3ZTBLlSqOxZ0m8GYNadtF5tDDkwxM/9uleCch fYZUDCNOgKtchrqru0HgHDAuZsGyTJ+bNReEB5Qs2gqklbplHvouaXs= X-Gm-Gg: AR+sD10r5oKMwp/2Udr/VtFpuC4hPS2nNjgWdVNpq8lz17CmkyPKAtgPOHlLiww3T9E nxwOM+U9v/gcvaU1m2TsUj3XdCpsuzgHQsXJOiCbzk5nd66LylljmOlEZo8pX6zs3o6yyehBmLf DE0/9PJLxeV3zY45ypkEYXd22ln4JZGWVh2w+jK9mZM5BcwBWf9AMM7aPtjKRK42ovZbjOq+afD vYX7kAFxIwboj84XBfwrNTV6AUnE+RrMZDABOfya/avExvEbOUVihpaxLtHIstqdEyR9h2BxjSC bNnLbG5urwvbdps7bq9z7bDzaOntZJRI6wRGrNXeqk3uwZRTKRdtt36Hs5zDtCBnTpwdKOPHlrq qA8KtOK763W7k3F9ELFVC+Po1aD6n/MjzB1L3RS9++Bh2k757dbkfopbxsz445iFDN4KA2AeGkE ohXLcr7/KzxYGu9W6m5G6/UjRZ5MRCzqKna68IvIq0fuhKY+Ar6MkR4EPHEAFAKx9BAxMolD4tA r7z7/hx0Tf/8jDI/WIMx9AeOf6bPaX47SGyw8FysfUecM2vHVOEwQ== X-Received: by 2002:a17:902:db03:b0:2d3:c3b:c7cc with SMTP id d9443c01a7336-2d37f5d0f8fmr268465995ad.3.1786899545109; Sun, 16 Aug 2026 09:59:05 -0700 (PDT) Received: from codespaces-a1fa80.m2fxbej512jepnsor2itp05j3d.ix.internal.cloudapp.net ([23.97.62.128]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ea2fe8f1sm28362823eec.23.2026.08.16.09.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 09:59:04 -0700 (PDT) From: Triet Hoang To: maarten.lankhorst@linux.intel.com Cc: mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH] drm/gem: Handle shadow plane state allocation failure Date: Sun, 16 Aug 2026 16:58:52 +0000 Message-ID: <20260816165852.44558-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allocate the new shadow plane state before destroying the existing state, so that an allocation failure leaves the current state intact. Signed-off-by: Triet Hoang --- drivers/gpu/drm/drm_gem_atomic_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/drivers/gpu/drm/drm_gem_atomic_helper.c index abef865c5..24a0b9398 100644 --- a/drivers/gpu/drm/drm_gem_atomic_helper.c +++ b/drivers/gpu/drm/drm_gem_atomic_helper.c @@ -308,14 +308,16 @@ EXPORT_SYMBOL(__drm_gem_reset_shadow_plane); */ void drm_gem_reset_shadow_plane(struct drm_plane *plane) { - struct drm_shadow_plane_state *shadow_plane_state; + struct drm_shadow_plane_state *shadow_plane_state = kzalloc_obj(*shadow_plane_state); + + if (!shadow_plane_state) + return; if (plane->state) { drm_gem_destroy_shadow_plane_state(plane, plane->state); plane->state = NULL; /* must be set to NULL here */ } - shadow_plane_state = kzalloc_obj(*shadow_plane_state); __drm_gem_reset_shadow_plane(plane, shadow_plane_state); } EXPORT_SYMBOL(drm_gem_reset_shadow_plane); -- 2.53.0