From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C1524E4A1 for ; Sun, 16 Aug 2026 21:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786916305; cv=none; b=ePpITp/TwPiO8SJkkUglCQ0tP7xk2pCPYRY548GRMyit/ozYcLdz1sDvyI7DVFJiVxAHHDsKadwCX2S6airO/VwdIjqbL5jBQFkAM4XlgbZA08yF0/D+SYobi8GQbQIXMSTS8gnuU7XTxRA8DtUkEyt6DNRgJ4JaQviK0s/VHVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786916305; c=relaxed/simple; bh=+edz4roaeFYDUhu/iJloVGgjpqHGvC7c3P2vbLyN+/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TLsQRmxwKtFlAlL/+kK/jMdiaU32U1bnOC3Tf94RBvSuXIuQwfOPmuezGExRK8WmjrN2fv/bFnr8rcipK60ehCnpypWlhKVV/3XUdeVzDr4X/4eeST1KQcPz0sR/Rq0BFEpK2YBQrY19574i5WjmuFb5KfJjEW5BEmcD5jhulj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IVKh1wzQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k+QmKZLK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IVKh1wzQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k+QmKZLK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786916302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=deEjGWQhm2dA68+gnhA68cTQSmkVCK/4uu8LxzANGWM=; b=IVKh1wzQrhx4783zfiojB7HJZQcz7jMTykpx9iBFC3j5kC/hnZ6pYTzzsZQrBewQRs3Na4 eA5/UEUywxrZHX50IYjXNe6CUlO+XidIxXILjg0lF+xdO5FcJG5TfQBKtTKamwbBJ+n5PL fBu8jDkCHTBlsRNPltVg9ir8AShqMiM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-RYhZid0fNj2Ku50ZfSYGlA-1; Sun, 16 Aug 2026 17:38:20 -0400 X-MC-Unique: RYhZid0fNj2Ku50ZfSYGlA-1 X-Mimecast-MFC-AGG-ID: RYhZid0fNj2Ku50ZfSYGlA_1786916300 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49554715277so23619145e9.1 for ; Sun, 16 Aug 2026 14:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786916299; x=1787521099; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=deEjGWQhm2dA68+gnhA68cTQSmkVCK/4uu8LxzANGWM=; b=k+QmKZLKcxWLL28AzMqxmXI3ZmodYFNRLe75++F9QWHkH3crOyG8s19wHKJ9FcJGAW 5WT2h2FgMlqvl2pLsJV06ACOLHof7s/rWPCJXqDwjJLqf4N6zHQBbgSYGwlfk6xHN1LP uhl4qj3ZuAy5YwLSKWi8wFLMuLIjvHp1K8eAKSQO2wjAmA5kFcTBLMHHeiAgBq39/vgB y2OZJTaecJZQ3Fj++c4jg5i1bcQi/DHxHeyuun2/IcWs4r7mBdbI2Gb/hksgcuxVrScT /J7MJD3pjFOvc1jYLqntkRZ/szopX3g6gFXOGkFgR2jBe7fHwPxrTJh2pZ9WHge8XcZP Oa9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786916299; x=1787521099; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=deEjGWQhm2dA68+gnhA68cTQSmkVCK/4uu8LxzANGWM=; b=sJWRwtEuutAIkJWZCY3Zrnu9QoOzRdStXOLQE4RFJx/Kb5oF+c4pI8aZ3fmJEZJYiO ckwwYv1izLvPbvmJk48gcJAM8YTfjTzcP5D4MenJzkaVioT9PJd5ZfXvjIkj9UdVphi4 sbSvrk+rZ8c13uO+1ccKLUjdvklWNq3UplDMz6r493wOy9hRV3GoDW4dSK2xBz8crswc dABwGjRgd1fhY4yF97PiMDBnuHVFe9UVZpXgKS8+Qh+rR7KBmI9s/oFYriqauCzGLOsI DV3zNGz+QkFCrSOiMZ4L1cfG6mTg3QFP1LNzQBXVmyamWAx+vjCw8jK7uExxOUFWyn1l qSfw== X-Forwarded-Encrypted: i=1; AHgh+Ro+scPbHZ1XNhwV6A/bxYIzoBZ09u7/TU9NjM1kCOygDN6neT+1qpncAXuxxTcZ4dn6oc4f/OCz7T+FNts=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf4gPOpOeAjVJDZRrGPYYEQOv3iaE1EBJocBcNGe1r264w/9OC Onwrg7qy5J8YU6DzZT9DkPeRfg8hJphJ8yDzyDWmUMqSHujTLBcMCiykaUXKB6yqa47tmQk3+kD Xt9yJAP9WFMc+yQMXAj2kH9ZWSFG0uYtndXWY+L4yOBpVANiEPp42WvpsX7zjqDNJiQ== X-Gm-Gg: AR+sD10C/6vWNPt4185r1IZWghdC6eZsBD9O1kvVTYmagG7nYLbx2/CTTJvmW0GOmng RHGBpMCsBa8oaUbjWeGZJWiUplR2At/LCj7b4opsU75Eey4ckiv01Wd68c1s0d8J6VJWQU5TgpA aOLbCLlxDPFvH39IGAUvYxa0YahQn6NX+R4j/2bthJ+TrDxFhuHK1HdceXxOukNFsFJ7QomKrRA KiSTzJv5tuwQdZNWbImNe/4uTPeo0eJ5D6Cf3L6rful5928s4zZfinR0UaFLAyxgc3Fc8ZWrbvO ITDeiHSXDep6Fh22kb8z1FLMXCnNai0mEaUUkUwW3Fm3pqszFmI8hU9UF1dAnFHV1ymg4hzLjPJ p9DboT6N+ge9dsIWSaUz/wC4w X-Received: by 2002:a05:600c:5754:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-49987951a06mr194801745e9.7.1786916299427; Sun, 16 Aug 2026 14:38:19 -0700 (PDT) X-Received: by 2002:a05:600c:5754:b0:493:f140:c3fb with SMTP id 5b1f17b1804b1-49987951a06mr194801575e9.7.1786916299031; Sun, 16 Aug 2026 14:38:19 -0700 (PDT) Received: from redhat.com (IGLD-80-230-47-107.inter.net.il. [80.230.47.107]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49987b36370sm188653365e9.4.2026.08.16.14.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 14:38:18 -0700 (PDT) Date: Sun, 16 Aug 2026 17:38:15 -0400 From: "Michael S. Tsirkin" To: Mirza Ishan Beg Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= Subject: Re: [PATCH] virtio_pci_modern: replace msleep(1) with usleep_range(1000, 2000) Message-ID: <20260816173806-mutt-send-email-mst@kernel.org> References: <20260816094318.8083-2-seedandsyntax@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260816094318.8083-2-seedandsyntax@gmail.com> On Sun, Aug 16, 2026 at 03:13:19PM +0530, Mirza Ishan Beg wrote: > Replace msleep(1) with usleep_range(1000, 2000) in the queue reset > loops. > msleep(1) relies on jiffies and can sleep up to 4-10 ms depending on HZ, > whereas usleep_range provides predictable microsecond-level delay. > > Signed-off-by: Mirza Ishan Beg why do we care? > --- > drivers/virtio/virtio_pci_modern_dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c > index 413a8c353463..8e74a813ca97 100644 > --- a/drivers/virtio/virtio_pci_modern_dev.c > +++ b/drivers/virtio/virtio_pci_modern_dev.c > @@ -535,10 +535,10 @@ void vp_modern_set_queue_reset(struct virtio_pci_modern_device *mdev, u16 index) > vp_iowrite16(1, &cfg->queue_reset); > > while (vp_ioread16(&cfg->queue_reset)) > - msleep(1); > + usleep_range(1000, 2000); > > while (vp_ioread16(&cfg->cfg.queue_enable)) > - msleep(1); > + usleep_range(1000, 2000); > } > EXPORT_SYMBOL_GPL(vp_modern_set_queue_reset); > > -- > 2.47.3