From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77563CC303 for ; Sun, 16 Aug 2026 19:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909401; cv=none; b=A7H87fS27N929LDD1WjLOm+FIZ16wgNuONkNDOfi7fVq+NVhNuO2PQHN/ZJmdwkQ8WVEda6KbyeyCJZ5Wi9Mi8UhIj7AITKcAN2st/HeCf+AJMMaNFVc5OLvFnDL/qYqSyhVJphQ2ois955zm4Y1r1OBFQx5YShdSNZUiGdR1TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786909401; c=relaxed/simple; bh=V6Vta2LVRAm12vCpi7RtdujFKx7yC7EukxxOPcdPjLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OIwQJ649g4r7TN8LBy9RWeUd7QF3WKx/xeAgEto0AyYO6w55A/D1hxsR4zMSdmZFyxxBT7bG0edjzbmHzooZXJzr2FGjbCqnCR3YoPOp7DAZY1kNTx4MV3BAXBghAMO4fziI9frEXtLcigsheiVQXdr3z6bcD5qMG3PPrsiFagw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xl+NYBMj; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xl+NYBMj" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38ec1402b05so1980734a91.2 for ; Sun, 16 Aug 2026 12:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786909399; x=1787514199; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vQV907MxENOHehwyCp9rz0FCgUqiCVS0Fmif7CccKAA=; b=Xl+NYBMj5u02XK9MQ9LLXEUtAW/YzI6EhTUcTAr6eU9MdIYDQFmOKCjNXy4C/jb904 D74lSsCcfx9+yaLHYvp0fZzii4DW495D2cx674KuYQza5HAUn8ZvWxxPEDjTj1IomA6z XVxtjNLsPy9zDmqUqyguMVnrJl7kpP5x4bFwgjIB+eXDJXU6AC0QVmn15mNJIamJFpO1 L9/DACvSPoi9lgVRftHkM9c/crhwBfN0QyTDixJ7Nabr5EEvvFIe9j/8RAXjWKwnByTt htEFZ/LGe11PYF6LIRfAKDGTd16YyfSqo4reR1eN9tGV2Op9OotcLIidLvl8IrvPeyAv Z1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786909399; x=1787514199; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vQV907MxENOHehwyCp9rz0FCgUqiCVS0Fmif7CccKAA=; b=juJP62cqcEBzHYhWHIuolofvP3/3rXTBraUkIaLoK1OR8tiUD1OfGGE+0U1dE2pe8U 4haMw/Zs4ugfe1vJl0ZUVkeLoosZpg53DORsXnSS0tJbtV+SmlpfWuB3lAGWhrJPqF+l dsYWLBceN4ptrtPs2C506VWl5+XFCYuNYpMs9ofkbH408TnKtPQt6Jrw/OxF+1/vsElI A0rJjR43/lb9ZZfeGS+z0ThSHJQFLHfQWNac7kN99Dxhorod4dHwSCXz/ZcLZd87k5wR hy3fQrMHVruNAYDhOUwae2U8Llbr4xrwUGS2z0H47KV/T+Fz8y6QQdFhudzSegyHHLbj Omag== X-Forwarded-Encrypted: i=1; AHgh+RqW6ScPzazY/nSb7/Rq2oWny26PTcKlsl5Ys3imEUg9xwiV/F6gk7Cza5NqeszVwh2npfgwRAek5JLC9DU=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ6mG+1gWHAl0FgiIBYoM4IDOsvHuHCBbDk9FZ5J2LxNQ39xAf O+MPXob3mpwkgmIMNhsX+2pXAPJ/NgVGONwQhYKt06zrDHBg+y5ycXdP X-Gm-Gg: AR+sD11j64axcZbzCjpB+L+ht1CIM+/289l0CRuOsIfISVTjl7n2msAwkEwn7p4u6/H XnSz4rSeVodwNkpRhzB9tug26Ky98ATvgK7E4B/0DXbX1luC1FEdzcaUHIG4a3lVJ2qidl4KnuE xW6snlwnUo+5yJTXXMz8St46LrxIxQxyTWe1IT3hfOZr4mK289TrHikNElxLaBXHwx0wRu0rvYZ VvAikhEglMM4peyqUrJW8rT2HwY+QVjUL0v7un/kUd1ssbaqrTymiZ0yWQ6LWm6l/8aKhGmBOan jRu03gy07/6BVKYxLTo0bsN2Rjwl/j8LCYld6/6kO6UAdk+DC0ofBpGJqca+5GgJ3B4oiX8WqJZ xaX3reJhVbRS1LhQGPBHFpNpKBAzgXG5NwEbMNa7CKIypmYhxMhH1PMX/TU04T5RxbATneYwMmL EONizgSUPaO9FWApLu9bzey5oWkTcg4UQmDH4/E62JLOhtErELlopyBA== X-Received: by 2002:a17:90b:5606:b0:381:25ce:bcc2 with SMTP id 98e67ed59e1d1-3933b78b698mr21706032a91.6.1786909398914; Sun, 16 Aug 2026 12:43:18 -0700 (PDT) Received: from [127.0.1.1] ([1.243.227.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395320229f4sm2141310a91.15.2026.08.16.12.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 12:43:18 -0700 (PDT) From: Gyeyoung Baek Date: Mon, 17 Aug 2026 04:42:08 +0900 Subject: [PATCH 1/4] drm/imagination: Fix the vm_bo split mappings are linked to Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260817-pvr-vm-bind-v1-1-0a0f21be7d38@gmail.com> References: <20260817-pvr-vm-bind-v1-0-0a0f21be7d38@gmail.com> In-Reply-To: <20260817-pvr-vm-bind-v1-0-0a0f21be7d38@gmail.com> To: Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matt Coster , Donald Robson , Sarah Walker , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= Cc: imagination@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Gyeyoung Baek X-Mailer: b4 0.15.1 A remap does not map anything new. It splits an existing mapping and re-creates the parts the request did not cover, and that mapping is handed to the callback in op->remap.unmap->va, carrying the &drm_gpuvm_bo those parts belong to. However, pvr_vm_gpuva_remap() linked the parts to pvr_vm_bind_op::gpuvm_bo, which belongs to the object the request maps rather than the object the parts came from. Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code") Signed-off-by: Gyeyoung Baek --- drivers/gpu/drm/imagination/pvr_vm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c index 396d349fb6c..608e8c0467d 100644 --- a/drivers/gpu/drm/imagination/pvr_vm.c +++ b/drivers/gpu/drm/imagination/pvr_vm.c @@ -418,6 +418,8 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void *op_ctx) static int pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void *op_ctx) { + struct drm_gpuva *unmap_va = op->remap.unmap->va; + struct drm_gpuvm_bo *vm_bo = unmap_va->vm_bo; struct pvr_vm_bind_op *ctx = op_ctx; u64 va_start = 0, va_range = 0; int err; @@ -434,18 +436,18 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void *op_ctx) if (op->remap.prev) { pvr_gem_object_get(gem_to_pvr_gem(ctx->prev_va->base.gem.obj)); - drm_gpuva_link(&ctx->prev_va->base, ctx->gpuvm_bo); + drm_gpuva_link(&ctx->prev_va->base, vm_bo); ctx->prev_va = NULL; } if (op->remap.next) { pvr_gem_object_get(gem_to_pvr_gem(ctx->next_va->base.gem.obj)); - drm_gpuva_link(&ctx->next_va->base, ctx->gpuvm_bo); + drm_gpuva_link(&ctx->next_va->base, vm_bo); ctx->next_va = NULL; } - drm_gpuva_unlink(op->remap.unmap->va); - kfree(to_pvr_vm_gpuva(op->remap.unmap->va)); + drm_gpuva_unlink(unmap_va); + kfree(to_pvr_vm_gpuva(unmap_va)); return 0; } -- 2.43.0