From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH] usb: typec: mux: gpio-sbu-mux: fix SBU path not enabled on orientation change
Date: Mon, 17 Aug 2026 10:11:07 +0800 [thread overview]
Message-ID: <20260817-typec-mux-v1-1-5e53c16744b3@nxp.com> (raw)
From: Peng Fan <peng.fan@nxp.com>
The swapped state is updated, but the mux is never enabled when
orientation is set to TYPEC_ORIENTATION_NORMAL or
TYPEC_ORIENTATION_REVERSE, which means the SBU mux enable GPIO would
never be asserted when a cable is plugged in with a known orientation,
leaving the SBU lines disconnected.
Fix by setting enabled=true in both NORMAL and REVERSE orientation
cases, mirroring the disable in TYPEC_ORIENTATION_NONE.
Fixes: 065ded319d39 ("usb: typec: mux: Introduce GPIO-based SBU mux")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/usb/typec/mux/gpio-sbu-mux.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
index 1834f1a2dd9d..4de7456794ad 100644
--- a/drivers/usb/typec/mux/gpio-sbu-mux.c
+++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
@@ -40,9 +40,11 @@ static int gpio_sbu_switch_set(struct typec_switch_dev *sw,
enabled = false;
break;
case TYPEC_ORIENTATION_NORMAL:
+ enabled = true;
swapped = false;
break;
case TYPEC_ORIENTATION_REVERSE:
+ enabled = true;
swapped = true;
break;
}
---
base-commit: 4477a78374a57c3809b172ad30cceabda48c47c6
change-id: 20260817-typec-mux-d0e148129c08
Best regards,
--
Peng Fan <peng.fan@nxp.com>
next reply other threads:[~2026-08-17 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 2:11 Peng Fan (OSS) [this message]
2026-08-17 4:32 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817-typec-mux-v1-1-5e53c16744b3@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=andersson@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®