mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: lorenzo@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2 0/5] iio: humidity: hts221: update probe and logging implementations
Date: Mon, 17 Aug 2026 01:49:58 +0100	[thread overview]
Message-ID: <20260817014958.4ac98155@jic23-huawei> (raw)
In-Reply-To: <20260813153129.12423-1-adinata.softwareengineer@gmail.com>

On Thu, 13 Aug 2026 23:31:24 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:

> HTS221 is an older driver. This series groups a few small modernizations
> based on current development practices.
> 
> - Report available values via read_avail()
> - Add a blank line after variable declarations (style)
> - Allow unknown whoami for DT fallback instead of erroring out
> - Use dev_err_probe() in probe paths
> - Reject calibration data that would cause division by zero
> 
> No HTS221 hardware was available. Verified with checkpatch --strict and
> builds of hts221, hts221_i2c and hts221_spi. Probe and calibration
> error paths were exercised against i2c-stub with register contents
> pre-loaded via i2cset.
> 
> ---
> Changes in v2:
> - Use a local 'dev' pointer instead of hw->dev in error logging helpers
> - Fix punctuation in the commit message of patch 2/5
> - Adjust commit message for patch 1/5 to include fixes due to ABI change 
> of in_humidityrelative_oversampling_ratio_available
> 
Looks like you've fixed up the stuff Andy pointed out in v1 and all looked
reasonable to me, so applied to the testing branch of iio.git.

Note that branch will be rebased on 7.3-rc1 once available and only
then pushed out for linux-next to pick up.

Thanks,

Jonathan

> v1: https://lore.kernel.org/all/20260808090026.34187-1-adinata.softwareengineer@gmail.com/
> 
> Thanks to the reviewers for all the time you spent going through the
> code and the comments.
> 
> Adi Nata (5):
>   iio: humidity: hts221: report available values via read_avail()
>   iio: humidity: hts221: Add a blank line after variable declarations
>   iio: humidity: hts221: Allow unknown whoami for DT fallback
>   iio: humidity: hts221: use dev_err_probe() in probe paths
>   iio: humidity: hts221: fix division by zero in calibration parsing
> 
>  drivers/iio/humidity/hts221_buffer.c |   1 +
>  drivers/iio/humidity/hts221_core.c   | 168 ++++++++++++---------------
>  drivers/iio/humidity/hts221_i2c.c    |  11 +-
>  drivers/iio/humidity/hts221_spi.c    |  11 +-
>  4 files changed, 84 insertions(+), 107 deletions(-)
> 


  parent reply	other threads:[~2026-08-17  0:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 15:31 Adi Nata
2026-08-13 15:31 ` [PATCH v2 1/5] iio: humidity: hts221: report available values via read_avail() Adi Nata
2026-08-13 15:31 ` [PATCH v2 2/5] iio: humidity: hts221: Add a blank line after variable declarations Adi Nata
2026-08-13 15:31 ` [PATCH v2 3/5] iio: humidity: hts221: Allow unknown whoami for DT fallback Adi Nata
2026-08-13 15:31 ` [PATCH v2 4/5] iio: humidity: hts221: use dev_err_probe() in probe paths Adi Nata
2026-08-13 15:31 ` [PATCH v2 5/5] iio: humidity: hts221: fix division by zero in calibration parsing Adi Nata
2026-08-17  0:49 ` Jonathan Cameron [this message]
2026-08-17  7:23 ` [PATCH v2 0/5] iio: humidity: hts221: update probe and logging implementations Andy Shevchenko
2026-08-17 14:55   ` Adi
2026-08-22  1:55     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817014958.4ac98155@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=adinata.softwareengineer@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®