From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D1934B04AB for ; Mon, 17 Aug 2026 01:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786931950; cv=none; b=b/7jncGO4tgcrKo9xOoobhWt8eMwGylNN2qSJwTgvw/+0ctNMgBp5iHd0ivhVIQA2jRmnYFjmhurjXjy84d9T9OXauqoKclAHQKSYtg4SlQVIy64bg0d8AVk9MFG5I4V1lPeU6Nb/XZDzPR0A1quPiNQHqSDjo7QweUWaS+Zfww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786931950; c=relaxed/simple; bh=RuCLVPGwAemRLNx9SaxW8N85ZjHV5LY8CLq/tkx1/wI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UFEMyaAosEIBzWJ1IYQBynU5LL3nj1V0UmN97QZ1bLps1Eokhn+FbddfudZgweOkQPrdki4bpCICDEh9QiFNtOoAeaCV3N5PzSuFWwhPKDomuX1UZAgN+ota8IHQ3ftQsy7F8+u5iglib4WKRDFkGaNj8Fq0Ds+qukJw4xpyKq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BVFugLLO; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BVFugLLO" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso1724060a12.2 for ; Sun, 16 Aug 2026 18:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786931948; x=1787536748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=J6jChmtmBb8/IkJl2ssoRJSpFg7t2hMDp94b3eWR+RM=; b=BVFugLLOXw/XCPCw1INAZZ0QlCXkYL/GQdlgGSJH4Ee5yM8L1OsLM/JNRJ+kL+2iEF GBETLMyNBgGbBpSEdu/QVQ9fZNX6eKPPpc6vT/AdSrN3fNBndDyykhe0AHatw8RN+faW PNTHIImMkwFTx7zF5R3OYLKf3KsAo1BcEsQniNBycmckGW5D03oqJ5hl5VglE0kLSUtf CAZGcFy3WEFMpez+M3Q2dDTKomV6mSrMFp8qPzbZXLni5UloN2gjFxf+sk9YNuuOtZZ/ xTKTgPMU02wudMA2NCMSk7R08RQDzrHdfHkNZ/EQSmownVv4jFPpOISpfn37Ubcc2/F8 BJGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786931948; x=1787536748; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J6jChmtmBb8/IkJl2ssoRJSpFg7t2hMDp94b3eWR+RM=; b=oc0kf0mUonXxp7pnRW9xYjfBciNXGMW5uTlQsPk9qeSWjLmgmYGi38Gk2N6VCPeoTG p741HZrlBmoFuMYEg4nJRZsWEFhnL/wODitnXIw+nhHh7NDjzi7FBV9dMA35Lmlby+9B dTDV1avfzwXOzzlKgqhnwD1p0UKO9DGA7vn7ZJ0M9d3xlV267rb4zGxxcwY/YjxMs8H+ 5scFjaGYSVq+lfPTW2FdsE0bHKQkCnUWG+MJAskDWHt6COPZWHTew7YjxWhpoSG8ulMQ ly2a3MLt9i+BzDN4gkIFHz7n75ieYJekMZPqxuPexricnBjcfCAjrASeF2gT5lY3q6Y3 WCjg== X-Forwarded-Encrypted: i=1; AHgh+RpMnzL+6WFE0h+tVCJZeyLsOVtvqgQIZrr+4u4YooJFAMLHyqw7QcnNwtQvoPb7lyfG2xMRZCy+6coW8Ng=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/HOWwTFTNmepkoqx6mSr6gaWI/PPCXcJumyb3RVC0Ut/5BHDD nshKEkag3SuCMxN8hsMabjHiovALYIAogG7+fRXodgEuUuBTbNk1HWf8 X-Gm-Gg: AR+sD128Tupbp+P/at3VuhMjZQnmb0t/WabUyVIimgt8bKruyXFR5qbeUgFxcqwDf5C yvw7W4WtKKKD73YzykawNfn1M2XIF9zghiS+ICgit9d7Aheka5aD/60z3nsU4nsFzkrBDelhzMj M16pg2KzqEpY1eRh98qkyKKfXLG0bgAIUo4blfDqf6ZFRMBfnYZbzktAOh+syG+eTJCz0ulQBd3 Ai5OISIvIv7mPywcPPY0PjT4+nUF0uosjUKVM+guyCyIsNfDG2HJ4/+25JJO+DdHeMGvwISA4HA uSfFmNHgJKPpmF4+DdDEq8+buewmteKb1XitBg1yy522nDzp6VUzjWIDWJeVM/dG9NA4aR3QT1y W7ueI5r/bFTA0vzoHuBsp9iu6lRFSLOO/V2oQgpwychQZpYP9PA0IhsAEY6RykXGU/fDO3zgH7Y KQYRLyh68SStgPrOfkTE2V4Xyu/Mo+AlNMj66ZsJQ3aPTEnmwD2zL4TNhfjAnCBFT7ysBKoL3IU HlPaXvbvBXw2bL0Hc4LYJ3ebNp9eAOcJDO8Ce5j/LrvaIwIbHb1u3z2TzTW1fXLy/PZH8GgHDDl ++LH6ykQJefYne2tt8baBn0gUAtk1nl65OKiQum9ulpo8fGi X-Received: by 2002:a05:6a00:2e96:b0:847:8e98:9a4b with SMTP id d2e1a72fcca58-84fde7a73e4mr21312157b3a.34.1786931948190; Sun, 16 Aug 2026 18:59:08 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8517cfeb3d9sm2104113b3a.11.2026.08.16.18.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 18:59:06 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] dmaengine: bestcomm: gen_bd: split struct bcom_psc_params from array definition Date: Sun, 16 Aug 2026 18:59:03 -0700 Message-ID: <20260817015903.137062-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The combined struct-definition-with-initializer pattern confuses the kernel-doc parser. Split into separate struct definition and array declaration. Also now that it's fixed, it warns on missing members. Add those as well. Since this is just a lookup table and not modified, make it const so that it can be moved to read only memory. Assisted-by: Opencode:Big-pickle Signed-off-by: Rosen Penev --- drivers/dma/bestcomm/gen_bd.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/dma/bestcomm/gen_bd.c b/drivers/dma/bestcomm/gen_bd.c index 75d1a6f543df..00dfdc4b8eba 100644 --- a/drivers/dma/bestcomm/gen_bd.c +++ b/drivers/dma/bestcomm/gen_bd.c @@ -254,17 +254,23 @@ EXPORT_SYMBOL_GPL(bcom_gen_bd_tx_release); */ /** - * bcom_psc_parameters - Bestcomm initialization value table for PSC devices + * struct bcom_psc_params - Bestcomm initialization value table for PSC devices + * @rx_initiator: RX initiator ID + * @rx_ipr: RX interrupt priority register value + * @tx_initiator: TX initiator ID + * @tx_ipr: TX interrupt priority register value * * This structure is only used internally. It is a lookup table for PSC * specific parameters to bestcomm tasks. */ -static struct bcom_psc_params { +struct bcom_psc_params { int rx_initiator; int rx_ipr; int tx_initiator; int tx_ipr; -} bcom_psc_params[] = { +}; + +static const struct bcom_psc_params bcom_psc_params[] = { [0] = { .rx_initiator = BCOM_INITIATOR_PSC1_RX, .rx_ipr = BCOM_IPR_PSC1_RX, -- 2.55.0