From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A560132B13E for ; Mon, 17 Aug 2026 05:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786943343; cv=none; b=d42oVS+WnYd6wqp0LybaOf79Svx0Ryr7z0suE1f4fnGu1eQH5bhfjbnJh5z5IGic+c94OEhjlwXZWBuz8fcmj+MKLs/MB0ByXesZo3akAd9Ng7la3i4rx/E6pveYf6/5ts3ATmAvpmC7d5D/4/dkelScYuVUYz/QgQvcYfJLzWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786943343; c=relaxed/simple; bh=/eN/Kf05YOHbKQdrrbArM5JHYbujeG4z4H4EPRJtRAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bEyigpkRZSyHR/mNaIG0FUJ/bQ+csnm4n6kYYPguvtU11ALbrDFCBd6ZoGIRxSJKbw28VF5Utl1PPDxe175cmsBTHM6LL2PhI6E+MtGyFfMzZXKM67bVLYK88i6Te9t1SSGOVoG0KmaYtVI0NA+GA2zhYizur3qv1U1bTlXZ7aY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iNoytTlC; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNoytTlC" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38dcbade417so2922229a91.1 for ; Sun, 16 Aug 2026 22:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786943342; x=1787548142; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z/x7VDroEtisLQTINSAgqdabiGVN6bRi+UuVMbVvFgk=; b=iNoytTlCIQj68XUN8/nf0GvieTDfVCvMmvAEiTS+a18kjFxc4pzV6YdEzPeoZiFxf0 Np1h8MQEwH2BHGKdUPv6sbr2ni6TOLQzxnsPNoDs+WgapC+Y1v8X58lsF3DlRalwbWdM 9hA1my+VGeBmpJfOkQKnuMRQgCZI3sUUPDfbgLe4yLMq1wCgZNScTJwsXTLL5rfjI/uZ wmfAOyffjhxXAuTNifhH39lthknEbwb/fJcFpyGyZklzBNlS375ijm9Mxel5HeE1YDXu S1dWcuSTCuPJO6BoBCAPXNzOA/eVA23fc/5IuTy+Uyi28juXDWntvRUpJ9tmRgx/hLAq WyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786943342; x=1787548142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=z/x7VDroEtisLQTINSAgqdabiGVN6bRi+UuVMbVvFgk=; b=WFmKvKLqTUHxsSVQDmYCoaatlmpvgwHFdWIfe0p6zMrdyTRgfW+Z8A1+/vsJmcsNAC mRkRkwyBOu2iA5r6up3ZcUs62BQRLelqNT+yBhUF5tpcRMzVsrdqV3lKGbdDb6+tv4aw oINupEShJydKmEQ+7DGaU+cSC4cVqWs8YmNJ5uwKeMjmBcmAAOz0iSPsPoJYRcGBJCvb jlUnH18d9LOdwlgOx2rEUwV9atja+nVAo/1pcMsfHRyS4Wj+TPMIIZyZbK30MDNEtssJ HkUAf0xezU9y0LCm6PZE0K3jcGAWRS8Zbl1XAlNDb+DpYwbopR9Jaxvgd9g0ftlgdh2G GxeA== X-Forwarded-Encrypted: i=1; AHgh+RpKMVLeJtZ96DvqD1LU4gVNB0EQsDhFHFWUeaE2mGGQGFMPXXSu3z51LFV9jA+/pJBE1BAyLmCOkcibj/w=@vger.kernel.org X-Gm-Message-State: AOJu0YxVnNEwvUSkppLRMDj4q+RU/QVrEnhlvON2aqfXJ/LgB8JjBS/u f8FB1/tTp/AhC9zhMMeL8VDrSlfilOrZqWZQ+pZpzyB7E1l9li1AFX68tD9F5X+H X-Gm-Gg: AR+sD13PGIA3WZtQ2gpfY6iIt8unW1fR1ye6DasD1Fvvu36qrlkZnUYaE8UPncEnROP YctSrKicFAyS071ZE0YzcjIwmKrk9D16xSI3LVw+QtepoUUdFz/YiWp6J/+8QvOr+TGPWEsQJC+ uXJNSukJ53uI4sHGrdxawNpjSs55+IhcxPG9HSlIdD9AvE13WuKz4du/MT+6vFmoIBEtefxaFQW JIeNKDx6LC2xjZVNlyJrTsMZDoP0bWHZcpXhfdaZBJdv+QLxP9LM/YnjunBNRxEZRzS7qDpUiDK 3zrSali3NOe8ziBQzKt6PKkMoxKM47K+Gaah0Qzq/vrfQXAMqSR3gJXdnYGpx3xDhAs0qzIj4uY AoUBI2gGGLq8JsnhuNcCX+Qq/QEaIsXTFHl7R0eH8x/AuE2BrEEdP7s+84zeMXlwME9g74I4sdT mVoMlEdiGnbhhaeKVuiiQA47+GVi+4p2h4qQxQZXDgWSP97ywjkcR+riVMfUg7Yjugr/4UO7ay X-Received: by 2002:a17:90a:dfcd:b0:38e:c7b0:84ad with SMTP id 98e67ed59e1d1-3933b503abcmr23137686a91.0.1786943341831; Sun, 16 Aug 2026 22:09:01 -0700 (PDT) Received: from osman.mioffice.cn ([43.224.245.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3954d3b3b91sm712731a91.13.2026.08.16.22.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 22:09:00 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Chao Yu , Jaegeuk Kim , Sunmin Jeong Cc: Zhan Xusheng , Sungjong Seo , Yeongjin Gil , Yunji Kang , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] f2fs: fix i_size when pinned fallocate partially fails Date: Mon, 17 Aug 2026 13:08:52 +0800 Message-ID: <20260817050853.3437985-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260817022723.3324123-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On 8/17/26 11:12, Chao Yu wrote: > Can you please provide a reproducer? It needs a start offset that is not section aligned, plus a fallocate that hits ENOSPC partway so the error path runs with expanded > 0. truncate -s 80M img mkfs.f2fs -s 1 -f img # 2 MiB sections, sec_blks = 512 mount -o loop img /mnt touch /mnt/pinned f2fs_io pinfile set /mnt/pinned # 2093056 = block 511, so pg_start % sec_blks = 511 f2fs_io fallocate 0 2093056 536870912 /mnt/pinned stat -c %s /mnt/pinned filefrag -v /mnt/pinned 7.2, last extent and i_size: ext: logical_offset: length: flags: 2: 5120.. 10737: 5618: last,merged i_size=46075904 i_size block 11249, allocated through 10738, overshoot 511 With this patch: ext: logical_offset: length: flags: 2: 5120.. 10737: 5618: last,merged,eof i_size=43982848 i_size block 10738, allocated through 10738, overshoot 0 filefrag prints eof only once the last extent reaches i_size, so its absence in the first run shows the mismatch on its own. 7.0, before 4275b59673eb, also gives overshoot 0. Absolute block numbers differ there because the start rounding changes how much fits before ENOSPC, so only the overshoot compares across the three. I will add this to the changelog in v2. Thanks, Zhan Xusheng