From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6DED390218 for ; Mon, 17 Aug 2026 05:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786945195; cv=none; b=hCXzYBATOp4qaZL5aU6cIUVlnGa3va9hzkEoYTS7CuvkIpF53aNg9rDtGqtSrbMLgerBEOoYDJt3g4U/R8wZ7Gw190fZ0D1sq2V1WJxyZmHI0bVmyp/viX7XGnzAIDkD2izWIfPWYVGcT988d8XiSHulMwwmMqyfMaUd5XB1A+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786945195; c=relaxed/simple; bh=IrvJ6lgzSiKlSKyL6dUyYTSvKxvYZvOSwxQBXd1Hncs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KfD4x6sTud1E+CK/rgbVJHRv9dOKpimJPPPd9AKkeZ0hkKoh0ZybNnmyH4Dpykygsd/SQWNpCQLygXKQ8rInn5eRo/sh5R5d73b0ZqPT3ZZ8RmiYdnAm78D6Sm312fSCJrUe2kRyMP/67qecqzHWvgSBoAtSoKPSkIQyvLixI4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bg+6L6C4; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bg+6L6C4" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84e04df8c46so3242491b3a.2 for ; Sun, 16 Aug 2026 22:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786945194; x=1787549994; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Zy/ytYehsZsoTcb2/AmoaL5OkR/LozuHPUZF+r1PLNA=; b=Bg+6L6C4ZqQoAXPfOkwW1z2ik8TftNoDY5KYWWHxpiJSljpCiwYIUEYJsMuL8moRev bd90hWLPRwzfhdyrNQkEtc6jRy4IZCz35iqL4VFCKezog6OWhYSaW7aVnrkfMHg002zt u+P/zqUjZytiFHdOXTj1PdCuXM7NPn+GtAR5YZFHcu7B0AHAYfQnLh1VIdvDbsgVhZ5R fS+P2NPNR5646xbimVLUyCQg3AenTvId5PGDuOcll9nUFHl2kLPpcC6s/o6gfgwTmIhx hIKqEaKbwHE6RNYjzXPpzJDTA+YEqdBM0FMtxl/ikQFf4IVAR5K0Rqv9SSwPoi64qWyA IGPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786945194; x=1787549994; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zy/ytYehsZsoTcb2/AmoaL5OkR/LozuHPUZF+r1PLNA=; b=LEzjESL+YxAzF5ryXW+Sc1AI/q6SEuGoHwvs1IxqzAjUaDBTudkvHPzb62ICW7Ubjh CQJMVyPo4KaF4BO7ALs5wM6P9KDfKna/i4YX43sd+iSSN6rnL5w6yIyMyd2S0D4c/kSc udHxWgvHB2vIQPDY6gftQxeeXntxApqxYSpHZeXQkn4+dAFvOOJiKux8KR1p6IZJ5L+i RnvmBCEe9u0balXHc0J/+C8YZaVU/5crLCCY9ywWiegM0iE8Mh2M58gxn7N/y2lr/x6P nmt6WR6tV+IiLJ1KaX6oCJl1MQo3zDIZtBizIh/oJgMZnc7Ce3DeWpl2MwE4x8cJ7mr9 eLTw== X-Forwarded-Encrypted: i=1; AHgh+Rrgy/J887j/sgJ84Aa295Hm53NPhnnYl5WjahIRbsm668LBEQyp7trqD7Pb6pwACUAhF/VQQq6BNWFNIXY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3/y404zHCBnziiG4sFppH9eq0Dq/WrCGRwmVVfSXj50jzpJFg qF/Kb3YBqG1y7v0K8I3D208FgijWJi/ggCZcHHuvu6Puc+b8GYKXzcc= X-Gm-Gg: AR+sD136Jx+oiceXD1MWm6O7HK4e7auALz+EbelDUupCwSpjeJw8FMx/eXqdmdeVOv2 OeZAy1dHJy2UyqV3BpjmRQhhMcH5OaWxSexP4eMmPQTN4u3tSBrPJGh0fOEUXjaXI563xHxEbzf TdzR1N7er3Jd87flRENaewY38DN2BsmqDknjElwhGHKUSEP0wLY2CZ0N5+1niWCaUe09QYh3dW4 ZYQepK2hRl9/p9fv9ZHqgeYrMdVzsiW3SciAopN/PZMgvlAwuphehDF4KfWPUan/yEX7KKgOZ8n j7gVMZ7VbycUOLt7Rccw7Oo2OBqrJR70aXPYqNseg1nMt5WGg0pTaFlGgC5OcyFtnw6XMhosxAJ 33WH8nyS0LrOMBoEgyL8NlUN6kOQCwFSukvMQjxeWaIsjQZ8NamlVg9oSPu6xjxLgW+Bm6BYkd2 1y3BxKKnDYSflu0dkNophTKUsRD+UmI94j1l+zfugVPrRQyES97GWpT3QD8+o= X-Received: by 2002:a05:6a00:1490:b0:846:1698:638b with SMTP id d2e1a72fcca58-84fde2644d3mr18420435b3a.27.1786945193977; Sun, 16 Aug 2026 22:39:53 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8517d223f1bsm2273786b3a.38.2026.08.16.22.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 22:39:53 -0700 (PDT) From: Triet Hoang To: tomeu@tomeuvizoso.net Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH] drm/rocket: Check allocations before use Date: Mon, 17 Aug 2026 12:39:49 +0700 Message-ID: <20260817053949.819142-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the result of kvmalloc_array() in rocket_job_push() and kmalloc_objs() in rocket_job_open() before using the allocated buffer. Signed-off-by: Triet Hoang --- drivers/accel/rocket/rocket_job.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index ac51bff39833..2fee21988d27 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -192,6 +192,9 @@ static int rocket_job_push(struct rocket_job *job) bos = kvmalloc_array(job->in_bo_count + job->out_bo_count, sizeof(void *), GFP_KERNEL); + if (!bos) + return -ENOMEM; + memcpy(bos, job->in_bos, job->in_bo_count * sizeof(void *)); memcpy(&bos[job->in_bo_count], job->out_bos, job->out_bo_count * sizeof(void *)); @@ -501,6 +504,9 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) unsigned int core; int ret; + if (!scheds) + return -ENOMEM; + for (core = 0; core < rdev->num_cores; core++) scheds[core] = &rdev->cores[core].sched; -- 2.53.0