From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464BC3B47C3 for ; Mon, 17 Aug 2026 07:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786951255; cv=none; b=oExSoqmGNvFG4N7Vr7ZBZaEWU6wW3VzTTtX0e2tJghFyOgtVVyRnuc1Li5mY2Hb3xtyoIoskbptfyfLlwgr9C5QEjWhZU5P7+Bi0yT68d/vBKuEUsMVhq7j6SZWsyoAO4b2hCsSze9g/AsZa89HRrKRf45pSjOmtuKIeTEPiEcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786951255; c=relaxed/simple; bh=DDnMR9nsJGcXfeI/adi+B/WV/Eckq/otH91Zt3S5NSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R8/5PHgO+DIoqi3/iLcuVrSO+RxvxvTrpxBoNwmrsWOR417snT8zksC5+HcZWM5Zq86ejJWpZ2VXW7tGEKnsGt9KfzQ3CzUHeFjjGcUHFdk0Bjyktv0qAXzMcZ4mBwHi1lGRdaG391h7cPoBamjHo+vje/xFvHTqJDF8qP0Jn6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N9ONR7SW; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N9ONR7SW" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca766c1c9ccso1619225a12.0 for ; Mon, 17 Aug 2026 00:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786951253; x=1787556053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jtd38hsH3dGNiUrGGPtNYK9qHwfFDcPb/sf8PmxKYhs=; b=N9ONR7SWgXspxzntIK0tBHQK22LTDzrhcPAMTdWzZOQt9Pv64Ht2FsFi/Y3YXtNLo6 Z+qIWzr9gKbG7GAQbPJS7HjvS8mNZz7xBmZnkUXT2viyGUxQGQsvRqi5AYT7JvlR9RJN 9PqSUyCmMCltVOZeAWpBAL/5HeLkPcAPt2U8lT5oJmFLWHiX2/gdlAW/9YO49ZaPM2ek iy4VY+7FYjVdq2VDAAwpJPkOqlV100FBS5WArFBU6XuXd9Z/Fu+hhkjh7ytDoS/OjSSG L00BQMzed05UFVySQLwnO7IX3T1lieDtQs39bUppr5xz6Opv+kzkXDDHN43gOfgnI4Px sKQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786951253; x=1787556053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jtd38hsH3dGNiUrGGPtNYK9qHwfFDcPb/sf8PmxKYhs=; b=mbQzl8svNnU/zc0HBZzWoq/OqwbCP1TwoOYGYrWSGgDNHzN+zncBVOdYtqnFjQC4Hw xwGbJlLYqxaYgQnbKmdvrUPakr7YWArmIEFQsWvaWtT3e+OXmwa3Y60plrVydTFHHsmm y0nmA0ylNKcUa4zjsGOipTGeva60LBQH21fVX+LcageSsQWIShSCHKVKzgXuVQWnBGFW D38/jbD7pjkkoNIDXsg/J2tZapcVWtc8eeU8pfJ0Vl6My5KAuhgD+8OCj3DILJihaCEK l7AFHEHmwUgTjfLfpGzWEIIdmKs0Ay6tFvPBG2Sru2Yj/Lh+t7psqhOjABtjiTRRtLPR 3TkA== X-Forwarded-Encrypted: i=1; AHgh+Rp9tBUVv7mVQVnnp1x0cDDrx77MlTv0l1tDOIW27OFv2YJaikMcn7duc7PmhpiF8Zma9w/YjQq4t+gKZYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzjsNdk2CsUruPDs+u4+UzzxgisU55XCNfclyHomZGPlMs5bI5k 96ps5zSmBx98yx13eNSbROeYeyhIC4cCvdZW4DNEXDLIjTP8WncteM0= X-Gm-Gg: AR+sD12BIIkBuwrBscvg3W8SD0QYOu5U+9NkCewMMV8my7+CfnxhpaWNwb8fDzKn4b9 d2y+82iQzTe8R5HDvvvWrQGjMEuzd8Dma3G71RLmj+T6Ex6Cnlnb8W5kk0dnGXAmk+Xri/6lQ+y N9ZOjmM0dwWRljAT4CViCAJkwJlqDDMLMfXhLaCQ/nXDrB94Y0NXoo9Uqc0CPL/zTEaW8SJRzdT NZ6ljtskJZnepAhqIU1ZXEKSN+DHjI8k5vyV3Z/bObTRn5y6lNl6VJZtQveTjnaSQWekttS6DU0 lzPdIRwglmKhmn5PYH9GSmc8aEHOmSUt1q80XlLvbUnYkKv1tt7hky5a8ETNvXtQWzNShl+nhbY 7DxBTIQtFPzfiYNUfCDQQH6Wh7FjMFGvLvRBpNEHudR9QAt7Kmw7L53TNJdP9mHGXUNOxEQrgcm f78hYFobVjHHgt8H1VBWuhW8adoTrpjdrACiaWD7fZET0GGjUSrr8w8mNNAjg= X-Received: by 2002:a05:6a00:2383:b0:84e:89a:b8ec with SMTP id d2e1a72fcca58-84fde3d4d3emr20738437b3a.11.1786951253271; Mon, 17 Aug 2026 00:20:53 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc13bf02fbcsm284780a12.3.2026.08.17.00.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 00:20:52 -0700 (PDT) From: Triet Hoang To: tomeu@tomeuvizoso.net Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH v2] drm/rocket: Check allocations before use Date: Mon, 17 Aug 2026 14:20:45 +0700 Message-ID: <20260817072045.876042-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260817055315.C9AA41F000E9@smtp.kernel.org> References: <20260817055315.C9AA41F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the result of kvmalloc_array() in rocket_job_push() and kmalloc_objs() in rocket_job_open() before using the allocated buffer. Changes in v2: - Free scheds when drm_sched_entity_init() fails. - Initialize ret to 0. Signed-off-by: Triet Hoang --- drivers/accel/rocket/rocket_job.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index ac51bff39833..24e1a61f71e7 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -192,6 +192,9 @@ static int rocket_job_push(struct rocket_job *job) bos = kvmalloc_array(job->in_bo_count + job->out_bo_count, sizeof(void *), GFP_KERNEL); + if (!bos) + return -ENOMEM; + memcpy(bos, job->in_bos, job->in_bo_count * sizeof(void *)); memcpy(&bos[job->in_bo_count], job->out_bos, job->out_bo_count * sizeof(void *)); @@ -499,7 +502,10 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) struct drm_gpu_scheduler **scheds = kmalloc_objs(*scheds, rdev->num_cores); unsigned int core; - int ret; + int ret = 0; + + if (!scheds) + return -ENOMEM; for (core = 0; core < rdev->num_cores; core++) scheds[core] = &rdev->cores[core].sched; @@ -509,9 +515,9 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) scheds, rdev->num_cores, NULL); if (WARN_ON(ret)) - return ret; + kfree(scheds); - return 0; + return ret; } void rocket_job_close(struct rocket_file_priv *rocket_priv) -- 2.53.0