From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA483BFAFA for ; Mon, 17 Aug 2026 08:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786953627; cv=none; b=RSNsxJ37VmmGnwHS8kSvgSHI4pNpnEW+bsV8QAaL/OKOkbNXnK27zu5CArD9/7PFJYO1wOXE9YewjBVcqQyHAU5SaMKpNdbhN8XqN9r+WpADFyuIZTQA5SPcPdcwTmijnbkGtO/kJ0fwbcaytYhvWV19jJ8pHGBSPrzi5DfuqKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786953627; c=relaxed/simple; bh=nEbPJirofNZR8YP113Zh20revId+ONhKdsLyIjSEW/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uoNmQruclItIVYGkL+bKegkfoRV5MXI0LVDf0jsj1dZlr7IyfmSzrM8NLWSFmbLG6nbvRm+zPSkyICKDOkmNixvMs36WsmHsRPLy+PBsIEacWGpDVac2WYe3KJK0GtjQUlS4qfvLhSDdmFNItSIkrWwx2HKNWTUwo3eJZK9kcRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hgQugWja; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sKIICn1L; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hgQugWja"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sKIICn1L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786953625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DwTYrOnwpgdP2owyQAuLgoS9oPtit+Bxu8ttOzaSjxA=; b=hgQugWjaRdoufhVRR5GWA4v682o4V7AtogZ8RuzQLInIqviRiKieaWWFVo8fsdnIXUxW1B ySSoLy4j/PVQHXSq3A4v9YBIvWlmuNvJHnXA5TVnCXV4s7sSR+fpnnQUk/ZpVQeoIL7nPw j1sFUHiH9PXrL8IIqXG+S7/epwwsI/w= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-GQXstgW3N8ahhSZz0OSUNg-1; Mon, 17 Aug 2026 04:00:23 -0400 X-MC-Unique: GQXstgW3N8ahhSZz0OSUNg-1 X-Mimecast-MFC-AGG-ID: GQXstgW3N8ahhSZz0OSUNg_1786953623 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cbeeaabcadfso3844756a12.1 for ; Mon, 17 Aug 2026 01:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786953623; x=1787558423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=DwTYrOnwpgdP2owyQAuLgoS9oPtit+Bxu8ttOzaSjxA=; b=sKIICn1Llne1XzO/RkXqI8VmXUrb/O+SW+I7Ahfz6zJcwgRe/oGQys0goxJHwgKRia 5polbKsQtOTOJkaTW94ILb0aHWfY3z8OJPgynIVnt8gKRjTo3vAoHmPuauuU3zghS37e xz8dEJFXAGfsFS5PNcui1TxZE5szRBRMLpZdwtrxTbKafJ0SlWb+0X5czEFeVbiiWKm6 Bhlb2xdyeI6l53I+jar1pcDWqURfOdWg3CIMUaWClWGXULUn9C0hUJmI8LDBSEiXa9eu tnuJ98Lx5G49/8ARAk6T+NRP1eIstoJl5lRqMBuMEdN14SHZtQ0aE5KK0aCG8CU/8kiE rWFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786953623; x=1787558423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DwTYrOnwpgdP2owyQAuLgoS9oPtit+Bxu8ttOzaSjxA=; b=IzQ7yO2QByLZkBRRUEMVhl5S/9Ph06mrSXNvojoQSv1I8jVETLSyuMk7UDZ64Z4OL4 4jxPVIWpYykvHnHQfEWhAV4TLj/rOVVkjPr/epu+wwGV7EMiOy3ToW9R2IzkSebR+C28 4eJhTk4SIMSAdjbKnsqvO3aZ4+MOYXo8UvOoM+NTEerGW9pIVNWHJrH6pwgSyaeSNa0w IVjFJ8dRzWLb63KILApmGrXqu+KkjQ1mNZaAOuiBO36Evxb5VZdef3EvEAwbwi4KgiAV TTigHcyA2zljALnU6AXMwF9VoHmRBWrg34nWLwrRDbfQJsINsDDMyYQivRco43f2wzyj McTg== X-Forwarded-Encrypted: i=1; AHgh+Rqki8GBObps4QGZmIXYXjmphLYBqebS6w0eLeA6xLv6PTfXUWr+V7zx2AvjJIC09MNvImK65XzbGK99wBo=@vger.kernel.org X-Gm-Message-State: AOJu0YyVrn3TQGlWNMfoyRPc5q5v6n/aZx6nCUdlXson2y+XKO6dQXnQ 6j0tQ+tgaSa4SAveoT6hdUHFWHNoViLFHBqdOKBAwjXoTRTV2QIz3wd/tdVGAVuPkdwQ4v4DHHy m6Z9C3cTEbDJkoew3surjk9Vkn6TXnmvOwLxGbiR1sb3OKrjZienMTRI2juQ6H1S7HA== X-Gm-Gg: AR+sD10ZkRk5+o15UvVFiWzM2tfkBTh3exCzjQI35Dz+tWcHjSDlL4sZvx5k3szZp99 mZ9ibhNfpaA0keuzGRUmq8suvRU5pGqiE/qktsGNhdWhdrkLH3cFbi4OSbmlNmAt9+vNDArxmEt DEyVLqBfaCzjCx6y5mrqY9nYRxDZQ0FM3vnsQIL/yDLQk8n+RtBs/OU5fNbUEHDBhV4YB9pHtTq ulxgSGQvIeTXhjCMOtdnml5yB2abBvTwFQA/WtApgPawgyBXA3cqwLZQT/VAL5wlpb20e+gEn+P Lq3YGNhVaq+Pi33tD9nH4S2Swp+WtMccnwWgHu9fINR1sLH1ilI532h1RMoeZszT1TAf1W2TLg9 qlai8OQ42fd4/OSMt1ainTMYk X-Received: by 2002:a05:6a00:4ac1:b0:847:9aa8:d3bb with SMTP id d2e1a72fcca58-84fde15f1a9mr21594360b3a.12.1786953620460; Mon, 17 Aug 2026 01:00:20 -0700 (PDT) X-Received: by 2002:a05:6a00:4ac1:b0:847:9aa8:d3bb with SMTP id d2e1a72fcca58-84fde15f1a9mr21594266b3a.12.1786953619846; Mon, 17 Aug 2026 01:00:19 -0700 (PDT) Received: from kernel-devel.tail62cea.ts.net ([240d:1a:c0d:9f00:be24:11ff:fe35:71b3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8517d249b39sm2310673b3a.47.2026.08.17.01.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 01:00:18 -0700 (PDT) From: Shigeru Yoshida To: Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , felix Cc: Shigeru Yoshida , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] SUNRPC: update clnt->pipefs_sb on pipefs MOUNT/UMOUNT events Date: Mon, 17 Aug 2026 17:00:12 +0900 Message-ID: <20260817080013.564939-1-syoshida@redhat.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit bfca5fb4e97c ("SUNRPC: Fix RPC client cleaned up the freed pipefs dentries") added a clnt->pipefs_sb field and a consistency check in rpc_clnt_remove_pipedir() so that pipedir cleanup is skipped when the current superblock does not match the one recorded in the client. However, __rpc_clnt_handle_event() never updates clnt->pipefs_sb when it creates or removes pipedirs in response to RPC_PIPEFS_MOUNT and RPC_PIPEFS_UMOUNT notifications. This causes a problem for RPC clients that are registered before rpc_pipefs is mounted (e.g., before rpc_pipefs is mounted during boot, or after it has been unmounted). Such clients have clnt->pipefs_sb set to NULL at registration time because rpc_get_sb_net() returns NULL. When rpc_pipefs is mounted later, __rpc_clnt_handle_event(MOUNT) creates the pipedir but leaves clnt->pipefs_sb as NULL. When the client is later destroyed, rpc_clnt_remove_pipedir() sees that the current superblock does not match clnt->pipefs_sb and skips cleanup, leaving orphaned dentries whose RPC_I(inode)->private pointers reference freed rpc_clnt memory. Any subsequent access to these orphaned info files triggers a use-after-free [1]. Fix this by setting clnt->pipefs_sb in __rpc_clnt_handle_event() on MOUNT and clearing it on UMOUNT, mirroring what rpc_setup_pipedir() already does at client registration time. [1] BUG: KASAN: slab-use-after-free in rpc_info_open (net/sunrpc/rpc_pipe.c:426) Read of size 4 at addr ffff88802ebe0800 by task cat/5079 Call Trace: ... rpc_info_open (net/sunrpc/rpc_pipe.c:426) do_dentry_open (fs/open.c:947) vfs_open (fs/open.c:1052) path_openat (fs/namei.c:4700 fs/namei.c:4863) do_file_open (fs/namei.c:4892) do_sys_openat2 (fs/open.c:1368) __x64_sys_openat (fs/open.c:1385) do_syscall_64 (arch/x86/entry/syscall_64.c:94) entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:121) Allocated by task 5048: ... rpc_new_client (net/sunrpc/clnt.c:377) __rpc_clone_client (net/sunrpc/clnt.c:645) rpc_clone_client_set_auth (net/sunrpc/clnt.c:706) nfs_init_server_rpcclient (fs/nfs/client.c:640) nfs_clone_server (fs/nfs/client.c:1247) nfs4_clone_server (fs/nfs/nfs4proc.c:10683) nfs_do_submount (fs/nfs/namespace.c:288) ... Freed by task 24: ... kfree (mm/slub.c:6692) rpc_free_client_work (net/sunrpc/clnt.c:987) process_scheduled_works (kernel/workqueue.c:3405) worker_thread (kernel/workqueue.c:3486) ... Fixes: bfca5fb4e97c ("SUNRPC: Fix RPC client cleaned up the freed pipefs dentries") Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Shigeru Yoshida --- net/sunrpc/clnt.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index efa26899bc7d..55617d263d2f 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -179,11 +179,17 @@ static int rpc_clnt_skip_event(struct rpc_clnt *clnt, unsigned long event) static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event, struct super_block *sb) { + int err; + switch (event) { case RPC_PIPEFS_MOUNT: - return rpc_setup_pipedir_sb(sb, clnt); + err = rpc_setup_pipedir_sb(sb, clnt); + if (!err) + clnt->pipefs_sb = sb; + return err; case RPC_PIPEFS_UMOUNT: __rpc_clnt_remove_pipedir(clnt); + clnt->pipefs_sb = NULL; break; default: printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event); -- 2.55.0