From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D22F941D11C for ; Mon, 17 Aug 2026 12:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786970480; cv=none; b=drh9vr8zReeUyZ4lIR4ZshtgGpaBl+By6oNIUhtyqLT6GHNeK6rxTPaVxt+K/DUJswyIxFuT6S9u+UcXwwKmZobzF4kv0xmlJRJ8eNsMCMkowNPAqAbx43CCKEaIwxmNDiwEW9oRg5PtMavxw+2Ft9/fmL93Fro9cOBKzEAHzYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786970480; c=relaxed/simple; bh=XpzDSGLqZ8oshW6QLL6AkRrKripZJSM32hTiHlFT9Ek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pkpEiFcXasysKJM8xBcnZG51XrsQ+Z7Kbapx6nN/xb/F6OoxVOjsBVdOxtik9eClKj38ov+4FLlilKaazU8wCVvGRpC7s179tskFDsZ8Wk47znFR8bQc4BuyuYR59wfx6ObRGLpZH6EmfouBU3hiVrjbrZoFwxrlKdTt6atBs8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GPLeXLX2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sKYeVYIr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GPLeXLX2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sKYeVYIr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786970477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QT5P0FjYJIXNb5bpOKh/Iv+72OmLL9osWf81HjiuK1Q=; b=GPLeXLX2rGUmzNDCQzeZfV3PWdsqhaNJVI1LwM0QXoEb7EsYb/RCCtB1mTGoLmEuetNw/r gOoDV5uokzbsmwJf0O4QAg69zRy+L7Jd3OGh4KvoQPwDjn4SEGto+GJXjKH+t8Wv1dBDzj zAOUHWEe+5Yy+RwB/NbNjIbIvs46t8A= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-9TF_JzMVNgqc-MupDvgJFg-1; Mon, 17 Aug 2026 08:41:15 -0400 X-MC-Unique: 9TF_JzMVNgqc-MupDvgJFg-1 X-Mimecast-MFC-AGG-ID: 9TF_JzMVNgqc-MupDvgJFg_1786970475 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c1c232fa136so141817666b.0 for ; Mon, 17 Aug 2026 05:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786970474; x=1787575274; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QT5P0FjYJIXNb5bpOKh/Iv+72OmLL9osWf81HjiuK1Q=; b=sKYeVYIrjtMcI5xs5IGArgQmAHbt2bokS4xDVGYi18daNd0m6c/hAQ/TJTGspkJN9A xPxZUAyL2IGcKnrQm/873hv2Wz/Y3NEDr6V0CUpIh1/7LKPSL1TEhubPA28XllWHhzJw u4BrtAG8C7KHcu0JpFBjrdm+iKBcn+T/P2cfUd7QjZHMXXU5GlYGzYQ8RFl+O4FRdUb6 ls/19QP19K6LE6B93oD2ZxVXWwxbAIsSOHvsIj0TVhHtoYLSlcAzGBPSMlbXlUp7hKoZ s3XT/dELtLz+J+wc49ENv4OCvD3oYf6LzUKz6to0pKNLtqNIZfsRyrS/LZn8uZgjujq1 E24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786970474; x=1787575274; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QT5P0FjYJIXNb5bpOKh/Iv+72OmLL9osWf81HjiuK1Q=; b=fSkFtw733EVrlMaBX9HozHN6gdJRK+k34s1BgdBSqCWK4ciZuUZZKt/oh+HcGvGaXx IlvLCF0SDZ0bY7ejk26ki0ReP9+s0+9D5m5TJFTGzd3psonWxejAH3Ky5/JWPT4Qno+g jYLZx185pqE5F60ht5uDJc6ih3lvb0+rKRzmoD6HuG5y7QP0yZSm/EIbd1Y+o5HtmoYs dr8A32nKZ8U2jkAo1D93tz0zWOf1FT2ZupyOI3JZRSxuPwk00H4cgpEIf/Vp/q+Onv2N lSSqGqWV6bFw2AgV7Ms9Wp792AgOT6Nn1QYlw/5QgxYJJlxarS5dt4fMpbNJ13PQECd4 IT9g== X-Forwarded-Encrypted: i=1; AHgh+Rq3oJPf61GiaNXJTYSl6n46/NSyfBVkaCAf/vi8BIz/MUFztR19yZvXQPdglQ2uKBdEHOAnIqecQWeL+8c=@vger.kernel.org X-Gm-Message-State: AOJu0YwKnxYyHG0jA/WaxgPhXMewNZMalMOKZ4cKXfbCzaYw+PR9NLML OmuWGO7H4N8saOHX0hWmRvbIBqVd7Uz6tSWVV32mfi1gmcuRSj5cCbhANPgtiIXZx3mmNYVMxwP i0dYIzlydwFaXx3P1nN/upR3MM/XyWuH55zT99SqTcYp2x35eAInDYa8oFHgrEy/6uQ== X-Gm-Gg: AR+sD1239VNJqbRSFX9QvjVfYIE9vPJT690d9HT8OtOYW25YTlq5z1qSPQvNNJK3FIU XylD+aZCwzgybEmbE/xSL0SjYi2LJn93vrT0OI7ZdtKr1UCiCdT286Ar1gENIVzqGNcH5naQfqb ZLhc3XrZ4XLq5lDQ168Pa0cBKeGPF6Bmam7stW8ELRLVkZt/xr4eG/AlOhpB8gcn50vGG6pdnFq 5hKjVd2gHQq4d+0ZjxfXzksH3Q+9cqGBuwqRbI4c6oMNM1yqxu3tdxOKWjQJ4BfPxRInYjRuC3t qwXiJkuxY40LvCINzbnclpwCOR5PjcG0/AlPopHem+6WLdje4s7Cg+F/L7tyJFgf4AO5FcLMUvF YJ2jwqFWqyp72XwK7I0g9L1gT X-Received: by 2002:a17:907:d0f:b0:c08:580e:899a with SMTP id a640c23a62f3a-c212aa1d477mr1206731466b.10.1786970474023; Mon, 17 Aug 2026 05:41:14 -0700 (PDT) X-Received: by 2002:a17:907:d0f:b0:c08:580e:899a with SMTP id a640c23a62f3a-c212aa1d477mr1206726566b.10.1786970473289; Mon, 17 Aug 2026 05:41:13 -0700 (PDT) Received: from redhat.com (IGLD-80-230-47-107.inter.net.il. [80.230.47.107]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c217fea2cdcsm52972566b.18.2026.08.17.05.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 05:41:12 -0700 (PDT) Date: Mon, 17 Aug 2026 08:41:09 -0400 From: "Michael S. Tsirkin" To: Sergii Ushakov Cc: Christoph Hellwig , virtualization@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Wang , Jens Axboe , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Paolo Bonzini , Stefan Hajnoczi Subject: Re: [PATCH] virtio-blk: clamp max_segments when indirect descriptors are disabled Message-ID: <20260817084042-mutt-send-email-mst@kernel.org> References: <20260814105954.4060627-1-sergiiushakov@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 17, 2026 at 10:08:21AM +0200, Sergii Ushakov wrote: > On Mon, 17 Aug 2026 at 09:47, Christoph Hellwig wrote: > > > > On Fri, Aug 14, 2026 at 12:59:54PM +0200, Sergii Ushakov wrote: > > > When VIRTIO_RING_F_INDIRECT_DESC is not negotiated by the host, every > > > scatter-gather segment in a request must consume a physical slot in > > > the virtqueue ring. > > > > > > If the host does not advertise VIRTIO_BLK_F_SEG_MAX and provides a small > > > virtqueue (e.g. 128 descriptors on QNX Hypervisor), the block layer > > > defaults max_segments to BLK_MAX_SEGMENTS (1024). When a multi-page > > > compound bio arrives from the page cache, virtqueue_add_split() rejects > > > the request with -ENOSPC and triggers: > > > > > > WARNING: at drivers/virtio/virtio_ring.c:1493 virtqueue_add+... > > > WARN_ON_ONCE(total_sg > vq->split.vring.num && !vq->indirect); > > > > > > This permanently wedges the blk-mq queue and blocks all subsequent disk > > > I/O in uninterruptible sleep (D state). > > > > > > Add a virtio_blk.max_segments module parameter to allow runtime cmdline > > > overrides, and automatically clamp sg_elems to > > > (virtqueue_get_vring_size - 2) when indirect descriptors are disabled. > > > > What is the reason for the override? > > The module parameter was intended for two main reasons: > 1. A safety fallback for non-compliant/buggy hypervisors that may have > internal segment limits lower than the advertised ring size without > advertising VIRTIO_BLK_F_SEG_MAX. > 2. Debugging and performance benchmarking of smaller scatter-gather lists > without needing kernel rebuilds. > That said, the automatic clamping to (vring_size - 2) resolves the > hang and panic out-of-the-box. If the preference is to avoid adding a new > module parameter, we may drop it and keep only the automatic > clamping. sounds better to me.