From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B1EF3E558A for ; Mon, 17 Aug 2026 09:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786959125; cv=none; b=e356jG01iv7aJ/C/Oyx+wi6LJyG7UDXbGKtEEMi7UXUk23Ha/jKvTqXmByQntlXV/s738ph4WOLdI1B6dSJCRkSCfab49X1ftxqm8SGv3Dal5JYWxmJYhen3WaR+5WygmUGAsOFhO3qfO0QBQiUwH05x3jJkU3XaVZHA6Wp2MYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786959125; c=relaxed/simple; bh=74JQwkPbeM8yMbthkblrbO2iE0hdLKuxSYroxOscLMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZheLwhasLV4cHycgfVkzvYXJ9RUnT8PVuBEZVWWibGDZajl+GKi3alGEAnva14xIqLRxw+J9frbQdwfiFWAeRyrW3nUqZZfzwTfH44kb4K2nY+rbMnR1CL4EyFZMMWAaQVp6F3PZb3ev2r2N3Vj7yTyXHwQwYy0tTD3X1VYlyjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHkgSl3D; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHkgSl3D" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38dfe910e9dso3018321a91.3 for ; Mon, 17 Aug 2026 02:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786959107; x=1787563907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mr+TqHpD4NfH87dyjxCAi72h/kE3hW+J/KRhRismO0I=; b=bHkgSl3DBAaUyUia42VZN/cBj22elDtv+EpCUzO3mK8uFScWeckUz2WW5DS912+IqL RR7lFzhI1JzI0EbJjMjNIwcAzBwIhKKYk5SVhKVAsqLyvpC0d/vIxzXaCZ5U6lzMmY9T QsEHLWBeEv1Y261Ymz4QhifTBLhsrnc0TDOrgNkUDetp1y0f7txkCSBwb5/SOMG9+ssB 48OlVXvyc0uzFiyPbknsY9kzYwGpvwbAiVcqZZmydXxkWQ8ciQE0PJ90wwOaiFiYHiqc w9W4P3i3zyOML3q9ChW+nlaCXIgdzT2c3HnRMmK2+zKRyJ/12onDAa8Ph8ekOH2yR2ZK /iHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786959107; x=1787563907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mr+TqHpD4NfH87dyjxCAi72h/kE3hW+J/KRhRismO0I=; b=lcAzbTcrVjE2hSK2M6X9Rx1GgYYHI1J9R/P6eAeyoU8TsKvegwmynFLfaj3268E/v4 fBuqWoP65YPqRfVp4IqoLGvDbgtpsSNze9V98fU1mjl9hVGqqIEpGy75pbfGL5zC4h3z VYaMpxte9gC5UybLmW3IgqP27oeuyDT9w+nAwgdv5zkR6bDKcD5I6oGsamlTn7ivNUwh njmscEFzezEvd3Y7zztmX5HbRcPcUV0odZO5GrJdN8vHZyqh60L/OAoWtkcSdZK6d0/9 GNu+bEpHT/W8KFndeiiLZNMJ7DTNLoWsbMUa5nXKYyRpMCTLNTLmFmwMRmPdelS5TAKE DqTA== X-Forwarded-Encrypted: i=1; AHgh+Rq472CExLQOhdqfeiY7e41mWr/+QzovSKTpw1cWGklj2VNqeEEEhmZMFOroqHZOEe5XW3VQDl/+Xg9oHjI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Daag0YnpuaiL4K+Y7uxRhEXAt15WX5nRyUwtzowlovcdlLkC 7E15Je+0hnDh1xE4x+F9E9weHSP7eLEL0/oy2+mboEFhdTf1rAn0OR0= X-Gm-Gg: AR+sD12iVkrKbQInc5qrHSaXB54cQmZHoXGJJloE3CzzD3a4kNyqw1ODCikISGtT4tp OTgePk4QTWq+QzeiD1q71HHu+aMIL7uHFvDABKyxWhkj1JGnEfRG352AR5VVo2nDKSGEiVLlBsA TgncTOtXxR0bi7Uqlrj2HlFMX07MTesVxF3NHf3DOF0pBZSdZrlwnLVO78lm15Zxu3hNumN3/pe Nmfd7t/pGYDd2Ti5wLhdj1wEWGU+4RJpICva9MJEAwb6sMKy9mXsFuLDdF8DBjBVy/tfbHDN1Yp cJ9+6f9uWp61lPfTjBKRdsVKFN0XY+UMwvX+QMvJjux2n9RVV3nIi/rz61kAQQ9VtLiN/3rSOwo Ypughlmq15D64QuDcVmw96+USZ2vdR71EZF8BZHw8mapd9CC9URWNW6S88U6WG6MqPal7XGqwZL nbIFsC0b2NE3LDgLEFapi38fBB+FLjiQwowczDuoNDZ78grbbdPPgUsW91OQU= X-Received: by 2002:a17:90b:38d2:b0:381:6c5:3f63 with SMTP id 98e67ed59e1d1-3933b807a97mr22444654a91.6.1786959106729; Mon, 17 Aug 2026 02:31:46 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3954d2e1a09sm1616832a91.7.2026.08.17.02.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 02:31:46 -0700 (PDT) From: Triet Hoang To: tomeu@tomeuvizoso.net Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH v3] drm/rocket: Check allocations before use Date: Mon, 17 Aug 2026 16:31:42 +0700 Message-ID: <20260817093142.975407-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the result of kvmalloc_array() in rocket_job_push() and kmalloc_objs() in rocket_job_open() before using the allocated buffer. Signed-off-by: Triet Hoang --- Changes in v2: - Free scheds when drm_sched_entity_init() fails. - Initialize ret to 0. Changes in v3: - Move patch version descriptions below the '---' marker. drivers/accel/rocket/rocket_job.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index ac51bff39833..24e1a61f71e7 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -192,6 +192,9 @@ static int rocket_job_push(struct rocket_job *job) bos = kvmalloc_array(job->in_bo_count + job->out_bo_count, sizeof(void *), GFP_KERNEL); + if (!bos) + return -ENOMEM; + memcpy(bos, job->in_bos, job->in_bo_count * sizeof(void *)); memcpy(&bos[job->in_bo_count], job->out_bos, job->out_bo_count * sizeof(void *)); @@ -499,7 +502,10 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) struct drm_gpu_scheduler **scheds = kmalloc_objs(*scheds, rdev->num_cores); unsigned int core; - int ret; + int ret = 0; + + if (!scheds) + return -ENOMEM; for (core = 0; core < rdev->num_cores; core++) scheds[core] = &rdev->cores[core].sched; @@ -509,9 +515,9 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) scheds, rdev->num_cores, NULL); if (WARN_ON(ret)) - return ret; + kfree(scheds); - return 0; + return ret; } void rocket_job_close(struct rocket_file_priv *rocket_priv) -- 2.53.0