From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E75B3F86F9 for ; Mon, 17 Aug 2026 10:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963709; cv=none; b=o1BwaswlJoqjHZ3F8rdzMwYeP+8RC35OqoEYLhgCcoqC6ISGHXle3qLhYVfq+5yARpiSeDHEXnGGaKRkhh46pN4VzZYD0auc/fqJBFpQjyfXds3f69TozwCIR636l9+A8DqcqeDB8S23q+ZWICTYoDmwhYjZG/oQElqJ+u6mh80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963709; c=relaxed/simple; bh=QNQGAQMvi98odGpNTyWdFaTAXKFmq6Y70G0q+N0VGr8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SHNpv1JxRsI+x5ImUtUSd0GPJuUTg66bGmSeUsgKOJdbAJCNJaU5C1mHXH6zOK7cniBdaF6A80fxQ7X1XXfJvjDEaXQJmzi8qllAPRQOZuwuv4JQJDZ3gcgr90vFHHNmIVZaLY6enlC7ohyI9H1RNae7EW/waq0ss7pIWPl2Ksg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bh8ZJT2A; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bh8ZJT2A" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5aeafa51b5cso362770e87.1 for ; Mon, 17 Aug 2026 03:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963703; x=1787568503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tufsylix9QRWdBSzfeQ8rMK41gi/ULWE3IKWJZ+mOhE=; b=bh8ZJT2AxW5xqd16OIIippJiBTQ+yzQBdLZ+ViYCzkLM6NZLofFRuV9Y+6ROjXLtMI arnhBG11bBiMUwMTdADiQZ+lHrpfLVzGGizN3jHmVgwdhHVEwAKoN0jtfNy2v+jJMsVe pwba4wXNAWvRz8/HmBH4ZoMN8QbTS31oO+EWA6l3nFOe1LbJ4X3TtIY38aZ+aE2GeBaX 6RSNawW8fvSiYIJ7488FxYh62Eno8gPUJ2ufU0SSvEqZcRmQvi1d87aJfd/jyg/DJwek ldW6tOKIxc7B4kf7T4z+vxi1yhug9VRJp318QR4jk0/qB4xp10nNKIW1eoCP8oJpmzC8 RhHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963703; x=1787568503; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tufsylix9QRWdBSzfeQ8rMK41gi/ULWE3IKWJZ+mOhE=; b=EszhjyTFL1288B3dt4Uuh2FeDyrSbQnV+qUUhJizx5L0wObnqk4YWTfPb/TIT706h7 WfvmbEoqRm620S3KGf4/5uf/humMneKVaejDsQFegVzjTaH7sEPiG2uvDByU0BrBOWUU z/N2k3EUYlpohj0xxZ0ueKvGDwuWw7kpvbbHyS58/kv3evPje+KjMpfi/O4SdMvkinAq fVPGQ07k2FNsuCOwe0R6jsI6j0uYe2xvjpk22h+xDv4Q+NwNLmoCOxWeawJvb/IBVUEh RAZ1hI5GADj2Dz4ei9liF5VuEF6t3pias+pEWhRoXqZjORdOR/7v8/eizuX9S/BCmI9o uHMw== X-Forwarded-Encrypted: i=1; AHgh+RpXfkZmX6Kr0lBwl/znmNKRJzS6lcBfl2Pf0N0FNKhybb6raI+fojeCOmD5o93KSx6/c7q1d5oNzlZTSIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyeo04oAt1HNwoKhmKgyUOoAx50S5AEAD26wGQcYOQ/OEv8zJgN mGRZlHC1HbctlEwd4k0EvLgXPPrGvdGjO7CIsCFKZCq0ODvpKKFOLOqr X-Gm-Gg: AR+sD11H/OoF8ofzj9ExrB5uXHx6D0uUubtnqvFtse3fLqpKsWhDI0OsjbtVxZFY4cx boP8Qh6dKNbh/elQ4HuW3Q1G+8LCBYajWFcwtIhJzoL668TniYoghmzVQmDUuyi/77FJJOmqHAX 8MQ99QVuZTiAkes1AhVzs9wAVpBcd5jVXzGDIEXYzx5mABKqiFnEKNEo2QsTNKzREhGClGSMykR 5J3x7VkIt4qiXRuapKpVt3i2IU6Wkg72JKM5qEKUrpNa4UuwphXmIeXd1+Ldw+FWk/2ySJhXqKq 9+iteN5iGWAx7DOUvzOCOUfi8YeOsjAmG3W6i2qt1mDrZdBB8y2vtEx3i0XpzhM12IsHPs2WVTj CsfMHzt4Oly+7b87viWsyLFdFDWphCqKHUQ/QTNWoGkYSIPR9wo8mDlFVBbTEAhMFcyC3HvBASk 7jE+wxKW6q2lcY1vkfWhYOePlNW+hDEzQ8KRAG30to7FQsU1+cZjAOSBQxZg9kOlAaE5nUt8CbO OA= X-Received: by 2002:a2e:b88a:0:b0:38d:fae9:9aa2 with SMTP id 38308e7fff4ca-3a1323d6060mr18125041fa.1.1786963702959; Mon, 17 Aug 2026 03:48:22 -0700 (PDT) Received: from localhost.localdomain ([78.40.184.2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a16b0a1ee9sm3129031fa.8.2026.08.17.03.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:48:22 -0700 (PDT) From: Dmitriy Okunev To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , Sasha Levin , lvc-project@linuxtesting.org, Chris Mason , David Sterba , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6.1] btrfs: fix root leak if its reloc root is unexpected in merge_reloc_roots() Date: Mon, 17 Aug 2026 13:48:12 +0300 Message-ID: <20260817104812.9200-1-dokunevdmitriy@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Filipe Manana commit ce6050bafb4e33377dc17fcc357736bfc351180c upstream. If we have an unexpected reloc_root for our root, we jump to the out label but never drop the reference we obtained for root, resulting in a leak. Add a missing btrfs_put_root() call. Fixes: 24213fa46c70 ("btrfs: do proper error handling in merge_reloc_roots") Reviewed-by: Qu Wenruo Reviewed-by: Johannes Thumshirn Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Dmitriy Okunev --- fs/btrfs/relocation.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 43e8c331168e..d2a1323e8b10 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -1956,6 +1956,7 @@ void merge_reloc_roots(struct reloc_control *rc) * corruption, e.g. bad reloc tree key offset. */ ret = -EINVAL; + btrfs_put_root(root); goto out; } ret = merge_reloc_root(rc, root); -- 2.53.0