From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF4A3F7884 for ; Mon, 17 Aug 2026 10:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963874; cv=none; b=JSRnC/Qqik7K3AM0fodfG6vBoylxO+BU7MpoMbj5qsRsge2FtVLLTPucBnyUFyR7x5QneIeQb8Er6qHmoPLDPhb2uvDZlqhfSIRclzBWZG1zBLO9QA4cdqzevUAlCqX5dO/Atwf3G+jh0t7NnEiK3K1dYIPqTIObBusz5teVq98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963874; c=relaxed/simple; bh=BAn5LU6MLku5jBhqhHa0FryeFQwYXYxQ0wY3KCGAjkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hOfsuvZsIMydplnmeRU99IfSms+6sxPyrE5jEHR2tyU3GT3F7lgIOevg4qyPJFeMSwsgfu2+fMdjUM5Og/Xj74y/wJ+oXPxsaHK6dY/PZ/H7GUNbosfilfciDME1lYuTo2lM0Zz7HqknJ6X7W3Bx1K06cq2ZTKaYID+pOJ8M3/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LBg+rnCF; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LBg+rnCF" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84847482584so2260291b3a.0 for ; Mon, 17 Aug 2026 03:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963869; x=1787568669; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l9XMKIl2oRtZFF23IDv6EqgR/J/iayFYNbFKRvGQfiY=; b=LBg+rnCFotjEZFl3YUQci2l3PdAsVfgggEXmmKhvYziMzwsInypbzJ6nIGm8JxJaR1 Z+2T5njoTcw/BSfTCCxroO9BSBKqd9NBTmTsqoij3FlsJnYeJjyYn6Y0lfZM4jy9ehw7 B3nEuhm4tPZkAtDvgCgYaPUUJbkf+c4npmx7KcjIeelJ2HXyyMryNy9loAG7C8Up3v9+ VdjXuTqJqZIwTL6Igq5b1XOYV2S2ZXQWb7G0FgL8a/m9Bdmd89BCLrLJ/tVWNysSaG0X eseJ+02ENbODRyDJ++00YyRq6eHC31OyW7NnZnJHskTiHuN/IzM6OzjbNj2Adsed6ISO YxKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963869; x=1787568669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=l9XMKIl2oRtZFF23IDv6EqgR/J/iayFYNbFKRvGQfiY=; b=qyTRWHW2jRL50XURTWpeIFBnz/6LDiBrrKFAwu2L1v9KgibqTBDvp5tCMVHH4WSaYs Vb6omYrHyUE6POGOdtlrrhGCDyID21Ccgs5YkUw+ruXbogc45Q4kZ97DwMUlPGyVU8X1 p+cYm7O3fl3/zljqc6prSEVoHRrHDhJvkLvVxBUwkb8YFomJblzOzry1REkSqoQIIhxA A1nMOMAZmlwr56Af5ZEggug+8YOB6tRsM703jzGmJMQUcGTbc2CfNU0kbPfK3iDNex6I 1hu43nz+y1ocN/h8A/Makb9pf3VtRJ3X+p78Mgm5hRzQAXtAei0ndC2Trn9m4EaiJEQ7 NNmw== X-Forwarded-Encrypted: i=1; AHgh+RoGsEUZDqIK19Kal31I0vBLfS7BXjYl3/g0kdUI0k3jRromCHGAGRD12pG8cLGoZUl1wPkdeAM79AkmGqo=@vger.kernel.org X-Gm-Message-State: AOJu0YwQmCpKeDHEcBF4KKRbHA8U2k4s1y+Gj/jH/LKpVwoi1uxxsTn5 7utdaJmSgnRMQk1LJfT9p0hfEROsb8Aj+jxuZLiHpFJOTCA0pzz4qknj X-Gm-Gg: AR+sD13tf3uzxeDsmwlb3LtLELDxhkA+Pmh6SholLjizUHOJeq/PYzpxTF+5SH1TCxi VBkCsiMgmXW8GrLO4uHJKwbF2pBrMLB0lBSfcfZnF9VnX7yoUrBK3Ku+Y41Ci3lvOaxPTS9R+o9 whN8w+d6tDxV8qnc6LlCbzn6y4J4yRIWp3wfBnxyRChW5LttPW5xiSvDJ1KhLlT3Zj/jEMiBB73 4Kc5yYmVMd97dDzvXnGdhnD+pUe807poU9QvZAm768UbPaWrLNAYcWgGYsIupIsK+gR2cnz6qMj hMk/n1D30/6d91N1IRdR7mdE8UQe5Q+GHNih2BGPFm6Z3dPEOniiYmzymvBqmATQ8Cjcu+hpkA4 a7eVGDn7YBQrb9CSb442jixC+RjgNZvlla5nRKSjJuYlSPxEnYnI5GJQPd9Ysj7bT9++2sUybQU /BvwB/XvIW4+CEqNhPFW4JY33LapPU77U50jI6gyiYx0ecA79OCs3yqp4SASyRo7n3nv2Zph+By xxnOV98oDL0JH2WORy0k26CaEG7X4R9W0B0o601I2HoAgua5kJ2gfHzEXUYJEIQpoTlg6BA4BsS FXblClNInmktbno= X-Received: by 2002:a05:6a00:a20b:b0:84e:354:422b with SMTP id d2e1a72fcca58-84fdc60c8c9mr17055859b3a.2.1786963869434; Mon, 17 Aug 2026 03:51:09 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851b6f8b44esm78746b3a.33.2026.08.17.03.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:51:09 -0700 (PDT) From: phucduc.bui@gmail.com To: Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: bui duc phuc Subject: [PATCH 3/4] ipmi: bt-bmc: Request IRQ only when available Date: Mon, 17 Aug 2026 17:50:40 +0700 Message-ID: <20260817105041.63224-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260817105041.63224-1-phucduc.bui@gmail.com> References: <20260817105041.63224-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Only call devm_request_irq() when a valid positive IRQ number is available. Remove the redundant warning since devm_request_irq() already reports the error. There is also no need to store the error in bt_bmc->irq, as errors other than -ENXIO are returned to the caller instead of being handled as the no-IRQ case. Signed-off-by: bui duc phuc --- drivers/char/ipmi/bt-bmc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index 4c5457c88503..99b38300f9e1 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -383,12 +383,11 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc, if (bt_bmc->irq < 0 && bt_bmc->irq != -ENXIO) return bt_bmc->irq; - rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED, - DEVICE_NAME, bt_bmc); - if (rc < 0) { - dev_warn(dev, "Unable to request IRQ %d\n", bt_bmc->irq); - bt_bmc->irq = rc; - return rc; + if (bt_bmc->irq > 0) { + rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, + IRQF_SHARED, DEVICE_NAME, bt_bmc); + if (rc < 0) + return rc; } /* -- 2.43.0