From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881703F8ED3 for ; Mon, 17 Aug 2026 10:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963878; cv=none; b=VCaX/B6YXADSFfCb+3C8pk1GZWUwaro8XgY5EUNOU0nxmHlHJcbEjXn26Mo3MVkz9w87sntFHJK4Zbdfzet78iPQ1V905915XzwZ9rrIkfLq06EwSANeoJiZUHItZQ4x+dYFOtqbNRfw2j9UkYb8zrA9r0q95A1aOY5HE5QE5VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963878; c=relaxed/simple; bh=LA2S8DMunnI66f0qn4g5tkSSxoovyPmQ/4yJGe7cZzU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pZ322IR7JuPCDhcRrO5oLS6oXSruQJnDqv4bpxjdFyp6N4f93/zSoQe4k9n42ckhJSHE1dH0Qo64RcilocRYYX7sMBe7tLF0VAEaiCN1I6RydEpQ4mHW8XHHa41qQDv/45LbnUFaH0VA0ZBLGOG3XGUhiOkdO6MqaBxWUyr8Ckk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UqjrOh89; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UqjrOh89" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8485ef63b68so2404209b3a.1 for ; Mon, 17 Aug 2026 03:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963872; x=1787568672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rHDsGwX3LdjUsBgOkwqkiG/3g/apgaVEb5Rvk5yNqE8=; b=UqjrOh89AbeurPj8LQZ5OHDmeQ5KTL0vWU23lV9PdFlWNcpnSYVfcnjkwJQWmCPyar xWfrsYc3w9HAiaDXiO/Cab23YoM6NcS6WE7zeIgQcSw5TJUDpj7SPeaMuTRvm+1kGBcO 4yuZ1tBRucvAF/jjMtYYHBDNlRM2dXlBVC98IbZask1VSCMyzssbw0lhmhMqfKXV1Q67 7IhrZKl7I6wAlM80DVt/oJ0jIAbzj5zwnjN8jcIiT0pBNLQj4txYD8gpwgLnFC8UXWfM YnH61EiNQcwE2vkRbR5F4f+muF3ArfPmJBPmVB1xAGKRNMB6VY36hE4RB3zmpcMBK+zG sxrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963872; x=1787568672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rHDsGwX3LdjUsBgOkwqkiG/3g/apgaVEb5Rvk5yNqE8=; b=OW+6Ua7PLk+fKpKwN8kgZrXtKQNDd+/vlR9BTg7TyUU4ZMw4myigsUZNjUuRmUTWU0 52ZAXY1vN2FcGQ97uiwWPhH19Al9ioc+sYlUJN7E9a4iUSMRT/IuOoM3IdoSOefu5cci 5BDEo4SSVx2gF6Q6f6GGBWvzqeM4KzgYrdW85+SznRPR4ha+b4Dje/zrKorugg0CC2fd f/l9WQ1y02Fka+F8aKnyObjIgbydufOpmQ6grTsoY9ZbgEUMC43uK6RbjoxMqrhecAiq kivvvau14wP7HoFNL27qg0M9Bos97AWRt9tZAhCW0fijCqZgIoiy13Pf94ctA2WilTXJ EN0g== X-Forwarded-Encrypted: i=1; AHgh+Rr+jsg9Q7Uy144mHyO9trXgpL6Rn6DINlu+axPCiCI7WmH6kKwWvKK9osN0clKRH8IGZHEI9dcWoBOn3mk=@vger.kernel.org X-Gm-Message-State: AOJu0YxnqvUMwwJCNzxqKJ9yEZqkIRQHA5OcxpnIyyicdhQDgovTNgq4 ll8hchoO/vugkKuZdzYUQHqvgL9hIYO84a3BiZ4J0GTO5qqlF5DhTatlyDnE5g== X-Gm-Gg: AR+sD10raO8WNCJysW/8B/NOl3PYW8+ubfxKDAHQXjAES1wtnRlE3wvmg9kx8BFuL7C 7IqzCpjLYFDjcUCnieh4MwUiVdMOC1EhFNgmlISRcFPQ+SaCHVJijvVpX1A9ow94w3m9hvEsvhe +rHRIDeuyfXUsLKueaFymlbst30hvGMU9q7tyu0tXRnKttcaLI86TdRZcC3pdFWep7D9hwyop0h qU+3IZ22ki6VMDSCr3M+3sb7WMQBl/58Ui40hyzx7YP5YZMshcycBPyFVetEgkjgpYoulYLp9y/ 1VN+G61wtk0Lnsy4tI7LD0j/hPsKNBmMABBcRUy6lNkAYBnGHjJdqt9+f0ifSi+vq6/YKVjmjbR CkLtnzIsnhycpwIrYh42jaZLM4FSznZuIv0M46AhBKqYMvMULKKDCY6a6A4U7lPpljADlTnWmMI 0db7X9SE62vziszrMUlExPq/LLiPrQOLsF/fOrEUG0Z0CuiX8ELGTne5szimXlg64x5OhWlxVrP v0nfRYfYTyWcSdxPYN3uUPAMv8jrfoVGaph4PK79LHni6cgbB1CsUKZe3nyXebdT8/RXSrAvXYj ymYaFb6rMf2MZFYT X-Received: by 2002:aa7:930d:0:b0:845:363e:12d9 with SMTP id d2e1a72fcca58-84fddf87648mr26252642b3a.3.1786963871917; Mon, 17 Aug 2026 03:51:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851b6f8b44esm78746b3a.33.2026.08.17.03.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:51:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: bui duc phuc Subject: [PATCH 4/4] ipmi: bt-bmc: Check IRQ number correctly Date: Mon, 17 Aug 2026 17:50:41 +0700 Message-ID: <20260817105041.63224-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260817105041.63224-1-phucduc.bui@gmail.com> References: <20260817105041.63224-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc bt_bmc->irq does not have a value of zero, so check for a positive IRQ number when selecting between IRQ and timer-based handling. Signed-off-by: bui duc phuc --- drivers/char/ipmi/bt-bmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index 99b38300f9e1..68bf34715387 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -439,7 +439,7 @@ static int bt_bmc_probe(struct platform_device *pdev) if (rc) return rc; - if (bt_bmc->irq >= 0) { + if (bt_bmc->irq > 0) { dev_info(dev, "Using IRQ %d\n", bt_bmc->irq); } else { dev_info(dev, "No IRQ; using timer\n"); -- 2.43.0