From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345EA3F7895 for ; Mon, 17 Aug 2026 10:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963985; cv=none; b=PUcSvUFGetq3PBhgqvdy9NJ1uYkgtmpkcMWDkXK/V/ZcGXeHBk8FSl0r+rlAWEP+IDXE6jNXKH/Poa/JX27YkN6FtF5VxsPY9BMG0Oxhr7q7yrgoGmNaFUcE6Ej45LwYrL3cliEfk4Cvz52Q887ed/dJCG8to/MMMg3OyETx2Ig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963985; c=relaxed/simple; bh=jt9f/5Bg5HKdcUg0UDYwKyDopsaUzHywIYt+q+N3dcY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IY8WllSqOtoFgOzKfY8XMxlaVsv1weGuI2aifhpoKaJEKnKP+L5y/J1njY3dfRj8eN6UT9rSp7dBSo40qwNB1s96e5yINXVDvdVvnF3fvg0jGrpCXBrHZhjGO0gyzUtQc6DTHpqbRICJppAUh1/yHlxk5ABmk1+PI5zFdN2urmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kvCcoWrL; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvCcoWrL" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8518b3ff3e9so1537647b3a.2 for ; Mon, 17 Aug 2026 03:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963981; x=1787568781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w/B8tIPegnY1ix5z2/emLnUMnM5hsvaByPeUzupMv/Y=; b=kvCcoWrLKFzOrFzh8Nh4lVeBQtVFYZiMgW1kHtfpCaZuulVHNvw+uYW3iISoSgCbXj HNNqjZuiwbLrvQrQHq5v9HOUaiuSOGhwQnazUG70sGKaGOt5mQIamoL8idcfsg0l2TAZ rtDBERJKKfe07CcjapoGWuotbaWYfWS4zXgaPeX3R0s9XRLLWf6ifk85CScjjDosAUDw 72FpUty0PkerS5dDO6xt/q5NYIn/RUzaGttj12UM1nZb1g3oYQLC8wbGH1A+Ez/rYePs XLMYMCuIWtb0wSG+musAlSZgFZ26UD6Z5w9V1sEnGZKr946UNpcuWyvyV11VFAfbVfVW waXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963981; x=1787568781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=w/B8tIPegnY1ix5z2/emLnUMnM5hsvaByPeUzupMv/Y=; b=mU61ESeltJgeSPKk3O8aSi9Iv66OjatFgevIV6ngyD3Fs3+fZ8X74sHNapNzYdOmnv 9bQ28lvQ9+Zh0ST5nTelB2VP5m2KFx14GJwUiYgtTI/lrnNp+Csi0gaQlPr8mgAgUICz KTn2HDDxFZuQbkW7SwhqyZHlhf0MrMqz1Db0hYfRVcPb86Etw56Yf+TOJBgOR/24t3eS 8iNeT24htK3e6cr0jFN+y02yYmqzKJq2NgurGxBkL0n9a32/K7lGZAUpJ0kQhX4ziyhC qDODkeLbrUPByuheLMQeAfap7SGPI3/sC7MkYKqhE7lVOowaNaC1UKo1xKAaczjBxp+C NNWQ== X-Forwarded-Encrypted: i=1; AHgh+RouCdqkhc8KDra4sc9djbrM7BbPSpkQ+lB1IN9B9O/y6wA73IbU25G0jZy4x/+t+X6MQAbJNlMap69mTXk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk7pYnOGVeR/lpRccMFA61QxM2DrM0tDlnQ17cSGRvE1U5JBr+ mftt356arUXMxz1G2Di1m7pvZZQnzEbXsEEddjnxFtbINRVnPrB/6kG5 X-Gm-Gg: AR+sD10zrsHrfuHmBfd9wuRgxehn69aRQ54ip1FhcdZLr+JlEebYYGiaBYkCfPjSt9E 9Skpww/DQDicj+15gnfj4wDCmkbAaHt6ZiPfmM5lh7OwTP+y82lnxCcIsCv+241PCyAEWKc6hC6 UbxMJ5akymWHErnJzllSlzhdnteFrGiW0L1aNCvJwmhJByjp54oYLpdqqCUeLraI0PbrJTmSece J87+kp8jMhahNcjJ4fcyTLOEoALYkVn/OZoCRo9g3li5J8ExdkFOYD9gca7/lIWI7fqXbjsQMBJ TR5N9V6l2BScCOVdyrm1k6hU9C1WlkYEamuhjJIrYugvc75uqEYL92da8ywDL86rvEghbFZPvlS idQHqjOc6lb/1ZgwljGw2n6vNz2CFdUl7zNivfsEYhCFf5sbD2I8rby6TmxPooPlSWmQBc9eKeQ CdoJmYHuWlWbbXpnUxf/LcujMm8EH7BlgXmpT1B6EgJKY2eLWeS3c0x0Z4gYHTDvdQos8CY2hPz WZX5so/ubaiiBQbbAJX1CMBR/XhuMtHQHG19UaSCBLi5fJRHP9TQA1JTG1R0L1l8BQfiiXJofBn ju2vSw2DLw== X-Received: by 2002:a05:6a00:32c3:b0:848:5cf5:5040 with SMTP id d2e1a72fcca58-84fde1564c3mr23741397b3a.10.1786963980764; Mon, 17 Aug 2026 03:53:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851b401ec98sm354846b3a.6.2026.08.17.03.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:53:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly Date: Mon, 17 Aug 2026 17:52:40 +0700 Message-ID: <20260817105241.63345-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260817105241.63345-1-phucduc.bui@gmail.com> References: <20260817105241.63345-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc lp->eth_irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Errors other than -ENXIO are handled before this check, so -ENXIO is the only error value that can reach this point. Check for a negative value instead of treating 0 as an undefined IRQ. Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index f92951422b2e..50f88a38b6f6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -3049,7 +3049,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops = &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <= 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); /* Retrieve the MAC address */ -- 2.43.0