From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B7942F71D for ; Mon, 17 Aug 2026 13:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786972862; cv=none; b=nSS6wmwxY6bLSsfoM+D7wOM6ON2ns2PlC36tF1yEIuJG39REy46YwDhdCT4Il6z116lBaSyUCMewaAS+oTsz9t2rRdTn9vVh9UdK3tzrPVmIufC3YWQtomj8UeCKofpIpaklM7Jqxg5IjJuULvLCH7oyPfoOak4P1XaJ7C6/kcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786972862; c=relaxed/simple; bh=A0dpgGGaD7E+JzMUKW9jgv+RskM6OI+ISp/f2JOuZkE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O5lyaiLmyPWCPLJC9dDj9gLsKJtP4WwzWng6ximGUjoxMOeQ/VHkFxhff1M7sU4fF+ayESEnVwPId07QzI88HG4H3XszZt4v/BwTdBxaX32KHpXSUJrMLR9qD7iKFmfyer6hJWRx87dhdHFrCH+3sEk5GxtC1rSbEmkGPS2EW5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T8L00sIg; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T8L00sIg" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38e347638adso4104724a91.0 for ; Mon, 17 Aug 2026 06:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786972861; x=1787577661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=B1Uc7wojMG+g3MAFF5Q5D3MBvJR0GI+20kec6C9vh0Y=; b=T8L00sIgza12CdK8P0kqxcqwpIXD7WDDQCR+yXvUEhurVDNcllwjUwygHVYxHs+ZJ5 M06k/NHJ/CBqrrMXdt6IPyYNchPeOmd9JP9RVr9a4y/R4GO2GnuyLFM9PnFr8Hb7/Uky IMc2xXD5cv+60M/LJ2Dqrl/ese2/13NNf70iE5zn6TQhMwR+oG/WoFIwEOm2IBHtIwXz j6q8OyBz64JWiMcp4MEhvoVIU0FyHGso0wZsba8HBVt33BFGy06/yQo44i9LqdIUotuN 6pkDEG2QSSwLPP0fqx1b7Af6yWmWPPEgsD7JrTiNm3/1bp6jvW0+pdzl5NkkGRGAA7eU VnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786972861; x=1787577661; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B1Uc7wojMG+g3MAFF5Q5D3MBvJR0GI+20kec6C9vh0Y=; b=q8QSLu3uWZpvbIoofnApg6Em1/RBif+ASOHyMAztPsREvBtI/UPKZbqz1VHOpWQOBz f/vK0HRh+UzfG9eioRAREf0SPSkUgWuDL/glQ/9F7aWVHBxPjSLmlRf08UoUrZfB0Q3H yGuaifJNNo7ELY06I+6PRFyxTPeXr0Fwba4c44iLBYEv9KWnTYFQZtui530XWH1MT14G R8bBWQt73NNrhMx8BpX+7SU5lU7vBWFu3d7TbeaEFZQRrAeh4w2wPZ6/t6Vxfd1hxrd+ BPFoxoOphC/Ry/N964CEjQ0Tev34weYnQXy1XRSXopxwsz38iyjB+9yIIfgQX7KKWqOT 6Vgw== X-Forwarded-Encrypted: i=1; AHgh+RoF7ZrM9cC/wulpXzp9ne6PT7lNhkD+aDXawJyBjY8sSsAwCvkcoV33La9RQdR92zjYlXJ12XqyImdz+qw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2BFfHpXmUBZvLN6V0tV4h2w6r61hmIQIsq86kmX9yO8egm1HG x8+EaqErYPOELegMwHM9F2PSbeJ9g+18AjyRWVMAIjvIMYMZqNOQl5LX X-Gm-Gg: AR+sD12LdtKAI4xG3Ymq9fKL7IdkFeFcmyJ0ts67lV8G55XT1KyiaYv/zXx9OksIe2k DmTTrJySyldKKpTTpavh8CnZFiRd6Hjyk0GdHdy/9DhcClaG1fWTvIQdAAgkjKFI2ytktAWLhtp 4KNqsU1v0NPRIpYqoe5R5EZFWkaZEWPVgZTFl9RE34GV+m1DyyjwHX4hdesiXfl0eh1sc7fWZFQ hrKmnopawVp/+EJWmuiiHgM66h4/Y0P7mnDAYIZ1TPJFjb7EG3nCt0nxld29ND906PrMh5MsjgW sc6Q86PUHA1SJzgChCRuQd+8NCjxJYwAsjoIQdDTjY6DWgvnu2Y620W7LfjkEq9Abj9ho/fFVVC ljZZPbEuFNbfPLj7lv04KuIZNwL9V2lgsllNy6kZN9dLu6H7V9FbHI5lqzzZUxOrdJ1WDhFJBRa oMee9RL/1YrEimwEZN0cZck4NAKRc6tdOQNJACpMIxvbt/7bw16+yoKNANFHVJ9/t/jvqHu7BrB uw8AxfAvIM95Brt/BtM1+D9YbcUUw== X-Received: by 2002:a17:90b:5805:b0:380:105f:8ffd with SMTP id 98e67ed59e1d1-3933b90d562mr25889790a91.16.1786972860581; Mon, 17 Aug 2026 06:21:00 -0700 (PDT) Received: from gmail.com ([138.199.21.251]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3933b68adefsm4891951a91.3.2026.08.17.06.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:21:00 -0700 (PDT) From: ZhengYuan Huang To: clm@fb.com, dsterba@suse.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, r33s3n6@gmail.com, zzzccc427@gmail.com, tom442288@tuta.io, ZhengYuan Huang Subject: [PATCH] btrfs: send: reject extents for non-regular inodes Date: Mon, 17 Aug 2026 21:20:51 +0800 Message-ID: <20260817132051.267646-1-gality369@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [BUG] A corrupted subvolume tree can leave an EXTENT_DATA item attached to an inode whose mode is not S_IFREG or S_IFLNK. During send, such an item can be treated as file data and crash through a NULL address_space operation: BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor instruction fetch in kernel mode #PF: error_code(0x0010) - not-present page Call Trace: read_pages+0x80b/0xb30 mm/readahead.c:173 page_cache_ra_unbounded+0x40d/0x890 mm/readahead.c:302 do_page_cache_ra mm/readahead.c:332 [inline] page_cache_ra_order+0xa16/0xcd0 mm/readahead.c:535 page_cache_sync_ra+0x5ce/0x9d0 mm/readahead.c:626 page_cache_sync_readahead include/linux/pagemap.h:1379 [inline] put_file_data fs/btrfs/send.c:5224 [inline] send_write fs/btrfs/send.c:5291 [inline] send_extent_data+0x16b2/0x29b0 fs/btrfs/send.c:5715 send_write_or_clone fs/btrfs/send.c:6135 [inline] process_extent+0x5d4/0x17b0 fs/btrfs/send.c:6504 changed_extent fs/btrfs/send.c:7079 [inline] changed_cb+0x22f9/0x3cd0 fs/btrfs/send.c:7245 full_send_tree fs/btrfs/send.c:7318 [inline] send_subvol fs/btrfs/send.c:7910 [inline] btrfs_ioctl_send+0x46a9/0x57f0 fs/btrfs/send.c:8248 ... [CAUSE] process_extent() skips extent items for symlinks but assumes every other inode with an extent item is a regular file. For a corrupted non-regular inode, btrfs_iget() does not install the regular file address_space operations. The readahead fallback can then call a NULL read_folio callback before the existing validation in btrfs_get_extent() can run. [FIX] Reject extent items for inode types other than regular files and symlinks at the common send extent-processing boundary. Symlink handling is left unchanged because send emits symlink data from read_symlink(). This covers full, incremental and new-generation sends without adding a check to the regular I/O path. Signed-off-by: ZhengYuan Huang --- fs/btrfs/send.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index dca3570168c7..f88623bbc491 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -6417,6 +6417,13 @@ static int process_extent(struct send_ctx *sctx, if (S_ISLNK(sctx->cur_inode_mode)) return 0; + if (unlikely(!S_ISREG(sctx->cur_inode_mode))) { + btrfs_crit(sctx->send_root->fs_info, + "send: extent for non-regular inode %llu root %llu mode 0%llo", + key->objectid, btrfs_root_id(sctx->send_root), + sctx->cur_inode_mode & S_IFMT); + return -EUCLEAN; + } if (sctx->parent_root && !sctx->cur_inode_new) { ret = is_extent_unchanged(sctx, path, key); -- 2.43.0