From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-32.mta1.migadu.com [95.215.58.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B5343DB636 for ; Mon, 17 Aug 2026 14:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975846; cv=none; b=EwiXkbkeGJpauXkpM78gvd//jrPwW4oyUgKhmrtFk3ki9GOM4Lo9LXgH+CZhIolFg7DUcEl1sDMq69hRSU7rTDWpJitTI4Ze9ROoaPDT2k7Hb7dl/BLM3jP6sG3+VBnnl8sN0buy+/2HrnQhRcltZc3fFmHIHAXI69sJY3i1Ttg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975846; c=relaxed/simple; bh=WC6FwVcdTcvnbXOAaaKr7EIZTaS1+kvj6D3uYnj1BAQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lcgqnG3gMu4gQwVc1BRqP9AoSZrj7xXrMHBMgVUIN3jS0FaDDBIVuYHVaGrPgZDdHTgv3FzSUnHIHml76ROQV0WIRzipYHfaF7+zXMGU84luIWc2AhawW/AGCWzLQDxLfnS67Hc3SVx5U+3UyCAcNsOfnKy/z5lo84jyd6WB6NM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ToohYk4s; arc=none smtp.client-ip=95.215.58.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ToohYk4s" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=WC6FwVcdTcvnbXOAaaKr7EIZTaS1+kvj6D3uYnj1BAQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786975842; v=1; x=1787580642; b=ToohYk4sriY6krV6MFI6ywbpwPF2I4rI7VjTx+7qSpHSg6DokWxX5UK+Zy6Gvx8RJA1Z5aUd JJzlB14ilBnqQADl3d/5+othNioyOdO1IdesKw9mENhjsuhuTGxEahe/9pE50cyVjC23LrI4e2j PZM+h+piu2uzXrSHOIz5Z4pI= X-Envelope-To: linux-kernel@vger.kernel.org Received: from ctao-book.. (223.70.160.239) by smtp.migadu.com with ESMTPS id 839f979253890219; Mon, 17 Aug 2026 14:10:42 +0000 X-Migadu-Flow: FLOW_OUT From: Tao Cui To: josef@toxicpanda.com, axboe@kernel.dk, hch@lst.de, yukuai@kernel.org, linux-block@vger.kernel.org Cc: nbd@other.debian.org, linux-kernel@vger.kernel.org, mchristi@redhat.com, cui.tao@linux.dev, Tao Cui Subject: [PATCH] nbd: clamp the timeout before converting it to jiffies Date: Mon, 17 Aug 2026 22:10:27 +0800 Message-ID: <20260817141027.48423-1-cui.tao@linux.dev> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tao Cui nbd_set_cmd_timeout() stores timeout * HZ into tag_set.timeout, an unsigned int, and passes the same product to blk_queue_rq_timeout() without any range check. A large timeout (2^32 seconds, say) truncates to 0 instead of being a very long timeout. Clamp the timeout to UINT_MAX / HZ seconds first. Setting NBD_SET_TIMEOUT to 2^32 left the debugfs timeout at 0 before this change and at 4294967000 after it. Fixes: 55313e92bd17 ("nbd: add set cmd timeout helper") Signed-off-by: Tao Cui --- drivers/block/nbd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 8f10762e90ef..1874c1a81d3a 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1619,6 +1619,10 @@ static void nbd_clear_sock_ioctl(struct nbd_device *nbd) static void nbd_set_cmd_timeout(struct nbd_device *nbd, u64 timeout) { + /* clamp so that timeout * HZ fits in an unsigned int */ + if (timeout > UINT_MAX / HZ) + timeout = UINT_MAX / HZ; + nbd->tag_set.timeout = timeout * HZ; if (timeout) blk_queue_rq_timeout(nbd->disk->queue, timeout * HZ); -- 2.43.0