From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585EE411FB2 for ; Mon, 17 Aug 2026 14:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976920; cv=none; b=ckJPDXl+DjBCJEgDNcR85QS3bq/0A/0xWtMCuM3dQ1zSfiPvwZs9yGZpV4uGb6k47LDWhQX8aUpPT8nGVl+G1ZxInYwVhSx3H2Nyc6f2KAymc78iR/bsVPoyWGJVm8i+ZURu/kgYzQaLkyq/x/yIDrz44VFfJ0np8Ynk0EPibm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976920; c=relaxed/simple; bh=3oVrYXUDxgNzhkzRS1/OITSVj6SVkZFOoGxcQjQGliw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mp9kienAUXtOMGOHgmLxZtZ0w0/RKeBrU46AM/hs4Dly00bjC2hKskzoYV9hmt9GJ4p/KGR1l5Qkhdn35givQ1vE5nlUUATvK21mTfw/GfGrK4IoHGwxJMwSorTEUSOkJVd1+Bk8jO9Bl0BnyuwbGiz39tKlpGDIFDlvLgEvmAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KsqRdafD; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KsqRdafD" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ceaf8a1265so52449395ad.2 for ; Mon, 17 Aug 2026 07:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786976918; x=1787581718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gX78QWNbvx2h9UqqkHHgrawmRxaPgnwHP8OEVorhQLo=; b=KsqRdafDdef/Hevrr4ASasxXCkzvX6NQbnWt6vfZc5cFXWZqA9kk9TT5Yz8Z1qb673 EGuCY7IS/rEd2rwpsTHLvACLwufY37pfyunvljiENdsuyoIFbImCnN8qsTdpyEUN8AW3 jyHYVdkU1yibo/2x+F86EHObNrxp7AYj0TUKrWbt+54I7Z2Ja+GVZwlu5JT4zr0k4QSC Z8F1lk0bWK8anq5Zdf1ksZkwwQrfuX7Y/naGdDH8j/hgejvmGZfGkUCKzfVywhRAK64x u8cz7bVsk1FyyNJYtt+yiLWaA0g/W30CJlhyEs1v06StRHe184GuCNMa7XdT7y2vxrG+ LOXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786976918; x=1787581718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gX78QWNbvx2h9UqqkHHgrawmRxaPgnwHP8OEVorhQLo=; b=bRhFC6oVI59fDXGjB6FtWPqEjJSwg4s1uzoWmc4WVxO8x7zJvYV0mZD59tMxsz+2x6 a+cvnW5erkCi4IIIO7x2HfBZymqFh3j6WsRnlz3KZT3wBc2Ygy+lAxghZKckBo3OKmyB i9sGSuafxsJJpuvaeyNP+4/ExHA1nNYZqQe+VNXsuoPvRIQml4ndewwgGxXweX73Cy40 Y9S3HpzXUohPCg9TvC0dicBGLPZnpTFLhPgcY40ejI1yq+jWR7OC2paGh4EkfZP71DSM Ope+vqtUPkKe7ycUVp+SixL/JWjLMCvkxCjyEHfcvTgMatwrDevVsW7JVPWbRiTZZdwZ EmQA== X-Forwarded-Encrypted: i=1; AHgh+Rrp01WTYoC7yuOv2vvZ1zo8ewEmgDK/ryB4fDX9V365b1LH+T4Ytp0yP22e+WjTQoorS5AeStzeLdTcfYo=@vger.kernel.org X-Gm-Message-State: AOJu0YzKbiQwzc+c919y5v1GuJe1meurGrkJC10E/eQRFtEWAV5MJ/JG /ylTpKSEa0qve2tpQ+dav83YP84f/sg9S661cdfbnyBzW4DP79Fapkw= X-Gm-Gg: AR+sD13zOwZW78jRlJlrZd1dtq8S7U3I4qXAZaaG4K1FHLrunC6Fj31/I98RSo6Ib26 rQeE85ar1eMIZZ56ngZjXGlb0r9LIZ6JdPlLrSQdTXQe/3v6w1vHVK4eLgYdm7XygeWHYe7KSAd zA96W9sRAUPSWPOmgDnQ46DMbZzSX1NSxpNLxyU7zmqU1HkEcKYOZ9ez+CKNNkGsmz9gKcE45+O tEAfEJa3grbqr68MOrNrxgzC4lVnI5qby/zayJe01pOJqYMlPbCWaqXkriOP7KJ9YLCjFj5CIDF h0D0x4dArgYK+dlKUEtNtZhd3U11AZxEpP7ClcwC4rTPxeyIf28NbHr64P7Xu+v+JrBegvo8FP1 HYjQ20Dq0wWLmNW5jOwhQDkQFA2pHWvEPWNEJy/2hpFxXjE9l8wRUaSxQCIf9DwPfLzOB+tQndj uHcwOGtu1TrMPNoMOtZtasNYtcRqIt7Pyu4JqbbJEEC1WU9GvHotnwemhB2nKigDdbLIHc0ZRzU 4t/mm+drYFabrubUZR4my+X/RXeAnfpSX6JzRrTB+KGfPDmW0yonUBK+Rs7L2F1m10DTPlwUQ== X-Received: by 2002:a17:903:3c48:b0:2cf:ba10:6d6 with SMTP id d9443c01a7336-2d5c4f07dfcmr8469195ad.4.1786976918586; Mon, 17 Aug 2026 07:28:38 -0700 (PDT) Received: from codespaces-2db70c.m2fxbej512jepnsor2itp05j3d.ix.internal.cloudapp.net ([207.46.224.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1e528b3sm3807245ad.46.2026.08.17.07.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 07:28:38 -0700 (PDT) From: Triet Hoang X-Google-Original-From: Triet Hoang <89897892+HMTCT@users.noreply.github.com> To: royalnet026@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ogabbay@kernel.org, tomeu@tomeuvizoso.net, triet.hoang.dev@gmail.com Subject: Re: [PATCH v2] drm/rocket: Check allocations before use Date: Mon, 17 Aug 2026 14:28:21 +0000 Message-ID: <20260817142821.161070-1-89897892+HMTCT@users.noreply.github.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260817093009.22359-1-royalnet026@gmail.com> References: <20260817093009.22359-1-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Igor, After reading the code carefully, I think that we can check if entity->sched_list is NULL or not, then we can free the array that rocket_job_open() allocated. This will look like if (WARN_ON(ret) || !(&rocket_priv->sched_entity->sched_list)) kfree(scheds); How do you think about that Best Regards, Triet