From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D1A0175A74 for ; Mon, 17 Aug 2026 14:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976129; cv=none; b=QB2FTwGkvo4MVLM3Gn/aTQ7LQlwKAu58pHNomzc4NYZEZM7/+bgrsyzFTBgFw2kbZayHy/cG5Rbqg4Wy562cuOfE0E8UoB+/+w6wNSqtTdfjgv/xWHGp2SfdtwoKS9UYjfhMlvGMrxoFw/ZudX7eZcKpKkJrivEGVMV+A/hwSVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976129; c=relaxed/simple; bh=khoQ7L9VZjC/PNAUQ/Sjr9kIhxNa5Xx3U1PPkaqU5dI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IypZFJjQ19yJLyTt3PKBij/4fu/Y63ZY14NuU2T/lG9qJI5WQhCK19zjxpfBguijVMEtKvsmdtc9wdV2uFIV70HabWFMayy/xdxdIsem6L4Qz73uvjVe6Mz5ZN+icehaZoITwR/jAi5iv7SZdqcjWf9uHaN61iaAtCU2j8o/YZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lXL2jyjE; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lXL2jyjE" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso1587254f8f.0 for ; Mon, 17 Aug 2026 07:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786976126; x=1787580926; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HJlP1AbCvj0GlzVokRh2GsjzM05mavP3fcHYeATpGMs=; b=lXL2jyjEz7DolLF3VX+MA77BoqYm8LxveqPT4NvgxJXT2rHCzh/WfXIhnDvo1E5AcI 0P7H+Z3EnpDD+n9K1aK7p8xzmIIXQAXH44urE0MG8teME1Gv8TNniIRHQ1OIzLUQ10WK d1yIiuuwZbIrxzTxLeoyOl9d8+ahEmr2d8By+uQGEf9Zkv07q4dqxZd3bItcDB0vmCo0 9pQbvKq4/9zNsjS0Ta7L3yPMuN39Wtd8UeejkEJLC3lnm4yVAgkukpaMdJAIQV+NShgY YEKiy6yT0jCZOnJut7AsUqjFGC6BDDI55nGwKt1jdR3UKrGKs3q/gk/oBFg68vHg/AXN 4pxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786976126; x=1787580926; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HJlP1AbCvj0GlzVokRh2GsjzM05mavP3fcHYeATpGMs=; b=A8KqIkwIHKCm4w4JLWT+DGMjv+mxxNYpJtI9uUxNeUMLSBulM65//7x/Lzg70G+34y 2TyB57qF5C50/cg3MgmfuxLPtHZ4r+s0dhVSbkbbGVjyb1ZQoN+/BcjgP8Sv28qlzvPD tk+/LlsxcVp6No/aidkA024UYzSYb7xd4+tytCfjmoacgI/OocPBI8T3dgOlI1c2NdrC HrU/1onz6NoHlr8dfK0xXlknHlX6oofY4IPE9/t9A9h/X2xpsAxOCEI7UJG7nZrh8BCs QnMHQMipdeX6AsgBEzk7q9i3lhp+B5E4gV/pAiw8sxoMhoXwbHt/5BLKXvdhs/VntzCf xOEg== X-Forwarded-Encrypted: i=1; AHgh+RosiA01hxIguG3aW4K0bvTzqQDt5WHtWKeSREgdxc3dCoVskDX5h+PwAw0P76JImRoR16+Qb53hMV6TBBI=@vger.kernel.org X-Gm-Message-State: AOJu0YxqReOvgjChJAfXsjpxbNprc9+7/seKYj7YkSCEfWKSDtt3BoRi oXq4K9B/5GdwBDsTHcr+ym416o6PN8VXvy3kP9u2WdKwCjPoSVXdJlmf X-Gm-Gg: AR+sD13lAp3exxrS8HL8PyqV8hR5o+HMFfwpy+S4r5rs6ZJNFkGWyNj5ipYGC+FWrpp TJnPUUzwNW1cIEyHRL5RTiIzGz7nJp6u5J5PGojOGnSyK9lBdQhnf7USEFPn94l7QMrE52ob1Jc 150eCmE8m542yFNfJwLhGnSMgYERIG6I4li21nRneXaMILwRk1z7G5SyW+rUztERE6vgiMzSANh kf7ExodIKOTPPMMtfD19ITq96UZSeZ/PCgMlZDs2icaqBI6oI26ONs5gJYkqslwiOfNnpSG3CI6 tvM3n4SHKIB4yOJ+DG+WSlztxKZxCNOp8K2yWUhfpgTCPOEMxbvyuTnJ7CrBEfjK3mZFC+1GgHR +FZaR7pDAfjeXwsp0AFlSsRyC7wzif6A5PdAyin4m4R010EKseHfQ0piqxvIVP6KxlrjKbdWoNA RSjid3h6oMfIYRYrb+5kWZzoh6gzJKqCX9wSsmh7pS6iWAjmZDu5Z/wijn4ic4CW8fYutlhX8tB 6TSmyGD8Z0Bj3duB0UmejkB8JJgynGk/4FtPyskkhA7riC9+5z3nVQL4Ks6kuv3zYrNIJef0+JF zRpMyEMow/jDomQy3Fex1TqW2EzWc7ajx7RX/f34NW9lABNAnav2SLqQ7n+NcqisjH+1mYrhOwy cyc8a2XVRlpdMHWE8d30i4BL2cta/DsJX0UuG9CZh3Vczskx6IhZYRbDaQp/r7IV3Pemcfw== X-Received: by 2002:a5d:52c3:0:b0:47d:fc23:abe8 with SMTP id ffacd0b85a97d-482a90919dbmr622111f8f.28.1786976126114; Mon, 17 Aug 2026 07:15:26 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a315bfsm4566475f8f.1.2026.08.17.07.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 07:15:25 -0700 (PDT) Date: Mon, 17 Aug 2026 16:15:23 +0200 From: Joshua Crofts To: Marco Chen Cc: dan@dlrobertson.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, jagathjog1996@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev Subject: Re: [PATCH v1] iio: accel: bma400: remove completed tasks from TODO list Message-ID: <20260817161523.00001feb@gmail.com> In-Reply-To: <20260813150103.56350-1-marcochen.dev@gmail.com> References: <20260813150103.56350-1-marcochen.dev@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Aug 2026 11:01:03 -0400 Marco Chen wrote: > Two of the four tasks in the TODO comment have been implemented. > > Interrupts were added by commit ffe0ab6a9698 ("iio: accel: > bma400: Add triggered buffer support"). Support for events was added by > commit 961db2da159d ("iio: accel: bma400: Add support for single and > double tap events"), among others. The driver now has an interrupt > handler pushing IIO events, and event configuration from > read_event_config(), write_event_config(), read_event_value(), and > write_event_value(). > > A step count channel was also added by commit d221de60eee3 ("iio: accel: > bma400: Add separate channel for step counter"). > > The power management and sensor time channel TODOs remain unimplemented. > > Signed-off-by: Marco Chen > --- > I would like to take on the remaining power management TODO. The driver > has bma400_set_power_mode() but neither bus assigns a dev_pm_ops > struct. POWER_MODE_LOW is also never entered. I don't have a BMA400 but > I would definitely buy one to develop and test on. I also have access to > a logic analyzer for testing. Is this a patch that is desirable? Strange that these weren't removed in the commits that introduce said changes... Anyhow, not sure if this patch on its own is too much churn, Jonathan and the other usually prefer these to go in a series of more changes (i.e. if you do the power management TODO, you send this patch in the series). This is up to Jonathan however. -- Kind regards, Joshua Crofts