From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435D13B42CD for ; Mon, 17 Aug 2026 19:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786993607; cv=none; b=XXdTewGsKvoZz56XQaiRRRMwErn5/cYbE7aJWtiOZT7PMWuAeGCOFX5flRfrfZeYOIJsvcZlqXMx7WPBmmM0yblmBeu4g8OZ03enZIO5PLuFYFzhxy1/jTl3OdzxOT0aCCsYrx8TgHXvXLucvqAkdAI3/hUgIConzgQ9vJ73Iqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786993607; c=relaxed/simple; bh=3nRo7RCqStvNEAOIQp2UeWfHaLeH1ercxWZHFU2gguE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MTjW1uyo64BuBO7yJQajn4QV9X9pPoST0MDTDWdI8dNMOXviWBOYAPyETNh1MQTPNDQ/YiQkGc7J54bDPX8pv+xgylB43WvULxmaAp1UcBLZ9pswQEtI5LJ++KfDFmiVOKLZdXCKl1NgZ8FFCyOHyuyBUhu5FLRv/w/ydo7nGCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R7KNWOS6; arc=none smtp.client-ip=209.85.217.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R7KNWOS6" Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-74ad03fa605so2036163137.0 for ; Mon, 17 Aug 2026 12:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786993605; x=1787598405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B9dTOo0MFnPB4wb36inApTj6u4wQTMkBScOyOkAf85w=; b=R7KNWOS6mT/GE43PNi1f/NEm3xgxRNo6mujF69CTsXBH/X63dersS+2w/1MP9qobYF dT4pgqIrKkSIV+rRi9bwMnrH07YeiybG3afndsuNOFu16GlPpXABo+ibDq0PLiUGzgzP JuIwlZE0N5VauZkYzbbVHWTPsftxElPBoNFw/wBFemN8IiEqcQJkM2OyJ0TCjH8nfRvl X+fMN/N2NrD4+6/Q04onGehaN0d3PQjM2ZA0hZK0QUz1M5juSfTt8q12tEpnen/M1i5G QSsU31wXEqJTa9mq8kl57M0MTFjrggSxUNB6uHe1R6ttV6rU2L5JUHypPv9qdcnFBNjY nykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786993605; x=1787598405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B9dTOo0MFnPB4wb36inApTj6u4wQTMkBScOyOkAf85w=; b=gBo+IB3r4N6Q1jcnyKRyRa9KWUgyCBsOGr3TOTnYJgcJWU13YubnYFqLI2EW/NQSIt +ueQYSKZJfrlZuubafITarJxOTKaWjXVLdQwhVat8IaFhU2kxYxAZzWO0EVtoBggkVFU Ka7aqEIdIBpZEcX2fIpnmY+ZcSAxkhJAlgb3Ql5EmCuSfTH9F1RfkHc5bpX+O9Cxc4Wi lZa8rzNfwq/K8D96Esi0HTYeYaCAh+cQNt7eNePhwqAByC2udGtQiUaZQC9X344ZjD4S VLeB4iklz4uUCH+YJ/BDPqpv7exXWghBZXCGxneICAUTjiuwATCyn8mLhnuIMVD79250 8WRw== X-Forwarded-Encrypted: i=1; AHgh+RpsAIB1FO0FB4IqMD1VbdvQtkR7cDQT9q1x0RaUH6eoFPHtmd3LxAbgjv1B5Ajxyuu/76uuA0ekreOl7gQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyppOGvfXAu+zBDxwU3gXWTDs5IJEIBtG5UyRC5aZoyG6ndMJFY AgR95eo2oWDkwW2cM+yV2jFdycqxQP+Sw1LMErWuYzyqZ48kyrcM3li3 X-Gm-Gg: AR+sD13KWnCK/m7pu8i56DifnRbuV3QGac8Uwi9DvM9kmFaFV2GvmTDwxeV6JCGdOcC JLDNzIE2p4mj8iDTSLLB2/+GrqnsapMkORB4Gi4f1CbeiEZXyayChSQ3Q2tSQBVKncR3kVdO6RR gwwWHpk0cnz2Y+8f9WxGIPNIntUiukFGKozrbYWQ/r2IKrLMFAe2ijtLpu1V3EIsSJS/zibWQ0a a97KvtjM3/iRJ0ULQwTwP+tv/yLL3oGN0eJpDw1PtApU21IB+7FMe0PlTCbX1nuYJ1lxpg+yCGE C7FSpsM4MD4m4V3dtunwVlKnyzq1cf5hQKHnnPrwaBIq5x518jmZKCkw1GYKRDG7YlE2dSZlnqK AW8Q90EgMEElJs9XD1HP3FdE+TIdEHoQP3dlx+FGbONZuOHEWsz7pTWxZNUWveZE+pvcGPw5vC3 g6/QCPNr3hOo0Pdm60VDG+owgIaOoyqGAj+ad1nKNscw+SJPjDUpDQ7mQf2/izl/84QRulkm/lQ dwcZPbnnWkRaNDSeGgzRrLxDrKQTzrnpMd8F6Q+zk/6i1jt X-Received: by 2002:a05:6102:8002:b0:6c5:d55d:c093 with SMTP id ada2fe7eead31-76f2cd6bb24mr5764659137.8.1786993604998; Mon, 17 Aug 2026 12:06:44 -0700 (PDT) Received: from fabio-X870-EAGLE-WIFI7.. ([2804:1b3:a802:463c:ff0a:9155:ae80:b1ba]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-773c508ab92sm1312783137.7.2026.08.17.12.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 12:06:44 -0700 (PDT) From: Fabio Estevam To: tglx@kernel.org Cc: radu@rendec.net, Frank.Li@nxp.com, linux-kernel@vger.kernel.org, Fabio Estevam Subject: [PATCH v4 2/2] irqchip/imx-irqsteer: Validate IRQ count before creating domain Date: Mon, 17 Aug 2026 16:06:21 -0300 Message-ID: <20260817190621.335492-2-festevam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260817190621.335492-1-festevam@gmail.com> References: <20260817190621.335492-1-festevam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Fabio Estevam The IRQ count is validated after creating the IRQ domain. If it is invalid, probe returns without removing the domain, leaving its host data pointing at devm-managed memory that is freed on probe failure. Validate the count before allocating resources to avoid the leak and dangling pointer. Fixes: 28528fca4908 ("irqchip/imx-irqsteer: Add multi output interrupts support") Signed-off-by: Fabio Estevam --- Changes since v3: - None. drivers/irqchip/irq-imx-irqsteer.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index f4df5ae73e9a..294939fcdafd 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -217,6 +217,8 @@ static int imx_irqsteer_probe(struct platform_device *pdev) */ data->irq_count = DIV_ROUND_UP(irqs_num, 64); data->reg_num = irqs_num / 32; + if (!data->irq_count || data->irq_count > CHAN_MAX_OUTPUT_INT) + return -EINVAL; if (IS_ENABLED(CONFIG_PM)) { data->saved_reg = devm_kzalloc(&pdev->dev, @@ -250,11 +252,6 @@ static int imx_irqsteer_probe(struct platform_device *pdev) } irq_domain_set_pm_device(data->domain, &pdev->dev); - if (!data->irq_count || data->irq_count > CHAN_MAX_OUTPUT_INT) { - ret = -EINVAL; - goto out; - } - for (i = 0; i < data->irq_count; i++) { data->irq[i] = irq_of_parse_and_map(np, i); if (!data->irq[i]) -- 2.43.0