From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1156D3BFAEB for ; Mon, 17 Aug 2026 21:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787000725; cv=none; b=UwBMjZ4PYDgwxcIOpctgrzVXh1UgusJPOwJqa2asLV93LeYH8jGyrPFalwEWJjGN6j+OM8+SGX0PC098t7ICMwl0G0aNUu8rMSYKfLxLoonApPeSb0crCt3qmkdnlkfqqFo983KA9afgY7lNWkioC4lsqaF0w37ENK8mjk1V20w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787000725; c=relaxed/simple; bh=DUl6G4wAMFjcPTaW9ivPMUTZ7MV9G+wwjtFPqbQhCo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rb3ANMo3YV/kRnkw0YCtQJ6wbAhnI9nXWMvxLvdzT6EGR8nHZR7XrZqEFSWaMLO3ImTVlGTRMjZRmDXxGMNxHHj3uOTWC1JSXxzUbkdfd/h/NBDVKmSvQCvW37rh0uXZc5uXZv40eT/dmANfVVygMK1tCByMuwGt53qaEc82RM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AFeyRtdq; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFeyRtdq" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so5340627a91.1 for ; Mon, 17 Aug 2026 14:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787000723; x=1787605523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G1M9b4y+rWHdlzVNQR4PsbXgwGeiCrNuR9ugfADIX8I=; b=AFeyRtdqvDM/OQi7iK2VmAPxVYh4m3OzfUmwoG6dZDA/XtvQEtW8Y9uNAE1KyU6492 86ykSpDAow7uzdmR9rAVl86sVEZZVXyW3F9bCobt+Mzwzhlj5oMF8PkHtE2Y4JhShyrI cgUF3Bmxj3/g1Q8ilp4iDBOPP+fBKBZpabVjsdZaN1RNdL4hRK201TfRAWFIdH/PfZDa f/ZBfUYOJf0dKMXJ/C8YzNHcS9irBi+qClhlMk//eTkDOergWxghL2wkyHRVEOu4d/1n cuxJpbFfXAu3MOWxjGsi5wYlLDzCN9oFJspx8WMQ6FmuJ+AIod/djx2o53siPnLDU7qC G5Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787000723; x=1787605523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=G1M9b4y+rWHdlzVNQR4PsbXgwGeiCrNuR9ugfADIX8I=; b=kUKu887v3FXcidMJnwB+R6xE8xn2FvpNrwLcsbVpUeUby1LZ+j1ZU+qcjVc5u5fhQi bD18ylxEBc/P5mp2JHsmqkuxkZshCcdyTgsIdM13z7VqHBmmtArByDwgpQqq4iQiwRAl HfhGL4aYW6cIqSIQVljK+hHBZ82qSYz/tkcZst22iRzXvd894055VpIvOSSnluYoxZno 9XI6zJGbwgeBF2DCsvcrCERjmATqf0rR9kHjmfKDTA4leb7PHJEKn0+3e36YqxXjSxbl 0N0q022o/7kpz9RRMORYcSNDVlfZtuTS0NDCwId78ZWUc5KMlFuH+VY4km52LAhye8nt lY0w== X-Forwarded-Encrypted: i=1; AHgh+RqN/E7upMPkdYZFhI+zLkw9oxWblmJ9lVZ4dclZ5xXRuRJzsHVd0fJMfIu1KuWkTGA/BLUzEaB0o6FZu+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+/ArwJkBBiAI4rlCxY6+4IUFIRyfzR+oyp1KXmhnZfmyRStyh S8Pjdvw2qPX/Gr6Dsmh6KvonGHiFsKPkqgcEjqd++myj5i8EQaHY7vUUTc+JkQ== X-Gm-Gg: AR+sD13k5Gw+ke9IJnhPhjwhiX9csWVyHhwLkN0ah29fEQDSOd3KdwBtzpY4Fb4ZHF+ c8veuTO50BJr/Hamu25wEX1z9YEy7PK4LjP7Gs9d/2IzbrVqERaGp3dfKMwAClCz3Li6dy3iphv wAfNcr69z3h+K81wRK+wAfWs/Q31YjZrJ10T5khEGeT/ztIqpfG9YU6evkGReRPOofdMPvvzGeE 8j5iHR9TnQvU+3r38lF/Em++8RStEYKiSA2vCLs98aaqn+5fKUbJgI6+uLU1iP2zxyMZ91333IM oAz/UdqSQsfI3v7sW712NeqRfHghk9pVNtL6i+B8byHOgVVSVhUUQFWAAVo8xLHgV/hVy+753TJ ew977YxPdAeB+lvP+sSevkovIH3YYU1D84yvEOoGjDBKIeyg1VD1cuCJDEzD6eXgnooaRWol2VO kH4BF7puMBz9pCQO3nOXPlI+fUcMccrqxxSjFGwikrXlSZEq4wnu0rxvJRMiTjgG6Z9g== X-Received: by 2002:a17:90b:5645:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3955a7f8e97mr3245586a91.16.1787000723200; Mon, 17 Aug 2026 14:05:23 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3953202e9ddsm6255713a91.17.2026.08.17.14.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 14:05:22 -0700 (PDT) From: Ivy Lopez To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Ivy Lopez Subject: [PATCH v2] staging: rtl8723bs: define EEPROM_DEFAULT_DIFF as -2 directly Date: Mon, 17 Aug 2026 15:05:07 -0600 Message-ID: <20260817210507.26168-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260815191030.24989-1-skunkolee@gmail.com> References: <20260815191030.24989-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE (254) but is only ever assigned into s8 (signed char) fields used to store signed TX power calibration offsets. The value -2 is the intended default offset; expressing it as -2 directly instead of 0xFE avoids relying on implicit truncation of an unsigned-looking hex literal into a signed field. No functional change. Signed-off-by: Ivy Lopez --- v2: express the value as -2 directly instead of casting 0xFE to s8, per Dan Carpenter's suggestion --- drivers/staging/rtl8723bs/include/hal_pg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/hal_pg.h b/drivers/staging/rtl8723bs/include/hal_pg.h index 7cb9c441fc01..83bf5f117e2d 100644 --- a/drivers/staging/rtl8723bs/include/hal_pg.h +++ b/drivers/staging/rtl8723bs/include/hal_pg.h @@ -40,7 +40,7 @@ #define EEPROM_RF_BT_SETTING_8723B 0xC3 #define EEPROM_VERSION_8723B 0xC4 #define EEPROM_CustomID_8723B 0xC5 -#define EEPROM_DEFAULT_DIFF 0XFE +#define EEPROM_DEFAULT_DIFF -2 /* RTL8723BS */ #define EEPROM_MAC_ADDR_8723BS 0x11A -- 2.55.0