From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5CE345EA2 for ; Mon, 17 Aug 2026 21:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787001322; cv=none; b=PqPaRGz+Yzv2L0UzNHf+P0Mb1yD/XqQSHShO7eZ8CySpRV9BbZOGlachcY4gUlkZT3Wgaoj/xNjABpHGNRK9dQVn61CIKG/xoeMbbGPw8/VvyMYbZ0d2/7xi+6ZLJuuxLrCPkumTySnHD7IeQUmNHY2kOymzGpK0miapMATDB0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787001322; c=relaxed/simple; bh=/C23C/CX4jq31Nu0aUJIPQmsjx7JRON9E+wD4xLc798=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IfUPtXjDOStlBG9JzXY1NyqHZeRGjs10ER7HQK+gxhxpwoHEXi5KlU6APIZtfh1Y1Gc0ghW0nxD42rIRYbdh3Y8WoYQ0Psuitg4jeVTzRObaAk5A91qxJtOz3LBfNJQ7ttfkSxILIlw+Nr19fN9gUHsP4N0l1soWvZ1xsgDZLXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tOpRYkLA; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tOpRYkLA" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-84e507b079dso2536262b3a.0 for ; Mon, 17 Aug 2026 14:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787001321; x=1787606121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/C23C/CX4jq31Nu0aUJIPQmsjx7JRON9E+wD4xLc798=; b=tOpRYkLAsujv4OJxmdw8Z1dWiOo7g7Wgy4xUo56I1+pudOV/t6lhnXlSS39CS3bxU3 gHRYkOQFXMqNC/PCGXs/W3HeLWXF49QOmelYxpPVcMuDyVLEqBD4x+FUC3F3vhOh8QTa pgyBvkIusGoxsHLiaV7XsoSwZYLcM8+zP84C/hLTwlrc9BM40GYDlmN8so+l/lkUy3uy kX6G0rOX6d6aw3skBw8b7KBr0QB2HNp3zQARgvCuMNU0xR9CZsYFGk95gQfXgESo5Fiu MGkhdI8kI3pAij9RAyYTSc5kXPMyyy2U2UF4QvkMtt9jjLhTFlf3gwUiRn+AJC5PCEGO w3cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787001321; x=1787606121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/C23C/CX4jq31Nu0aUJIPQmsjx7JRON9E+wD4xLc798=; b=n71gmypHsed/uCsCpL6DJ5OAQvh8pHZn5yvGyJ0rhogj2T5RyOzEdubiP33jUFoSEz 39rR95vn4djkemQFSHr3ypv1uNR/7zmIIOYBcTVSpH2bCXQJ0LQFCCsy87QTVRIshu1P 2Tc3FL7mFw9P+dy1H/FGm5+/HJLZPEts0PLyrkLw3+THH4giVKKMabedVt9pi5xfvGz8 njqlhmp42ncmfmCOCcogZuk4l86ftL6ecRm9HsQL4u2Ds+1P1u5SqpXYt8/l9jTNpC1S 7relXJJSdCgh0zMKaG9bjGOIPsDMccK33DTqa2h6m2qQGmURsX1cRwU3qN22q9WIASHX nLBQ== X-Forwarded-Encrypted: i=1; AHgh+RpGsKzS92a7NexNKAUcKeJJnSFHiBNMpwbUwwHGL+MbpCnmOwRDTMX95GqQEe8PdyPdL+LJzTcz18PRBWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Ke0q/LIfdTpzxLoEPbhqyl6p4sGaXcpy13ISMlUGiQ1nVnop VLLMKN8qxtZyEfwXF7/DMlHoW6wsX7ucMM7UAhGV2ao8IXqYKXOtY4rX X-Gm-Gg: AR+sD12j6rxO0cyiQA29Jv68H4C7wrc5doFAEEEBwnqfIbVIQszRjC6OtOqmNVBCkYR dEtABcQKbjQqPzDUz8epLKvt51nWdNW6UUQUlspRcFJoCJx2cuRBwRNTcHnId3we17tUTPyS/3g dnr1NgMDoPDh3+VJhdZEZjVMonxBrCKJ2jBPDsqA8DEiWNOkYGaddDv+s6sc4EptTv8965+9oFF k8tHDmb04D8h2zsjYxJwClZTAejmarXV9kBte/HHAkQUkSS4uPBTqKfXWiKJMwxXO+FwFWvJg8a XIeWe+9xqDvOduVg1X1RhIU1f5Q4+/+A4NAVWhBO0nxCHLPfC4eK2W7RNuU8LFKWsnvnPOHKRer WxtpvxME9Ad036bQ4xG9UxDHR9hhbe5j1AQPFoKDl0k0sKEFu79Xc2UWzVRzceUYhV8gfSEF/7E 2FTI6X0G9rXZKhw7ObvC7FxRjgjhk7+auukx4MT1tKgXK0KhWlKbUOeg== X-Received: by 2002:a05:6a00:14ca:b0:84e:216d:7e4e with SMTP id d2e1a72fcca58-84fde14ffb3mr22189374b3a.1.1787001320797; Mon, 17 Aug 2026 14:15:20 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851b6f8cb7fsm820663b3a.30.2026.08.17.14.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 14:15:19 -0700 (PDT) From: Ivy Lopez To: conor.dooley@microchip.com Cc: alex@ghiti.fr, andrew.jones@oss.qualcomm.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, pjw@kernel.org Subject: Re: [PATCH] riscv: hwprobe: require both F and D extensions for RISCV_HWPROBE_IMA_FD Date: Mon, 17 Aug 2026 15:15:07 -0600 Message-ID: <20260817211507.28685-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817-unmade-dyslexic-4bb4acf535af@wendy> References: <20260817-unmade-dyslexic-4bb4acf535af@wendy> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Aug 17, 2026 at 03:14:36PM +0100, Conor Dooley wrote: > The kernel never supports F without D, so this cannot occur. > riscv_isa_extension_available(NULL, f) always returns false if D is not > also present. > > If anything, the code in has_fpu() should be changed to only check D and > not F to match expectations elsewhere, or F and D for the same reason. Ah ok, thanks for the clarification.. I hadn't realized F-without-D is already structurally impossible here, so this patch doesn't change actual behavior. Would you prefer a v2 that fixes has_fpu() instead (checking D only, or F && D, whichever matches the intended semantics elsewhere), or would you rather I just drop this patch since RISCV_HWPROBE_IMA_FD already behaves correctly in practice? Happy to send whichever you'd find useful!