From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4926F235045 for ; Mon, 17 Aug 2026 21:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787002223; cv=none; b=mMbl9kNxj+zszuyGPF+Ivw/Nw2NXUMPV5MGexya0lzbaFwr4A9WchqjMZlPsY/BpTeAOoZbKJ2XSjfpIdMf39yf3g/5h0NbDCA6gqHcIqcfgvDu/+3Y2AM7J3cKbN6kJbo4vrzZlBNUo8eEJUZcgAao+N+Kq8WMxmZRCQmj8ykc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787002223; c=relaxed/simple; bh=+zOGPOWYYp3mtciY4HcVIIxjyTC9dPPH8Oh+OEDd3Nw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TFEqBUUW+RcbaAgu0uRaWe25Le/nS9F0EQmd1ZBtgth6OwJPbCd+wblFgjPOHuOYD7+2CespOCns92+qUi7sfZV2WGGD0Cc4jKxSTYBSw+iGa77cJ4nE+AsAqPsSJDZjBWnzemfetkO53eGyw1nRCFY9Aa1xs/9v8Ad79sVWa+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5svpgsh; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5svpgsh" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493b966dd74so26127645e9.3 for ; Mon, 17 Aug 2026 14:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787002220; x=1787607020; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yjofeyvckE+h5b1Kd3kTyp8/0NYwS43KnFfuXKj6AwM=; b=V5svpgshtoX5MkrnC8UG0gjG6PY0aohr3AJjCDeIzXTfI4oNImEk3+Su5RsZzmtakm +xY+FGKBWGQ8LG0m+J8HOLjvcVBXc2lRXTiKMLUdfbq8t55J1bnxF23Oiazx9h4GENNY OFAtyrY5D2mKqnSxZN1+tCawbxQT53PjXF4chb0Zhson9T/kfBOlz4RejYGyUpkhXs+d qPXy/V6absXX/qzNakEr5WEsUOi4BlTQ3ZrU1EPTWVuBAbGvCGlpdTAybRzFwA00wiHk qZ8RcCfyGgPVqLdyHvFoWEp36b8NwUkV0xriObc+GISM+9V33Oeeny65N253VSx7auTV QIyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787002220; x=1787607020; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yjofeyvckE+h5b1Kd3kTyp8/0NYwS43KnFfuXKj6AwM=; b=Nj2kSZoU+f9dOFdcoTgKZqiDWZXsr3AIdmVBTX0VG5SLiCWjAokN5yrT8FxriQC8vU NCra/+T2z59iX85F6iEOtBsIk5KvMmtvMU+oo2QSRkMoHAxydBgpoAZHrSLUmVj3yVEa /qUAyfnNM74sbQDXCEMDd91sqkg3DvfupeIIikIG6CA6Hh7fr76yIuYYJ68rL4MiQfP0 0L2MLKF3oBI1O0AHMWhHJaTDD8JdAdHBAtb6Z1+W2S8bhmvn42LW1bf/v2DGjOJjDWja ddd1gZnkCQ3dZ3QJcyQ8+Wdvt2NGfU5VM5ar/CWCtCEowl4lW/6qmEhfCgrAW691oiA0 CORg== X-Forwarded-Encrypted: i=1; AHgh+RqOXLwvGQwEDVdkgOq+VOgqVokg2B2ytLMXAJ3EeR+I6TFw4XLNoa1+7t7Nmble43dnlsNJji7fDblfxrU=@vger.kernel.org X-Gm-Message-State: AOJu0YzKhc1/+GsPzG5VjH3xFQbbARBj8z1iCzDLLOv76W5405pHPKK/ wmETSxEeoGVBkr4H1lAdNLm9e/CBk1mLt4d/jJIgoF2K/V9xtk1G9vWZ X-Gm-Gg: AR+sD13RufovpuB0r8Z5b4f7osZu9yJaXzMO5AT1zRtPn1SuuWhp0pz2gySztJXpfIJ 2K1ckqjNbVK//y0oVrtHDDAgU7vwuOlNLunyqJZMHFUu1S8YTl9svKf88dapuhHwAhI65yZ5vWu Mfjg0CEo/3u6R3AbK4SmkrOAMQeJM7UYinEz60qvb/4dB8Q/DcAZiOZ/wse/N1DT/fREtfRypti h06VRi3hHCVHknHP2jnGt6H5O2DzFN+9YsYBRbuaGId8GYjrkbPBMq4oiIRguFO2+QLyvip8smh 63FAqVM9ilI8Qg9GwrOjSar8zWb/C+cDZfDG6zMQAHKGD9KfQKHueWvGpE0FZfQfOIuUxUV1Q3v FZNHm5094MP/aeeEYANLWXoMyZ+u0cFk2pduPa7HQO2QhunX7BBdZPvF6ubHghAs4c0vidP/F5r b6w88RjIzfTDVFFMfZHFfkQrMhOjG8v1QyCZOlaU3SHnL34Bb9FCb6+dNFamq7dO6aLiUgktD5Q Yit7U7DqypDoop9XFN8tismiLBmG22DLyAyb7oVNlPjao4v X-Received: by 2002:a05:600c:19ca:b0:499:7ce1:d8a2 with SMTP id 5b1f17b1804b1-499879426e9mr360090035e9.8.1787002220485; Mon, 17 Aug 2026 14:30:20 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-87-21-27-15.retail.telecomitalia.it. [87.21.27.15]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4999d0876b8sm107808495e9.8.2026.08.17.14.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 14:30:19 -0700 (PDT) From: Christian Marangi To: Russell King , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi , stable@vger.kernel.org Subject: [PATCH net] net: phylink: correctly validate returned PCS in phylink_inband_caps Date: Mon, 17 Aug 2026 23:30:03 +0200 Message-ID: <20260817213009.13924-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In phylink_inband_caps(), the PCS returned by mac_select_pcs is only checked if NULL but mac_select_pcs can also return an error pointer. This can cause a kernel panic as phylink_pcs_inband_caps() only checks if passed PCS is not NULL and directly dereference ops from the phylink_pcs struct. Use the IS_ERR_OR_NULL macro to address both case where the returned PCS can be NULL or an error pointer and prevent a kernel panic. Cc: stable@vger.kernel.org Fixes: df874f9e52c3 ("net: phylink: add pcs_inband_caps() method") Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 5b8e956902fb..3ec3bb439109 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -964,7 +964,7 @@ static unsigned int phylink_inband_caps(struct phylink *pl, return 0; pcs = pl->mac_ops->mac_select_pcs(pl->config, interface); - if (!pcs) + if (IS_ERR_OR_NULL(pcs)) return 0; return phylink_pcs_inband_caps(pcs, interface); -- 2.53.0