From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DB23EA947 for ; Mon, 17 Aug 2026 22:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787004505; cv=none; b=gO98ozYpkiBNgoAYIAHVeu3eLxrIKKO/sXhfyJH+v8JRo7AEgORrtsRKoKczlEN4LBdrGiUxx7qvdWGWeGs8IsxigT729Je1VvbyKyXyOOyFBQoZXhohoHGtzLNGkaYnoUmGPLFb80HWmtUN5ShqUaJ0nzsJYrGDpqummUa4fTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787004505; c=relaxed/simple; bh=HLXd7r9UoHiCOCGXYySq+SbExbsYPes653QqEyqbsUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WzY4Dmh2CzPxAcTZOniCpKzFxKh3Hz2fQvuFKKImS+P5+w82cZdrus8mNzrkqi4SPNlt9NOUPiRtz7xNGBDkPXq7TavOQ7ZQ/Rha2BR8JowkFghoGxZ6e3BvaGJ/ELz6qMC57rPT7V/WgXl7YnHu4Vxi9hkDAhCrcpzhf3x0Drs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=W1RSBXYx; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="W1RSBXYx" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-93703cc9e2dso45475585a.3 for ; Mon, 17 Aug 2026 15:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1787004499; x=1787609299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PYwESWun0fa6liMiTXLOYEKQD6iVsL/nuJsHb68bQDQ=; b=W1RSBXYxvSp4Bx+MpTdA7tYVjdzTPMp42cpQTj44pG9a+KH3KJuQs+t7g/y4o881ki 0cf/vVG3ithSk3upodZqb3CoR+C02b5OtwqI9yTjCVQ6OGL95/utiDSzbUpgAK1WYKzz XzejA44Jd4M+P4BK7buaoGV5f6k2jWkkfvOycPAoTYPqPR9hhS3BJ++z9ugnf+nvZz6O tMf1itWdu2CBq5kU+olf4VSEfNtS6D+VGuzmDSrlLSwpwvvEWjWh98+c+8VmTedDtK5U F8Z77a2cQnQ8gPEX6mx61kKuk0WrB4YLbOb6HauPVC4zF+GJ2ThgQBwSsSMX1ongV8p9 gHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787004499; x=1787609299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PYwESWun0fa6liMiTXLOYEKQD6iVsL/nuJsHb68bQDQ=; b=m7tbfJiQNtUHZjPskwdVq2aNR4O+tRECEegh/hITLQnmyLtNHcTOZmQO13HmdByeNM hPdQjzlQjQ9EfYhpzUYtLpQnj+WpqNJg+F3DSb/Y3XzjyKqEUiLeHkgGszWjT30b4yQX epfFswxCJBSfkLhvhTElYUYfQQbe/XQEYlwlDZ0Pyc4qrDczSLWtcbrS8sGfP48BzMj9 K7B1ePU8j4Oqc7VpEMHJXTJ6czHxBKQX7geTu8go7rvI0pHMLxOvGWIvymIXFYTcKfeM +mUgpqHcc2MwDXJ14/fpcuILT5qCEe9PAL0PfRylFuNXNLywzMpzxHSeIPpWcLIpRnR4 LfzA== X-Gm-Message-State: AOJu0YzZgGurDoNfP+/gDjyvAWWqjRa+nYHbaDycPtQ2xjjV0qfTxL81 BGbCkmCfg/25vfptWvsUn/t9dLwDstc6OoJo4l6/leR+TFRxD6z3w7lXf6WLgtOFv0s= X-Gm-Gg: AR+sD10lDuKmLzJ9JmMo4SVQIu0EXPiEKoGKBR8T51ClKkZZq+MVjw0rjHPXubQT7K/ QdVOud+isyA0zivlfilfTgfdPygYN0vufXOudXmZRxphRm4fwI2yh/odEMLhchggVfkqfzXDBFy Jsn8PJ4Ke9zMr+1WqXRSrKOygKhNUYZSV5FTAIBZKe6pqf27MRqIVYEi2DSXpFYOCWEHMHtuVBB 2iRyUJdCZb8R1wp2t1Rm/+EVuMe8ijlORP85TCI1NN3O5LStWxy1VO6RXfsfBkxOFeHa2u/bIwl yKWDxJ4I4qqBI6WavHdVBmwO9rDmTppfmmJLzgw0QaR22941SO8amdXvPDdFEyXIOw02s8LhiPe vY//vYQrb7Ep4Pp5pdd5gYVCNmMmyFeQzoIT+sTJPRH3x1g7+CBP4prtjbsT6FCu8S+/26AcbqA DSNLKmUNqHQui3LiZEUA1Rfu9Qeeg7F+2IfneZtZxKZqXR0tfURPJT+z2/mOpNNCMKsdMnC1E+2 ASOgyzlgH/2dYvuKjM+j/n9uCKoz0baFXnUebGbOIiSuACBma49xHJXV7gJ X-Received: by 2002:a05:620a:4387:b0:92e:bc28:5479 with SMTP id af79cd13be357-93704b1ac3fmr488870385a.2.1787004499566; Mon, 17 Aug 2026 15:08:19 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-937033ce78csm147108885a.31.2026.08.17.15.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 15:08:19 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, balbirs@nvidia.com, stable@vger.kernel.org Subject: [PATCH v2 2/3] mm/madvise: skip zone device folios in cold/pageout PMD range Date: Mon, 17 Aug 2026 18:08:09 -0400 Message-ID: <20260817220810.1175596-3-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817220810.1175596-1-gourry@gourry.net> References: <20260817220810.1175596-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit madvise_cold_or_pageout_pte_range() resolves the folio backing a PMD via pmd_folio() and ages or reclaims it without checking for zone device memory. The surrounding guards do not cover every zone device case: - can_madv_lru_vma() excludes VM_PFNMAP and VM_HUGETLB VMAs (so device DAX is filtered) - !pmd_present() branch above rejects device-private and migration entries, which are non-present. - A present zone device PMD - e.g. a device-coherent THP - is not filtered by any of these, nor by pmd_folio() (unlike vm_normal_page_pmd(), it performs no special/pfnmap check), and would be aged or paged out here. Skip ZONE_DEVICE folios explicitly during MADV_COLD/PAGEOUT. Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device pages") Cc: stable@vger.kernel.org Signed-off-by: Gregory Price (Meta) Acked-by: David Hildenbrand (Arm) Reviewed-by: Lorenzo Stoakes (ARM) --- mm/madvise.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/madvise.c b/mm/madvise.c index c179938097bf0..2151bb9468594 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -396,6 +396,9 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, folio = pmd_folio(orig_pmd); + if (folio_is_zone_device(folio)) + goto huge_unlock; + /* Do not interfere with other mappings of this folio */ if (folio_maybe_mapped_shared(folio)) goto huge_unlock; -- 2.53.0-Meta