From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C09263AC0D8 for ; Mon, 17 Aug 2026 22:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787005487; cv=none; b=XkfoW6Hk1t5YNcpG0AH8nGf6HCRCKlBxpFXOCQY0vPxxawRqQageyYjhVlGy0WXGt9d6QmS/TeH57q7Sw5O5OetAq+lOlF3CR2OnmqqV5YTLBkKrxRocAWs5obFlUzQ9ASNCAQYlJiIv7Zto3gMZRyHaCYJf2wWlS1zWn227x8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787005487; c=relaxed/simple; bh=PmyumuIbO2ebXCMuhpUbu+i9E21ps12svObOY0TjhVA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JvHs9n7rniBKlttBDSC25WCad3iUQY0LdwsB5BzupMWnIhBpoWrgutFAPfS/tniR083+ty3zXfLJsuZV+iQE4OLjJR59g6819cVs2sJVXg619NrsBXRx2u5N38wD7d653umv7ss0mRor1YCsRn9tjGHrdIsOsVL/YHu3+3jDfSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pnFQTtcT; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnFQTtcT" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7f3faf2b081so1786824a34.3 for ; Mon, 17 Aug 2026 15:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787005484; x=1787610284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PmyumuIbO2ebXCMuhpUbu+i9E21ps12svObOY0TjhVA=; b=pnFQTtcTGLND5KcEhc8RF2Pd/yTy29C/gcT4SidvaJV5mYEYV15PsEP7gd5SAT3gaE 1i07222/2AaE5R3DqmnzOg8LFjjeSkpRfMq0rS06amczsAK/VcpAsrFvzg0Or5i4SQqc oh8WE5nTcqJF96XZvFL1enjPXqSk1v7fuR8PhjqOpG9zn/RDAINs8cXO3Q2xi4iyvUs2 yCXiWhhIyd4/R4VJQ7cBdzA2fGhFE4vNN29mcCAgPtajN/43J8T/lQ3WMY8OQXw7f9pV U21GHNImcLC+iwFChDqhEoaf7mg0jrbK97V+uji8WZMFfwhfHpdXkohy7g0+NFh2wmm7 sLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787005484; x=1787610284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PmyumuIbO2ebXCMuhpUbu+i9E21ps12svObOY0TjhVA=; b=eVcoN360W1buiftFANHAgh7zXHdvLLedceTTBcuWMHE2bpYSVXEZDESjxg03QxN5IR 0pn9pAk0WM0cJSb/m673ySxN2nmFYcmr5VPIKlWt+RUi3RIGcyMy0AW26pNXxBX+IBqH hL6tfVSJkFLj0KWSiumvFAoiyG7ixDuP/OQL+Yh0mwBo9t1cFBfx9x0ljqSbglQy/Fs6 LSZAPd6eXTa1d4QVe6EYHvZ3Ca9Wez09VnNeJSnWwuHAlnkERxFtQEv4+lCPQnWjHp3k r2VeEP7Drvp+LUhLa2NXCOK0Pf77rFbMcl3q0vHs8viRbX3mWYWK5FBNujzeLwm/fPLY Gduw== X-Forwarded-Encrypted: i=1; AHgh+RqJgtaabJteY40quoOEjkB7b5r9mGxjCLhx8POrLHYQBC1C/nR/0qiGOgQZ2Q2sp+e5v5njbgvzs/PYPbE=@vger.kernel.org X-Gm-Message-State: AOJu0YyI8hmFU7bG0epDxeVFdW+no6L25J8fMgbaaK2W2SRfzg5MjDkJ pwA7dpSdeeQHnK0J7+HCMCqAHOjDtytpKypODKSg8zBkJ4Wy3qVVqPjY X-Gm-Gg: AR+sD13+tdBN2ercLPrAS0agepHluKGLYQDtoxjsU78gIOMBE447onhWT6Jua6HNfde m9KsqHzjCHHll2SHMrTfRobpSLeWdVe5mikcI/o+b7Y+2EyQi68/ZV6APF0pRyo086a/1uSfqR0 BRrlzJlg5z3IBpRwChxFHTS9/PdhYRn5WkjJrz3l40b8W+Y8GMWiInvX1BySkHRJlZSaOQn5IAP 4zmLDK0GSFYLZfnjObMIdVfm3vm2G+o2u4eRK3jt3eJgjDZjz0WEZ1i7FWBvi0wvyjeReZ80nT2 5wjeUEUlWm18KH5R15FFNzmtncyGSX0F2blSR5nrigM/6bpWwMXbxovShUH446NXVnJhHJk0Iri ZvJ6AGLsjoppYE/MZuyANs274aLHJEpnhaxDvxP2NlspMYF8AO32hYmov0GKOWPbK1Kr+CD/21H 8Pn9pVP8PpdfVj6z1uBjC/RJvs9ShWIASFQHrP+Hyuo/j9jLCLY17vGd7/kfcZzKn+q8QE2R01i wMzbbXaZvXsPgphD+creFdS9J7jvoIpbtsGDpmAsA== X-Received: by 2002:a05:6830:3108:b0:7e9:ff97:5e3b with SMTP id 46e09a7af769-7f3de65e719mr26071151a34.15.1787005484560; Mon, 17 Aug 2026 15:24:44 -0700 (PDT) Received: from holowork.tail3176d.ts.net (static-68-235-46-81.cust.tzulo.com. [68.235.46.81]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f41bf31393sm2516813a34.12.2026.08.17.15.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 15:24:43 -0700 (PDT) From: Fabio Piparo To: sashiko-reviews@lists.linux.dev, Javier Martinez Canillas Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Barzilai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Fabio Piparo Subject: Re: [PATCH] drm/ssd130x: Set the address window in ssd132x_clear_screen() Date: Mon, 17 Aug 2026 18:24:01 -0400 Message-ID: <20260817222401.906748-1-holofermes@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260817154126.D13271F000E9@smtp.kernel.org> References: <20260817152500.703770-1-holofermes@gmail.com> <20260817154126.D13271F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I can confirm that one of Sashiko's findings is correct, and it's not limited to my use case: with the early return on !plane_state->crtc, the clear in this path never runs at all. I also have to retract the testing note. I did more testing, and the blackout I had attributed to clear_screen during bring-up was something else entirely, not the clear writing RAM. So "Exercised on an SPI SSD1322" is wrong. The asymmetry itself is still valid I think (the sibling ssd130x_clear_screen() sets the window, this one doesn't), and the patch stands on inspection and compile testing only. Happy to reword the commit message in a v2 if the cleanup is still wanted, or drop it. The other finding, the out-of-bounds read in ssd132x_update_rect(), looks real too, but it's pre-existing and separate from this patch. Thanks, Fabio