From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E6143846B for ; Tue, 18 Aug 2026 09:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787044569; cv=none; b=hMj6RJIpTkYhTpSv3totCvbin1ygk6c7kHDUuR7uxq6CRQxzoyuBEkN0xaIcw/ph468AuFUzujuoWCeiuLBX8dtDDFXE8EeaDDwnQJWYDaAnU9fTpIKL/S4yldq8Nq1sOIkQZFr/0FOT4c//ONQQ2a/B4mz5Iuqkl16Csd3ic64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787044569; c=relaxed/simple; bh=Eu6toHOdCgS02ZJDxNjsrmINE4rufXfvVtLn/P5Q6r8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TD5VUGfUpKTQDCJnr/lJ61djTqfbjcUizNhenAXigG/v2FfX+MJqi++yF3qPwsr/Iq4lv35kLruiRUv/ceQp4wzfWYQDm3kbUPju6n5Mk/zOfMc4eWPiop8fZBDTS1hrZ0taautHhL+gWq2mhbQ9wOYiZW0fJXZyegVHfh5H9lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K1Y8eF4/; arc=none smtp.client-ip=209.85.214.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K1Y8eF4/" Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cfc52ddc55so72285865ad.3 for ; Tue, 18 Aug 2026 02:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787044564; x=1787649364; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JcYyJmxeOItQm57PoOzTDELkKzo8NHBgHiqMw1DpJFo=; b=K1Y8eF4/BfUF+J4iyXE0Oa41seR4CU+oiFBMdsUfp3uNW8x8dnahtiaPROB57SDhDx pZZH4yQ27tzvSQs/Vx8fYYiIRmee9VwP/JCuYbem4dWNrPU9qGYDLx+abfEBUdynA4Oj 3sgQE9fuRufEmvaKJXUNMZ0x3dHMh7k2jvMwfcEizeMxlw9C8VC3agE3VTGm8qUGz2Wq RmhCTEsfejWir07gcIbtF736+Ym8egfzk/9pWW+dPAudrPyMYZrIJr1TQfw2/FVkEwRr cE03xxYiemG0nl/a3pbxnyV6m7M/vsNel6AAAXurWLJSqeAqol0p1zeSvD3XMUDOjRmP Drjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787044564; x=1787649364; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JcYyJmxeOItQm57PoOzTDELkKzo8NHBgHiqMw1DpJFo=; b=GpOchMRymiNe68mYQT2avk6tSuV65cCAUhTXW+ktUVMy0yGoV49AEmrQ8iySCVOUsg U/b53507Pfd40stZHxlXmAdUKVmXchSVFfe6oNREaA9M6VRsiYjK6MD7R4Rt9E3dkwOW FjmK/GwVA9KZFxktqqxJfAaeTZ01WF2BqhVGyl8dt/0pZbvPU+w+uIt/w3i3PnlQ3ouw 93ke8fiTwN/ydkYOEwRorCtBd2+OQLw1Vnf4ad1uRjHMQE/BXbLsKV1IPBaSOv60V1GD Ngjt4sFMEwEuK80eSglzWOR2CNtbAJG6T2VZZyWh0263BdbEHWREyZg1D3vZi2V9GPKc Q4bw== X-Forwarded-Encrypted: i=1; AHgh+RoHn2136niezfdGRJIBkhyktep0pyXcG62a8S9hyabYRxn7jeHGFza9edEXwYTEJQtgFE1SIHlmlRZzFFE=@vger.kernel.org X-Gm-Message-State: AOJu0YzIiRU3v+JoQct3GjRhg9+LgKz1DcMqqGnbRsVj6u30ftPW1i7f e69oTCelYRibugiJ6Dm39Qa1LK0mPm3wCKk8T1Kb5SloPf50dO7NzR9HNEsioTyq3m1C/Z4BHk4 BFOgM0w0ch1Cu2RUa2VPJ2mZ5Gw== X-Received: from plbz21.prod.google.com ([2002:a17:902:ee15:b0:2c7:de3c:549e]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:b0b:b0:2cf:9347:f445 with SMTP id d9443c01a7336-2d3b0c7ae46mr360869955ad.10.1787044564080; Tue, 18 Aug 2026 02:16:04 -0700 (PDT) Date: Tue, 18 Aug 2026 09:15:54 +0000 In-Reply-To: <20260818-gmem-no-return-page-v2-0-5298f42d49bb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260818-gmem-no-return-page-v2-0-5298f42d49bb@google.com> X-Developer-Key: i=ackerleytng@google.com; a=ed25519; pk=sAZDYXdm6Iz8FHitpHeFlCMXwabodTm7p8/3/8xUxuU= X-Developer-Signature: v=1; a=ed25519-sha256; t=1787044557; l=1303; i=ackerleytng@google.com; s=20260225; h=from:subject:message-id; bh=Eu6toHOdCgS02ZJDxNjsrmINE4rufXfvVtLn/P5Q6r8=; b=4r394TRlnUkgQelNG88PQ96qVChnPFNFyot7lT1B9nuxLhLRLmkhypwFy2Q1Jy4P+LuelDJE+ 4XIVWacJ6u5CilOKJv5z0iQvoHdCGx3UqOwDFsxlX70DzaNRuHKHs6f X-Mailer: b4 0.16.0 Message-ID: <20260818-gmem-no-return-page-v2-3-5298f42d49bb@google.com> Subject: [PATCH v2 3/4] KVM: SEV: Drop page refcount early in VMSA reload From: Ackerley Tng To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ashish Kalra , Michael Roth , Brijesh Singh , Marc Zyngier , Oliver Upton , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , David Hildenbrand , Fuad Tabba , Yan Zhao , "Edgecombe, Rick P" , Vishal Annapurve Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Ackerley Tng Content-Type: text/plain; charset="utf-8" When reloading the guest VMSA for an SEV-SNP vCPU, KVM retrieves the PFN from guest_memfd. Drop the page reference immediately after retrieving the PFN instead of holding it across MMU lock acquisition in preparation for a follow-up patch to stop returning page pointers from guest_memfd PFN lookups. This is safe because the page's validity and presence are governed by KVM's MMU invalidation protocol rather than the page reference. No functional change intended. Signed-off-by: Ackerley Tng --- arch/x86/kvm/svm/sev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index b34b11d7f8fad..d3d620bc04dce 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -4062,6 +4062,7 @@ static void __sev_snp_reload_vmsa(struct kvm_vcpu *vcpu, gpa_t gpa) */ if (kvm_gmem_get_pfn(vcpu->kvm, slot, gfn, &pfn, &page, NULL)) return; + kvm_release_page_clean(page); read_lock(&kvm->mmu_lock); /* @@ -4076,8 +4077,6 @@ static void __sev_snp_reload_vmsa(struct kvm_vcpu *vcpu, gpa_t gpa) else svm->vmcb->control.vmsa_pa = pfn_to_hpa(pfn); read_unlock(&kvm->mmu_lock); - - kvm_release_page_clean(page); } /* -- 2.55.0.699.gb54405d56f-goog