From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DAF7379ED4 for ; Tue, 18 Aug 2026 04:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787026515; cv=none; b=LPwPmNt7p1bU2F9s9zwAhWVUvJ6dTS87Q0zfKsXxsCPJ2lAwfPBBeejm9MSVQBY8leWq4+ZcNxCuNc3vzBf0F0LfMs6n8MHKUlX7hRYz+sPm6ni9QS1oJOyx7FA/ECLVMwUdNHp7oSGkwt5uumHC16BOaqBFlWhDXokeR/QmZbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787026515; c=relaxed/simple; bh=r0yrG7p5rVwF584joZCtda8l8jb6N1Jwb5KgGX9amR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oZCoKQiUbnflbSVDSTJeZBwVKNJVjzJwpDKrYUvY1B7Xvza9slKTsGkQK7oyfALJqjxmjGzHTkPFyAxJfNawblArUlLYL6f2sRzTJPCD5ARkw/UaTh2DVCHRjAJFxo1aS17K0mIN9Hf5Y5huN1abFv+Wu5Qepsf3DbRwRCuoncg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cQVaD3zo; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cQVaD3zo" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-383cb94f742so5089356a91.3 for ; Mon, 17 Aug 2026 21:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787026513; x=1787631313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Fupa+fHZK0GWdNE5zNzfh7AYYl8icRGNF60UcTuU8jw=; b=cQVaD3zozjfhgsOzDbc1aFFAsHetQlSPQRpI/kqmPcOAlcPXSYxcDyB58B1/A+qXek 4dgqxCv3GuESsYtwI4rwdZd+fxorszZs38qUroTqemaxfiyTPBAh332ggTm6LJrl/L6x 9C4Pc/YGms13iYXHIKrFAaFJSfU/YOpn4HfJ0ZZqhhYvsstwtWjYi5sFUCTlrsdL4n/D hHG6fBca8bKFnUz8coB88Wl/tQWRaGnp4s6wsWCobogOCWumyWbfVb2l2rd32lhQXl1W X1GROrM5LzD83v+sgz9IXxU8NmuCwQRpXe+ifZmRVxrxI6MGRJq/f8vpJewRSLpHSL4b Px0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787026513; x=1787631313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Fupa+fHZK0GWdNE5zNzfh7AYYl8icRGNF60UcTuU8jw=; b=MGlUfNDv3QIIPI64/xIaD0iQm8ArJLBQOj8J7Eo5V7flIMS5GdaqzRh26rDDDwgZVP 2slWz0O556a+/5zvAzRzOEjsDCB8M5VKLlyi9Maw/lVFNvTlyombrp9LfOHLVnSTtVxy 2AVE42Wy3QpPliSoCaRxYSkg+bhu2b8RH84XwIyfBIoYizUJcyPLT7X0QfjC3XfAQ3LU km+gHHJWEnsD1oaDj66ROnnhxOZu0cK1XJpaqGQD2KW8wUTBVarAKxzv/BuHR7PMPbHt n7YcQFnwDBHtP1nhLWMP6+Jwfin3fleDHl3t3l0pdaOaS6XI8qt+qIm7FLZaWFNorQQA S1YQ== X-Forwarded-Encrypted: i=1; AHgh+Rp571TSVHuZtRdPMqZ0oHqqNmGs4vdHzuc+vJdhRnyeFO+qeWTTCmR/2ObyupB3g/T8LTEzTDk2IZsK1NI=@vger.kernel.org X-Gm-Message-State: AOJu0YysumkNCIQ2EWLpvUZF6zRJ5p67+kpCecr6aobS/JcM6YxT+tbP 9OcxTILWw79+QN0uUgO4997KqutTdaJtKA8Uvo0Rz9GNx9bIpFk2M2o= X-Gm-Gg: AR+sD13iq3rqX6r8E5FdS3k/qexYX+CtXnbjipiVMopP3Av3FoICOlZ+wRdYGpJKXnT 1dr3P9udNKQ5JO/ZaxtJ0UWGyEkQF1Kw1ycz0sPYgjpLyC1edIW0iCwZH/szIGsBuynGxi4gKMJ KD8fD9Kk5X+9qQDlbAtFkq5MVVOQbdARcqgSYgzBoeA+g0w2Dai3Paxb/HOmnkxp/5GWFF1CWXt GmubU1OfHcw0d9OREiSL48hrQQIaODuNFCfPrC095kjDpB9sZi/aDu17YIHTMnSkfS5wshRUXRe E4tD7gIW90GDKRKl54i/S9bd80bJ4yQVeXBq9WpNNC/eklHYnK+kCebNGir7LacK4JNmKE1CFR4 cvYfE/q+QLNt8au7aHZDO5EOzNdIaYnRwMfTornixVHULeQfRa9kPk5LFpWTfSF1gh9SGREC+Db zQMSj6usvjhYQYaKPOwS0//l3WFwQkuKKG8fD5vcNWkr222tYgDHDE6BFawKgx X-Received: by 2002:a17:90b:39b0:b0:385:393e:7124 with SMTP id 98e67ed59e1d1-3933e60f9d4mr29110763a91.14.1787026512604; Mon, 17 Aug 2026 21:15:12 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e84244sm7206458a91.6.2026.08.17.21.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 21:15:12 -0700 (PDT) From: Triet Hoang To: royalnet026@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ogabbay@kernel.org, tomeu@tomeuvizoso.net, triet.hoang.dev@gmail.com, markus.elfring@web.de Subject: [PATCH v5 1/2] drm/rocket: Check allocations before use Date: Tue, 18 Aug 2026 11:15:04 +0700 Message-ID: <20260818041505.1579320-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260817093009.22359-1-royalnet026@gmail.com> References: <20260817093009.22359-1-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the result of kvmalloc_array() in rocket_job_push() and kmalloc_objs() in rocket_job_open() before using the allocated buffers. Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL") Signed-off-by: Triet Hoang --- Changes in v2: - Free scheds when drm_sched_entity_init() fails. - Initialize ret to 0. Changes in v3: - Move patch version descriptions below the '---' marker. Changes in v4: - Remove unnecessary initialization of ret to 0. - Adjust commit message word wrapping. - Add Fixes tag. Changes in v5: - Add check overflow before kvmalloc_array() in rocket_job_push(). --- drivers/accel/rocket/rocket_job.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index ac51bff39833..15e93c355c38 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -189,9 +189,15 @@ static int rocket_job_push(struct rocket_job *job) struct drm_gem_object **bos; struct ww_acquire_ctx acquire_ctx; int ret = 0; + size_t bos_count; + + if (check_add_overflow(job->in_bo_count, job->out_bo_count, &bos_count)) + return -EOVERFLOW; + + bos = kvmalloc_array(bos_count, sizeof(void *), GFP_KERNEL); + if (!bos) + return -ENOMEM; - bos = kvmalloc_array(job->in_bo_count + job->out_bo_count, sizeof(void *), - GFP_KERNEL); memcpy(bos, job->in_bos, job->in_bo_count * sizeof(void *)); memcpy(&bos[job->in_bo_count], job->out_bos, job->out_bo_count * sizeof(void *)); @@ -501,6 +507,9 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) unsigned int core; int ret; + if (!scheds) + return -ENOMEM; + for (core = 0; core < rdev->num_cores; core++) scheds[core] = &rdev->cores[core].sched; @@ -509,9 +518,9 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) scheds, rdev->num_cores, NULL); if (WARN_ON(ret)) - return ret; + kfree(scheds); - return 0; + return ret; } void rocket_job_close(struct rocket_file_priv *rocket_priv) -- 2.53.0