From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52FF7284896 for ; Tue, 18 Aug 2026 04:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787026523; cv=none; b=lAZBRKYcgRH405LvasHbmQVOb8Y4Mhva+LZXFAs6hNd8paf3N2yFFW8C6fv2rtUyuXv3SXgJkgKlCj40j6miwz9H6Pbc7TsQqChepJGmTJLvbdOoRk7oiWMYLjHpKDianxXLm8PJjlxWQ1nySxvCMG0RgP49+JUeGp+ud1Rm+oM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787026523; c=relaxed/simple; bh=QQu+i9D+u/SBoIKCxYply1COqEKHnzYkJOM6BMpnbfA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JzILlqr1rsdIpcoGqIX+mag2gZvpJ8TaepmKJAg2Ypw0nlPrfKL1d6UNQnFbI1vqo6whODHCFkx2/xpz0PZpvyRnMHo2UfOrwJ3vtx6HLbDVhRY3meyO0PEG4ewa9NUMkJ4c5jb6/pd9RkTxrJ+OPtYOmLHS6iJg40cRrNKjJHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L42Z/OR4; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L42Z/OR4" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so2890523a91.1 for ; Mon, 17 Aug 2026 21:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787026522; x=1787631322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TSUoNKxgsogZ06aAWwzyG9s03gy2yOBd81qFJRq6Ii0=; b=L42Z/OR4drpy15OlgLWM7sxY/DhlI+Kq6YY/vfYLNlNW5yv+FGM1WoP4+2CrR5jht1 uSq/saiATUmim4WIZVI43AoD8AzsvdrQQo134D2vPCa4HPh5/AryYBhSztLytw8I6nYw O65UEZ0YRTjLfhsmqVctydzpp4q1wVbmz94QQ/ixp5YSLbCc2O3PVqYdd8WvUbWM426P kVOPuoEtuiA2jkD6Y6Uzdphq6z8WslPZsCGsVfvo6BdZ1+ogyyvzPuyT7ekP2Wcc2jig u2KPpo3wxoc4uObBJuelb72qQrNoQn9tTiFdFEs+gS4vzEbVH/Fc/AgVMTxbEb6PtysK NCMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787026522; x=1787631322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TSUoNKxgsogZ06aAWwzyG9s03gy2yOBd81qFJRq6Ii0=; b=GEio+YC9fDNpgUC2ycK5baa+AYqFV1UEVpMf3KfyZxb+oSfSZjYf8XMUg2sUWvNhqS r8yN0tkt3Kfv93hz9voWWyyYgU0rJssAjTAI1wAhLMwqc+tInPR1xHJ55W7uAMmhrRk/ eL4PTMcl+trSxLSoAScamh4O3ymx/kmAM2lEMTPwI8XifjcNUUv/VbiuQqe+q2Kyoi6/ Dtzy/ATfgI7vv5eDFf6zwl2cbO1bT2nGg+o3Lz54nibArVhC6VL+K08hmHTmteIAWzh3 2v53XoN+Ed1X1J3gAy3TL7Rr9zoCeT8pccDybvUgFy49cisPcsqmDJfeiweeKfYwldqq GCBQ== X-Forwarded-Encrypted: i=1; AHgh+RoJ/pgHyiOHWNStLP8ClfvBOqMrohB25WkBOApos57cx50wbJWf8TVDlTelIyDJ+dvE1xkUy5G/FPY3ECE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7vou6rkm+nu6XCvq4gHqKhPzwrGzc9T5hOThmzKM5QtL/ISZy 6ozovxFvn1UG4BE8UWJn3s1cRMLUq4taVDP29DA9OwpRKZGsnY9cvgI= X-Gm-Gg: AR+sD120OewpH13SKH5XoU38CZD2O/1AfPBqaKXZatWVH6DpjJ48IscYtadWKqdduQE VOyKzvMCyIHHy6yKhaL8KjKZtZAVysqzXr12/Bj9rXbWTDLUzg+l2bPsWj7fy3pjK1fYp8FE+Gb chMYhTwpPXtQ3EJfhA/JWN3rK2nvip/zn3x4ugTQ+tY/T0urgdAb+r2XsC49Xqs/Zlt2432mh6g fFAnPQDA/AaB2/ifR+SNAwGhCufkEmGfcvmyJk/k+ivljs7hMjothst+gXnpjRLENDayuZ9FQkU 4OSxuYqudQFyOl0TScIHWdMmoilFcNbbORofrLyphX0p0T4zRqVXxLNmMj8rPWKlkhpjwmiCPDc l8oZFRkby6EARrhewl8V8WrdQ0jb8iZ1PuVdMnA3D51ea4ypgIjCUOtxq9GC1bM8gNnPw7bziyW H070ngWprRsqOSGhH6hER8ZO8sKgHZrlosNHByHyRQ58qf5+lEsu5mIb4XgXdyw7W5IIZvETg= X-Received: by 2002:a17:90b:3c02:b0:380:f389:447b with SMTP id 98e67ed59e1d1-3933b8938f9mr32518274a91.11.1787026521518; Mon, 17 Aug 2026 21:15:21 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531e84244sm7206458a91.6.2026.08.17.21.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 21:15:20 -0700 (PDT) From: Triet Hoang To: royalnet026@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ogabbay@kernel.org, tomeu@tomeuvizoso.net, triet.hoang.dev@gmail.com, markus.elfring@web.de Subject: [PATCH v5 2/2] drm/rocket: Keep scheduler allocation in rocket_file_priv Date: Tue, 18 Aug 2026 11:15:05 +0700 Message-ID: <20260818041505.1579320-2-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260818041505.1579320-1-triet.hoang.dev@gmail.com> References: <20260817093009.22359-1-royalnet026@gmail.com> <20260818041505.1579320-1-triet.hoang.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Keep the scheduler allocation in rocket_file_priv and free it unconditionally in rocket_job_close(). Suggested-by: Igor Paunovic Link: https://lore.kernel.org/all/20260817093009.22359-1-royalnet026@gmail.com/ Signed-off-by: Triet Hoang --- Changses in v5: - Free rocket_priv->scheds instead of entity->sched_list in rocket_job_close(). --- drivers/accel/rocket/rocket_drv.h | 1 + drivers/accel/rocket/rocket_job.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/accel/rocket/rocket_drv.h b/drivers/accel/rocket/rocket_drv.h index 2c673bb99ccc..9421e48ec5d8 100644 --- a/drivers/accel/rocket/rocket_drv.h +++ b/drivers/accel/rocket/rocket_drv.h @@ -23,6 +23,7 @@ struct rocket_file_priv { struct drm_mm mm; struct mutex mm_lock; + struct drm_gpu_scheduler **scheds; struct drm_sched_entity sched_entity; }; diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index 15e93c355c38..50b6e0e06ed8 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -519,6 +519,8 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) rdev->num_cores, NULL); if (WARN_ON(ret)) kfree(scheds); + else + rocket_priv->scheds = scheds; return ret; } @@ -527,7 +529,7 @@ void rocket_job_close(struct rocket_file_priv *rocket_priv) { struct drm_sched_entity *entity = &rocket_priv->sched_entity; - kfree(entity->sched_list); + kfree(rocket_priv->scheds); drm_sched_entity_destroy(entity); } -- 2.53.0