From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F0BC1D5174 for ; Tue, 18 Aug 2026 04:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787027033; cv=none; b=elW0MSrQXstSM3dsyCFOvB1RwxAeYnk1D1uI4voZHPxGE8jEJ1vWhOaj72RefR/V1gZMxLpL137Gso6T6ye2Kj7QezrihEon8mo62IX21nNpq5u70/bdzDSOOq6SO8Bf1U7g3mGRz/2gvFX18qeeqwOKIx0MiaJCGXAa3yk0cEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787027033; c=relaxed/simple; bh=YQFZsKhmESUwEHTXIf0erBhkQKCZAhCVRTJv5g8p+dw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P8g4stu3IOp08iNxYy9o8ceQLzEpcRtvzUXjry3kdkHikafcTufwqZBHg8MfxXHEiqZD35Ox3iO7GAnrVcYzuHlBljg1IO+HWgDwKHVyPI9tzrbJro8r3zWIcxhZk19XgZ6k0UB+lchpG3cW+J95AfZTMOPC8w9A0c7b2aErkSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bxwZOgl4; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bxwZOgl4" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so52693885ad.1 for ; Mon, 17 Aug 2026 21:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787027032; x=1787631832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YQFZsKhmESUwEHTXIf0erBhkQKCZAhCVRTJv5g8p+dw=; b=bxwZOgl4zQMcsmEQhJb3dNi7bLBHddrKGvpnZIAEo0E3ur7NI3O6nqlPURswc3hCZd 5A54qWRJ8vcIyYsDUMNsh0FW3CNNVl/7/6wFr/WFmA9V4ggxYg5HKNciJr7lLWgUDHjA 5pWrDLEBiZVBKYkVQ2zYUdMk2VN/rqqJ/pEoefVFfMIgwuZyBZ+Au/IUpgpJGfQ+sXM/ MRkHxw1eO0Q4+jBdJdRpP/zYsy3+J1kBlFoabKqIBvVI2+py3qgUBupKQ9z0w5TN8p3n /fvbZsbJXqp/zYUQ/ZKRIdY386oUlKJhPMXHbljxDNTm06ED1OQtBmrc56BkLzeGtpAw fK4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787027032; x=1787631832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YQFZsKhmESUwEHTXIf0erBhkQKCZAhCVRTJv5g8p+dw=; b=apDH8bwjFzAyvb0ZkKT6cLg9ft1bqpd5FaIZSKai7eg+OifUB+fY0bKcFMvtc7/TbC /Vzw9HxuRU+CrAGDuDxCIgBUsy641yn2TECo3WLoyPqgvrm7ixehHRRrzvJoxjRKatQr 3r4aUFzHhut3f3qKa5FTQofWS8V32EEPYNI4EQ9G2x72Kug8THXvdGwYSXDJlo5MH5MA +am/nI1bGIUdSS6r0s5hLmDuVdtaZpEaBELemsWmLHjtFHWxfgxq83Pgw65fnIDakx3o PCOBvYSghn20o1qTLVag/GXkXQG9rz4wcXZY211W2ExKmU8XVTfFsVuWs0y8lHDJAkbE uPAw== X-Forwarded-Encrypted: i=1; AHgh+Rorc94eE4Tr6e4jWI/CxI7vSEqILapYwvgm/1arEA6K+oe7zTPbYCXw8BaBlASLJ80zhRbHXF7P3i06fvA=@vger.kernel.org X-Gm-Message-State: AOJu0YyWpWmdSOtZDQIIODTLaEAE6P/+qH4gRG+Ol9D+xqzkVkm3S5XY pwzCCSyoEYGEvBe52xlHs22gZdCMCWybdIGRNV7EJpkVtoE+7rGybTI= X-Gm-Gg: AR+sD10FdDBw+nMsECKp0MCzU+PFJQZqJxBwKO5ZjyqlZaFqiAPVugUUAeeGnbKP01/ 69gOQ42qiGVePHERgxHJfMvZrz6eLdmvMUdFeCwgJKs6XkOh6sr46TUnShpq+RDe/Wfn9SlSfpd y2dm1GvJT1HmTZJIN6m/RyEcS4OECE8NF7WQNaVN4+m3JqjVs7EUqTBYH8eAUCClrRJwTjRLxAH QOfnUQLGlYFkTzUWSXlBfLQxN5lmq+NOmkCuYoetcN1IwF2lz9aehB5JQfCfKM4rNnbM8YoZ62M 4ieA/Ob2cveggWNpQAKw+EnGEvv9K2sS4dIkzjXCYfHvJF7ROpTaTzsEbeahIOIEgHSLnVyjdKH d7QkS809lv+575wy8T5VgelaeAPIv0/iClrdHvR+AKDuco5au6i91yDDZS5v8CD+Txdns9esB0A cZUVU8TpWIrUjDBheocJPL/855j+w8nQvwCSUeFW+9Ep6N7f1PiN8FTTyC1eg= X-Received: by 2002:a17:90b:3841:b0:380:f34a:6ff1 with SMTP id 98e67ed59e1d1-3933b9483c7mr24865790a91.17.1787027031651; Mon, 17 Aug 2026 21:23:51 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3954d3d2adcsm4439463a91.17.2026.08.17.21.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 21:23:51 -0700 (PDT) From: Triet Hoang To: triet.hoang.dev@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, markus.elfring@web.de, ogabbay@kernel.org, royalnet026@gmail.com, tomeu@tomeuvizoso.net Subject: Re: [PATCH v5] drm/rocket: Check allocations before use Date: Tue, 18 Aug 2026 11:23:48 +0700 Message-ID: <20260818042348.1584358-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260818041505.1579320-2-triet.hoang.dev@gmail.com> References: <20260818041505.1579320-2-triet.hoang.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Everyone, Thanks for the detailed review. This is my first time contributing to the kernel and using the mailing list, so I really appreciate your feedback. The thread has become quite long, so I'll leave it here for now and wait for feedback from Tomeu before making further changes. > I have not run your patch, so no tag from me. If it would help, I can > test it on RK3588 with three cores and again with two of them unbound, > and check the single-core case with kmemleak. I don't have the hardware to test these cases myself, so it would be very helpful if you could run the patch (v5) and share any feedback. It would also help me better understand the behavior of the driver and the testing process. Thanks again for taking the time to review and test it. Regards, Triet