From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0673238330C for ; Tue, 18 Aug 2026 07:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787036436; cv=none; b=h6uarCGK5O1Jac76a0mA5WeB3UcX3Lbq/s+BTNfuxXADZLoX7sKIzaZM7IELZPz7CaA1UrJXaIOH4/++FtK+tRL793WTRisW8z8DgsB2G+RHLxGQZ3DdEXTJ8edMsb13XVvegZ64eADtJqfKlSs1jjsDFwkCwS/+2rj8DCuXiZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787036436; c=relaxed/simple; bh=RmPMf2iX9Bi2ScNYsp8JG1JZjtJHkkgj20FjkZIt+uw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IhqrIcyVd97osfSl3WMFuW0J+kObg2yn8rXAceGFAnfpDEKmWXphTIW4TPM0flITCdyADkj+fhNEjQT0CRVAsby8+HzeWg5gpqHLERFnZrkzKUtXKL7GwdCBO+zd/GPRVWNLou94qcsqt38vuWZCsHsckM7UdGC56KnPbDj/SUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e99rpUfO; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e99rpUfO" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2d560775ca2so21015805ad.1 for ; Tue, 18 Aug 2026 00:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787036430; x=1787641230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=R7tQNnTq6jHzOznuQxy1ZNm9UkJ7DFP3G0U0MlM8C7U=; b=e99rpUfOHI4h53KRH1lGv9I6gMv3e7ti1vG2sm/Ue5d49jwODVdNjjLiIDNQEnLkAL nJJntmE5wIgt0ZnFF4/sD2HerAfdTrVkRp4HBxp7y+t3W3xv9ASR6ieXCI0sbpzYDcYn iUdkiKRWI3uIZsa1uhJhqBlG5nW/i5KuSgjzQ639zRrWCjQqyNZLhNXzdH0MAnvI4YK2 m7HX17jrugpLJNM72GY5hjrRwB9aXJ7u5rqxXYSUn/MVtwLPsbcphh21OFrXsaX2Cu6n u/y0zrm0mNhKnrSuk1ic5SeImpCi+i5id0OYsyzL2dy3LI+19mtk/5fw9EH8L6043Esb RstQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787036430; x=1787641230; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R7tQNnTq6jHzOznuQxy1ZNm9UkJ7DFP3G0U0MlM8C7U=; b=BewqshYxVRGJopZCwmRH9wymyHlCPpG0PP0sd6dN1+z2le1SEXd0+1RNd0aQLT7OSU l2xapuwqmy39ySx3hO7oVZDJGgS487/fLIVR39RCtjX7eqgXDeHBlv3AntWwFgPIBuhD ss8LjxKIuiXBJHBuGRix8UDTdt2ELNradw/VkBQFzJ0F5aW25iYymSw9O1TfJ4Ubo3jd 7k+unUPsCCCjBGXNUBB3SHiTJ+IjHocIw1z+/SsbQfXcLj/O3DTjEidk4dbKP4yP250D gzMARrT/TVgV9/ZU2QchRpttqthe694XXKcqcp0bqiKOXGn3LJd2BuQBCtHKzvJT3Xsj qXlA== X-Forwarded-Encrypted: i=1; AHgh+RqkbNm+eIYzIl0FFS6HxmrJCaIl4peVOhPcXxmM99v9Bpku6FU9r929Wt0OyHH7EV0ZBWVg70HhzQ8zgv4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+QN3xIiHRLntZTImxpNlT6LK6buAHTiskxlFvBVZc8hIefBE2 zyJUc4uCTNbjPPmfh293Lu8n5+nXAyymRaLJl77/t/BnYikqHs/2jzg= X-Gm-Gg: AR+sD11gx8EO6HQJqdREC9LTVLGIm1+qBe5hpC2v0JoZGwAn9f1QbuqC5gBqAIYDVwj BWxvh+y/Qes3xU+9LEFVU9sTAGzyInSrJSiGvH0u7U/ps5dFzup10ARa0XZ/wpafrbkJJZRlMPk kiaUVAu9gYKS1GonXOs9iBABnKYVqd8yr6SsHXM509QSiR6I0F2r9ZkVpjsydkA8jzcoqsjP/YM 56+zCbM/eozehs5qFl6sH8PdciNZmI51tbTBPj2ELWHPhXFw1xqgVSz/Qn1ZnD1kQdX3AU8O4wB zPMyUIjxkUNxZ/xxisAs1ev67vlA6+frAQHYeRS4/x801/ok63UD6MAPSwsZu0vyQOlAba/9thg SaokeVSOzUotmx1HlD1TbIpglo80PlOsJhrkr8YPo/driY2f1PHWe2UvZzdA+CBqgd9fdSFLro6 wggJfgs3r4LFLmRKQCQj+foWOdX6PVjIsqhs8R6oSTuEdf+Y2ufNAKrmcivdL5/O6qhKcZHus03 A== X-Received: by 2002:a17:903:2312:b0:2ca:ec6f:aeca with SMTP id d9443c01a7336-2d3b0dbbf0cmr317491465ad.8.1787036430183; Tue, 18 Aug 2026 00:00:30 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1ed8b3esm10804285ad.73.2026.08.18.00.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 00:00:29 -0700 (PDT) From: Triet Hoang To: hca@linux.ibm.com Cc: gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH] s390: raw3270: Handle allocation failures Date: Tue, 18 Aug 2026 14:00:23 +0700 Message-ID: <20260818070023.1654606-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the return values of kzalloc_obj() and kzalloc() before using the allocated memory. Free the allocated resources on subsequent initialization failures to avoid leaking memory. Signed-off-by: Triet Hoang --- drivers/s390/char/raw3270.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c index aa9c4d81225c..69e0f69a3e14 100644 --- a/drivers/s390/char/raw3270.c +++ b/drivers/s390/char/raw3270.c @@ -814,15 +814,26 @@ struct raw3270 __init *raw3270_setup_console(void) return ERR_CAST(cdev); rp = kzalloc_obj(*rp, GFP_KERNEL | GFP_DMA); + if (!rp) + return ERR_PTR(-ENOMEM); ascebc = kzalloc(256, GFP_KERNEL); + if (!ascebc) { + kfree(rp); + return ERR_PTR(-ENOMEM); + } rc = raw3270_setup_device(cdev, rp, ascebc); - if (rc) + if (rc) { + kfree(rp->ascebc); + kfree(rp); return ERR_PTR(rc); + } set_bit(RAW3270_FLAGS_CONSOLE, &rp->flags); rc = ccw_device_enable_console(cdev); if (rc) { ccw_device_destroy_console(cdev); + kfree(rp->ascebc); + kfree(rp); return ERR_PTR(rc); } -- 2.53.0