From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C124939A7EF for ; Tue, 18 Aug 2026 08:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787041444; cv=none; b=MAhC/jURoqrdqavw6rxZn3o3laEb5mXLhX03Vfz/ZzPXKMf0O7sQ7gHoXN9pMug7BDZkct/EkVIElxYFQgZugCuGoqVtT2IGoNKDZ5kDfmYhEyi82NcU6Ddk7JE4O6Hy0NeMMHgWedGnK30zi09aQ8BDDPAZyKb+ejGznI35f/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787041444; c=relaxed/simple; bh=TZ2WfPOcZNh60X/5u88ayyjzkA7MyHMs1n470xQcN/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AoToB36gPHVbL8K4EkBL44pmlmV5zEjju0vCQUlxY6XbayI2k1bkjYDtgS6ZeCvxKBvIHwsiKs2Ugh7RyacesBrfgVE1DWcvVBWHe58exPIFT3HATKECcbqk38P0H+Q2VxpWzAhlCH2GCV5r74U/zKs0FFmfw4tD545Z0HUeEIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DjNqLRjk; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DjNqLRjk" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47fe2d179e2so2838891f8f.1 for ; Tue, 18 Aug 2026 01:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787041441; x=1787646241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TZ2WfPOcZNh60X/5u88ayyjzkA7MyHMs1n470xQcN/s=; b=DjNqLRjk/79/uL6ZFtf+TTalXSYH6EOASw9xa+lCZfg/vbfMx/dKA+vVuZV24/ySzx Wdoq8po+ON2k4lERg6eRK523D6ujr1UWYkuosOqZRoioYNHsyVQBN7/lHcUEY4SElNGY 7okdrC1Iqn6d8X/5bnHoo+QRO/he5qSEwzN84O+UF9LCJe7ZOH6qPOEf5x/sRHazUL9e qpKGg08SnNH6OodUJjhkoiTaFi8P5p4COISmiSMOMhP9jGwBMxxAIiZWX5Bx4Te8ol67 CN38MrYQ3jOW9pqw1rgp3GzYCBE0azMcI7bqovOtZGS4s9jBaAo24BXlv1jF1HrLik1o MOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787041441; x=1787646241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TZ2WfPOcZNh60X/5u88ayyjzkA7MyHMs1n470xQcN/s=; b=DJ2+eyXhdGSBpQHhUOzgEUwD/Zghsys9FSBP/Xf0wLIelAIrl+H5o+ZOcLl2ZAhtWX Pj+BweDfmSVq2n7UaENV5MUtiwyWkxxrpY9dZRWZ0lAwGXjdtjLpEfZB4RgiW7khcEem 5Zeysy8eXCjKorvLbFTaWVy24k8guKRyAs3RM/s/jh7ruqyej3moUnoW+2vgppTbHd/1 aqRVNrrp0TZupg8tqQjr6PhjL7IEW3XQmp9prZB5PcLIzjwrvXdmIHBI81xLs856e8jC 1fEDKC6gCPSFCvB2jaKCS8l5Gm36IivE4Ii5L4pIjuTbFLf34lgMq6o/+KTMUjhJ4d7t XGRw== X-Forwarded-Encrypted: i=1; AHgh+RoBoJMms4bR3JWadb+I9bCrNZB7U3t2yBTP5AknKHGES0WvGmO36AXXLKwj5a/2zXK5MD7IPRMKbBWrQ1s=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwddt5qhHC3PCGmNrnoa57z3uLTjBJNdHVDSML5duzVasRrfRg FVjYp7UKqXOUdPOwmhm1IH/kW07QuhcIqK6JlsBz/+3RXtWAyXuRegAY X-Gm-Gg: AR+sD10MGfvXBmrbILvd8rB4TYvhiIjTSmfEd0uoDvgn7/8HCOGWpBNsoFZzl0G5HLt a98LOgDCpWpmt8Qkw0d0+wf1QdKfVVinv76NFowHDLllgucdo3paOr++EFGyLr22xFLr1IW9X6M qAxvHaGqfdaC+6K4WvJ4oPFHRpQ69wSMrzr4qrlRGnho7EVrAvx14M0T1GL2tIh84AbZlnhmOCI P5Pd4X5lYs0qA/1AjyB4gCEnkDLS2YXkVgcWJ0ZYTVBDRdxr1/XkH3Q/OMcW3SE6BWB43Khw9Ev BrFRMGnAfg1PBU11WvAKU9qW+74edSDsssB8ELRKBb1O+dshf3qvEJPXrXF4gCZVk8nhtx2/YNI r1+3qqkWJQRJOMUiVdcToIMIEEMEZj3pMSFD4eYIwsaFhxbkA9oBZ+uNoUkcqwDdYWMn4iEXe93 TpGVvXW6NOWRa1edhDAzMR/x8AIEDFDoFr4H2BeqFI7Hiif6Jxft0iB1BSt8MfiSqxuhoH8KwVw yEmnNvqtRoQ X-Received: by 2002:a05:600c:3b1d:b0:499:79b9:e226 with SMTP id 5b1f17b1804b1-49988057986mr474592265e9.0.1787041440924; Tue, 18 Aug 2026 01:24:00 -0700 (PDT) Received: from fedora ([105.71.134.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999d10be27sm138748235e9.14.2026.08.18.01.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:24:00 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: andriy.shevchenko@intel.com Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com, andy@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, jic23@kernel.org, krzk+dt@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@analog.com, nuno.sa@analog.com, robh@kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH v4 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Date: Tue, 18 Aug 2026 04:23:47 -0400 Message-ID: <20260818082347.13382-1-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Aug 18, 2026 at 06:30:00AM +0300, Andy Shevchenko wrote: > We do not need a Dostoevsky novel in the commit message. Please, make > it straight to the point. Don't blindly use AI, you should understand > what the code is doing. Same comment to all commit messages in the > series. Understood, will trim all commit messages in v5. My workflow is to draft the messages myself then use AI to check clarity and kernel mailing list conventions. I'll make sure that doesn't result in over-explained prose going forward. > So, the change from 1000 to MILLI is in the line that is changed > again in this patch. So, no need to change it earlier. And again, it > should be (MICRO / MILLI). I started the code with a bare / 1000, then replaced it with MILLI thinking it was the more readable form. I wasn't aware of the (MICRO / MILLI) idiom for expressing unit conversions explicitly. Will fix in v5 and drop the intermediate change from patch 5. Best Regards, Taha Ed-dafili