From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FAA411F8D for ; Tue, 18 Aug 2026 08:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040477; cv=none; b=To0JG//7DU2W5RRLUkPulpH/yBTB69/7XPsYbBxv/yDmmY0btLjBEGnlhO1fd1J5+VG3U+f6WZ9cn6LtWO+S0Hns3OIpM0zG+xC30WjUNOS0SorAPeHk7NSAvImuG+BldCcnuJAaJbQUVGcgp5jFMyHaXxy51cDE9aWb5+MGFLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040477; c=relaxed/simple; bh=oJCfBaTSQIZpbF5vKTY33JS5U9keEEdkATL/oBuYNMg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J2Hk0Pnp0nAm0hyP7uqqbGSXu/41ua6H+I0tDHF75wqXEUffQuNS3IfRHPIim0GyaKGYssrf8fD3LCEmzVrviyojubt9bvPJWtnSU6bjLsus3vkBhVOGGZWRXc6pGkAi1CnzxgTJCDgQZvDcH+XzBEoGTun9cjow+XQwqriji2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iOFXkQLi; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iOFXkQLi" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47de0093c42so3762974f8f.3 for ; Tue, 18 Aug 2026 01:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040472; x=1787645272; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=yEoq8vSuunfu8k8FBwHonNB2QsdVF14waMnkaLWtmh8=; b=iOFXkQLiGSJThQ4n/lXeCRvt5WssWFtxW5WGC4nkaB90+yfbSkcP7xO2xlAOImEFuq WjK36ajyxv4WdBTOFJ6/+6i4CuPxJHdl+0GY3r+76mslasy/kgYyaZWSTtLaBylFz4dr xkw8fisGt4R++YpWThxQs4rpX2KZ/23Adc1EezYzqOkdCxIr4J7Qh78i6G4l8iBAjvD/ BmPEH7NKHgLem92Pp4+Z1LGPIqhYDON/jh9V1DNM1cPTKoZ/L/+mvj/AoPetHwODrOb2 L9lXg2SyIGwRQLwbsCOZMzfTZ232oL8Zo2uonJUyTL5f2tDBUw4vt4nmVRLy/9XGdpJa T8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040472; x=1787645272; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yEoq8vSuunfu8k8FBwHonNB2QsdVF14waMnkaLWtmh8=; b=Il0S35mP1RPqcyi2r0OqY17WhudnIs/tfzoKuk9j8vphl4bz8X7aMkKk0i3jDuamHx yH1QcLk+hxPPaGi5G0IY1xoDpzlCRA6HRcgNQKf5gD+T5AX1Ogu9V96h/oVbTAMXGW3A OcbUit5nX5KSRtH125dbww74IqUAssXWAVLomBK9HRN6cpvohDkrvqdJkwoZtcQ+qvQF 8bMZPojxm7bVLawXkSD0co8hTWolvE0gCD66akbCrhGMavDdWHhy0NMpqbs1OVC0OooB iCnhLrH3faWHIfJZfLgVMjHkHm/ykTmNeeSVUTN3u468ZUX8/az4JvnQOF7BsPm/6wOt mUXQ== X-Forwarded-Encrypted: i=1; AHgh+RqHBfSI95wqENkOPok3FswIP2ypxr3Nry99x93W7HsQEb1uhANVq758AdeOXGJ0+a+ThrJPn4DGWOjSAlI=@vger.kernel.org X-Gm-Message-State: AOJu0YxNVmWFwv8nExex0Zy9DyjwMtGsMPPJyL16A8YRAiiAS5QRRI3X gW2sPfv9xfZfd5AY9LdnZTm/szVuYMg/pxOOHgSKzPUS7suiy+4QCLy8 X-Gm-Gg: AR+sD10T9rmh0XmUw03ITEgcYkdxhC+dIUzeVRcNYeUHZ+DN7xuNC3EJqkDlumBUSg8 4AXXofjy5QG9oc/SQfupMFd17datDYJYnCtrC3Y5iWS/Y8Ju/pJNt5DH8GS15cWFRa+QLAnVeFt Vc0V3ereJTnNHzCrDmBOWQVf5p23iFNgT24Z0NUVjqUxFJxGwpL1O4oh+qRF8uRGghjBBFVEH2m mg1lg7XldeLIiXOAYhJzMYQqpT6hTsjNXCl9ofsVgOc3qz/EW9ya6v56AjRksBtVIZEs+PS+pxc QV6YMpRHAkze4ZwDl1FT1E2Hn27/+9qThB4w55zUtRV/TxvrMfTMC6wSZjBFbOV8rn2Snte4kRP HFcGRcQXiTBBS0znOWgZ2PUQ5nql01+D7z541l4W7rzMdwFXeq/f7JJDuPccMc5H5SQt+Njq2Qf +pNDj+N2bmop37IyJTw8TX07sgzC6iP+6dKq+80nn2st3oP0GoGB216xflAHP+9udnDEf4CE9CS RltBJeCwk/Bbt4xCsk202QYrQ== X-Received: by 2002:adf:e19d:0:b0:47f:fb2e:f63d with SMTP id ffacd0b85a97d-48160715bf8mr52897928f8f.9.1787040471784; Tue, 18 Aug 2026 01:07:51 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b81748sm10126955f8f.37.2026.08.18.01.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:07:50 -0700 (PDT) Date: Tue, 18 Aug 2026 09:07:49 +0100 From: David Laight To: Linkai Gong Cc: Greg Kroah-Hartman , Michael Zimmermann , Peter Korsgaard , Christophe JAILLET , John Keeping , William Wu , Marco Crivellari , Ethan Tidmore , Kees Cook , Chris Wulff , David Sands , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_hid: drop ERROR() on copy_from_user() failure Message-ID: <20260818090749.3fa0ea61@pumpkin> In-Reply-To: <20260818012118.3903388-1-gonglinkai@kylinos.cn> References: <20260817154604.70427ed1@pumpkin> <20260818012118.3903388-1-gonglinkai@kylinos.cn> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Aug 2026 09:21:18 +0800 Linkai Gong wrote: > A failed copy_from_user() is a userspace error and should not spam the > kernel log. Just free the temporary entry and return. > > Suggested-by: David Laight > Signed-off-by: Linkai Gong > --- > drivers/usb/gadget/function/f_hid.c | 1 - > 1 file changed, 1 deletion(-) > diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c > index 3c6b43d06a6d..5c39da1ac7a6 100644 > --- a/drivers/usb/gadget/function/f_hid.c > +++ b/drivers/usb/gadget/function/f_hid.c > @@ -656,7 +656,6 @@ static int f_hidg_get_report(struct file *file, struct usb_hidg_report __user *b > > if (copy_from_user(&entry->report_data, buffer, > sizeof(struct usb_hidg_report))) { > - ERROR(cdev, "copy_from_user error\n"); > kfree(entry); > return -EINVAL; This should be -EFAULT. David > }