From: Peter Zijlstra <peterz@infradead.org>
To: Szabina Korbai <szkorbai@linux.ibm.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>,
mingo@kernel.org, longman@redhat.com, chenridong@huaweicloud.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
jstultz@google.com, qyousef@layalina.io, euan@linux.ibm.com,
huschle@linux.ibm.com
Subject: Re: [PATCH v3 0/7] sched: Flatten the pick
Date: Tue, 18 Aug 2026 11:16:49 +0200 [thread overview]
Message-ID: <20260818091649.GC1247881@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ef9f077a6faafc747b3e144400dd3f5ad10e8e0a.camel@linux.ibm.com>
On Tue, Aug 18, 2026 at 10:04:57AM +0100, Szabina Korbai wrote:
> On Mon, 2026-08-17 at 22:05 +0530, K Prateek Nayak wrote:
> > Hello Szabina,
> >
> > On 8/17/2026 9:35 PM, Szabina Korbai wrote:
> > > Hello Peter,
> > >
> > > We ran the same benchmarks (schbench, sysbench, hackbench) as
> > > Shubhang
> > > has on s390 on an LPAR running fedora 43 with 32 vCPUs.
> > >
> > > We ran the benchmarks for each of the cgroup modes, and for the
> > > baseline, we chose the commit prior to the patches (f666241e6bd5 -
> > > sched/fair: Unify cfs_rq throttling via account_cfs_rq_runtime() ).
> > >
> > > We have also tried running stress-ng in parallel with the
> > > benchmarks
> > > (set to generate 50% or 90% utilization for each vCPU).
> > >
> > > Compared to simply running the benchmarks on their own, this has
> > > revealed some performance trade-offs that the move to a single
> > > runqueue
> > > can introduce.
> >
> > Are you using tip:sched/core at commit 68e3748781 ("sched/fair: Fix
> > flat
> > hierarchy") for the flat_cg numbers or did you checkout at
> > 85570f10a4c6
> > ("sched/eevdf: Move to a single runqueue")?
> >
> > There are a couple fixes for vruntime update and Vincent's
> > optimizations
> > for preemption bits which might make a difference to the overall
> > results.
>
>
> Hi Prateek,
>
> thank you, that's a good call. I did checkout at "Move to a single
> runqueue". Let me try it with the fix included, see how the results are
> affected.
I've not yet managed to digest your various benchmark results, but also
double check that patch 6/7 from this series is not to 'blame' for the
some of the changes.
The 0day robot fingered that patch for at least one issue.
In that case the benchmark threads ended up 'heavier' than before, which
resulted in less preemptions. Probably ksoftirqd getting ran less and
causing a regression in network throughput for that thing.
I did suggest trying to change the slice of ksoftirqd down, such that it
might be ran more readily, but I'm not sure that ever got tried.
prev parent reply other threads:[~2026-08-18 9:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 12:40 Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 1/7] sched/fair: Add cgroup_mode switch Peter Zijlstra
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 2/7] sched/fair: Add cgroup_mode: up Peter Zijlstra
2026-06-05 15:07 ` Peter Zijlstra
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 3/7] sched/fair: Add cgroup_mode: max Peter Zijlstra
2026-06-10 15:09 ` Waiman Long
2026-06-10 15:42 ` Waiman Long
2026-06-11 13:49 ` Peter Zijlstra
2026-06-11 13:47 ` Peter Zijlstra
2026-06-11 20:57 ` Waiman Long
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 4/7] sched/fair: Add cgroup_mode: concur Peter Zijlstra
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 5/7] sched/fair: Add cgroup_mode: tasks Peter Zijlstra
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 6/7] sched/fair: Change the default cgroup_mode to concur Peter Zijlstra
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2026-06-05 12:40 ` [PATCH v3 7/7] sched/eevdf: Move to a single runqueue Peter Zijlstra
2026-06-20 3:54 ` Chen, Yu C
2026-06-26 11:40 ` Peter Zijlstra
2026-06-29 14:02 ` Vincent Guittot
2026-06-30 9:03 ` [tip: sched/core] sched/fair: Fix overflow in update_tg_cfs_runnable() tip-bot2 for Chen, Yu C
2026-06-30 9:03 ` [tip: sched/core] sched/eevdf: Move to a single runqueue tip-bot2 for Peter Zijlstra (Intel)
2026-06-09 5:37 ` [PATCH v3 0/7] sched: Flatten the pick K Prateek Nayak
2026-06-12 2:29 ` Shubhang Kaushik
2026-08-17 16:05 ` Szabina Korbai
2026-08-17 16:35 ` K Prateek Nayak
2026-08-18 9:04 ` Szabina Korbai
2026-08-18 9:16 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818091649.GC1247881@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huaweicloud.com \
--cc=dietmar.eggemann@arm.com \
--cc=euan@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=huschle@linux.ibm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mkoutny@suse.com \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=szkorbai@linux.ibm.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®