mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Natasha Klaus <natalie.klaus@runtimeverification.com>
To: ribalda@chromium.org, noambs2999@gmail.com
Cc: laurent.pinchart@ideasonboard.com, hansg@kernel.org,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Skip frame descriptors with a zero computed size
Date: Tue, 18 Aug 2026 12:40:10 +0300	[thread overview]
Message-ID: <20260818094010.353021-1-natalie.klaus@runtimeverification.com> (raw)
In-Reply-To: <CANiDSCue8yyiGubzbAybRqSUTTFuB=-Y2TZy6yvOx32SpAASWg@mail.gmail.com>

On Tue, Aug 18, 2026, Ricardo Ribalda wrote:
> I think we need to have some consistency. We cannot have  one
> condition returning -EINVAL and the other skipping it.

Agreed, and your shape is cleaner than mine.

> If Noam is okay with this, perhaps Natasha could prepare a patchset
> with the 3 patches? (keeping Noams author on his patch)

Happy to. Noam, are you okay with me carrying your patch in a series?

One question on placement before I write it. Your comment puts the checks after
the frame interval parsing, which is outside the !UVC_FMT_FLAG_COMPRESSED
branch. Frame based formats legitimately carry a zero
dwMaxVideoFrameBufferSize, set unconditionally at uvc_driver.c:265 because the
frame based frame descriptor has no such field, so a zero check there would skip
every frame of a conformant frame based device. Did you mean the checks stay
inside the branch with only the return value changing to -EINVAL, or outside
with an explicit frame based exemption?

I will test the refactor before sending.

The Media CI failure on my patch is the missing dependency on Noam's v2. The
series fixes that.

Natasha

  reply	other threads:[~2026-08-18  9:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 10:14 [PATCH] media: uvcvideo: Fix integer overflow in frame buffer size calculation Noam Ben Shimon
2026-08-10 14:12 ` Ricardo Ribalda
2026-08-12 10:32 ` [PATCH v2] " Noam Ben Shimon
2026-08-18  6:45   ` Natasha Klaus
2026-08-18  6:54     ` Ricardo Ribalda
2026-08-18  6:57       ` Ricardo Ribalda
2026-08-20  9:53     ` Noam Ben
2026-08-18  7:59   ` [PATCH] media: uvcvideo: Skip frame descriptors with a zero computed size Natasha Klaus
2026-08-18  8:31     ` Ricardo Ribalda
2026-08-18  9:40       ` Natasha Klaus [this message]
2026-08-18  9:53         ` Natasha Klaus
2026-08-18 10:18         ` Ricardo Ribalda
2026-08-20  9:43         ` Noam Ben
2026-08-18 10:32       ` Natasha Klaus
2026-08-18 10:40         ` Ricardo Ribalda
2026-08-18  8:28 ` [PATCH] media: uvcvideo: Fix integer overflow in frame buffer size calculation David Laight
2026-08-20  9:13   ` Natasha Klaus
2026-08-20 10:31     ` David Laight
2026-08-20 10:01   ` Noam Ben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818094010.353021-1-natalie.klaus@runtimeverification.com \
    --to=natalie.klaus@runtimeverification.com \
    --cc=hansg@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=noambs2999@gmail.com \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®