From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 528014483A1 for ; Tue, 18 Aug 2026 09:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787046569; cv=none; b=FA+jg7mKBstf0ixhAsKwTldQWPNkp6afFv4esY6vyHqx4NQc7vP6m4NqYq3eYstRzIleH3EgOIoEi/EJkZMkqjksAbw0xfSzaF+lku8joxMixApKbHzFrZM71L0kO/Ug6qYb+N262TmFhXhOsCDFPb431Z+5jkXHfHGhFsyx+TE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787046569; c=relaxed/simple; bh=x+hUVSpLmnGOBRbrUs8t/YAarM8tfurNyZaOcnSMAtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qDPSVb+kASbWMYDv//5jXQH1QggSHAt61POVyt2lZnEkfbUlyXT4L0A3qCkYvBtJcFQSUYRxjrWKWFWxmqz1ZmgmTCQwZO3xhK9GXKoc8bYnQohHmlsFKtFXUF9RUNj7gTR897Am8JSb9C9G++PefDq2MYK81zC3/ifM16xyyu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ig3oTXHF; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ig3oTXHF" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8486ac3f347so773142b3a.1 for ; Tue, 18 Aug 2026 02:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787046568; x=1787651368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NVZqfaL1cDu6QLngalu7WE4kGe47MKpcY+uRtreSbGM=; b=Ig3oTXHFnuk+O/rPOeaLzDl+jyEagcFcJxOiOmB8kHgos0tZrh4g+TCVtc+BWfHDLo wKZcM/K98SvKWpkUJ1gOa/cV/Ud5X/2/AKieyZdkoXVzepfiN/VaJVeKvJqrmcQnygXT abSB1bsAT6kgsBmvKUaiSX+lSS2boh31n5tzXR7i6xId4s8kbPJd4U/ggD1EKlM51XD7 xBuA+6LAxr90IWswayf0RPGRgo+HSPmZGhq3bMUJ4zu8sMFsED+9p/ZAZPJdejNN04om o8OzNA3Pjm45VRjM676u98/+6fsnR5grzG0DusVMkdr3brrz1uxFLNCOuMT43ipJP1Zi 4XrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787046568; x=1787651368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NVZqfaL1cDu6QLngalu7WE4kGe47MKpcY+uRtreSbGM=; b=Ya3DlvbPpJjttc7eG8w84CXj2ZVehDMMEMp6mgHtIGPSIM21ayju7QhKq+mPDCrZAH thVu71gFH1t7JCAY88FMzsRviGmsmbqByb0JMWkL2tzsB4QRibfgfPV6kbwKPfAx+t+B swkh34/PbxRcDFYs1sYMj6+X8MKTtxUMKhNFAOTmZhBrsEXbg0Jo3EvX8CjVJche9RxP X8HgqySzAXxfn8XCxsr2Z2+3H791F4/zeQa5VxPUgkRttZtHM4qYkdxB3S0fF9xfOmvt bYqajdznK05P0ir/geGGHF2Pi7FwP0yjowlnmu/L0pYEeHMRZGBFQe2eiQ37CBbPahnI KLjg== X-Forwarded-Encrypted: i=1; AHgh+Rrzsl27mpO0aQRiSJAMqYGNWj4CxuGtTj0bU/LwvOeGu1GYA8JIgJstCBBarJHsEV/t1bheiKHwXeA1jpY=@vger.kernel.org X-Gm-Message-State: AOJu0YywfymgZWmU1J4YewOB76zlqMrsE7CakbRVmKnORxDz9qJtF9E9 mCKEsaJSGdMfKiw1O5g0FWL9t1O3+8XCs/VBsti0hnos1piuOyMdeQmc X-Gm-Gg: AR+sD10Y5fdksNq5l1mDIyTme5D/V4QbAEZtACPiRH+xhXNhtOmgkptp3IBfSQ33h6I NM/bz0gTjGnf1wIcbEYdNz3T8asP5hu/+IeEqHZ3V1ZuEpj3IUq9F+KyMxm71j+yxbu30f46v1Q n+IVcf5HlWACZ5J+vZ/Q2+Jrls378m9cuXzf9dE2IdWp1Bx/Gp9uQlxqPph4vfWT9bXt6HTvN2s 2LS6z59pps6wGGae56KoR3T4PGF3MIuwkp+ZsvcPQug/8Ati9NT2c4Tzatn4vC5qxik53g/lUSx WGuethWt+rWoVnK6WsqZLWKESVE9URigDizAVegAeiuTJU8cvSNuHxzbD/oNZcaMKGirdQZ469f hoo5J0Z2j1b01d+Yj6VYmOgBaKuqyerhCmU03zpQDHuRsTRLSnqD5pg2/D1sxOzaLbyFZx7teoI ACznX9fKYoxa0OBNPYk5p/YNPq68G6BFLhETz7Q6anHN3AcBmyvEbroZgcUeXotfFnjll2Efntv ktF88+rV2WfHuPEscYIjIZGKfiTTkZigctznJH2Ezu7sNJ5I48P X-Received: by 2002:a05:6a00:10cf:b0:847:9dd7:2683 with SMTP id d2e1a72fcca58-851bc380e98mr4882490b3a.9.1787046567622; Tue, 18 Aug 2026 02:49:27 -0700 (PDT) Received: from secrnd-cstp.tailb7f510.ts.net ([125.131.91.97]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851b6f8b057sm1310191b3a.29.2026.08.18.02.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 02:49:26 -0700 (PDT) From: Sanghyun Park To: Leon Hwang Cc: Sanghyun Park , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Stanislav Fomichev , Pu Lehui , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2] bpf: Fix stack out-of-bounds write in cgroup link update Date: Tue, 18 Aug 2026 18:48:51 +0900 Message-ID: <20260818094851.2941245-2-sanghyun.park.cnu@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello Leon, Thanks for the review. > Seems not a good choice to use 'bool check_cap_net_admin' here. > > Better to factor out a helper to check CAP_NET_ADMIN first? I tried to minimize the code changes and avoid introducing another helper, but it seems that your approach is cleaner than this version. Let me try that way in v3, thanks!