From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B4939A7EF for ; Tue, 18 Aug 2026 09:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787046981; cv=none; b=FTpTcLQMSwW1XVcYzO1Xf789Dbilhtb+tHfQS+JFtCB/EuCqGjNeyz4fVwmzlzRNbpFjtmGeo5vSVZH7v22vUfmxjW69yp2U9PTeouJibsTQXsFXxjD6yGt34LJHAqM6ONcc7fYDG95P1IbxDHbnYrZu6Pbd5NFHPaWRIcCA1KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787046981; c=relaxed/simple; bh=Idl2H9MkBTY4cPiJmoVKjWFQWTntt995XDquH+MYN2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j7OTfx5/e44hj0fVy0w3XxJK85zhwZ+TupU626I62q8yTNgzUlYu/nC7SWHBibnGPwrbJoo0OArL6mMdAgSRCLHjSeTGRRRqfHunMBvZW5TMeriOyS8NBnv3nFTJI0C6I+VMGy3GYrvAudocwHAr3n++3Lscrguuh0qwKkMxQQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PQpzP0UM; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PQpzP0UM" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso5288135a91.2 for ; Tue, 18 Aug 2026 02:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787046979; x=1787651779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lrDhPkcegELEVtqOdzCVdMJZ0V+FN0J4cNM1n2gntOQ=; b=PQpzP0UM/3RnCnEE5UVMDhO3KdKKhUL5YCuVXO1gsD+dVv19zH9avlYqy+WRE5RZcx KkQ7ikIugnE1IsREgIXGo5M0XGxp/pbonngM8ujuVdFT/z2ZrWgWH+PPCBDwRQAVjlLD Mm3F4OsheS5EYWi0RSaGRtBxBROjWF3ElaxjQ6fOf99mN7ONL8sMqaPjuz6SSWg5hTDH 2QOvzfnXZbcA1vvlcdEmSPUMimETEX1N1AY4WjmVVqmkDbdX8a59aFcuFEhEga67rAD+ zzKUeOydCMiCwyYFj9JTqNJP77dcZD3glNQ0TnIjd2dPjH3XKpwOX3FPwcvJQHk8e93r Klwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787046979; x=1787651779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lrDhPkcegELEVtqOdzCVdMJZ0V+FN0J4cNM1n2gntOQ=; b=C1fbUuf3+9nj22JhPxhvRuvf1ofdVMPVo69e9hCRZW59/Hnc/L0hpahoLgTqJz1UrY YvLTKRtZ41Xktqg6O20Ar2Ffbchrq/XLkragQNdN/O3LUScFWn8GsYpsjIadPG3jz/V9 rvZvue8lQMW2mGEe/pxgp6AZPH2NHlahAK5H3dvmJ15Hus8Hzfia9kW+uouXb9+WrheL 7WRfzZMx4n9MwQFyACSIDOl8ZwxPWc2rIVLws9zKHIfQWBQ/xuC2qYQOwV5ckRlJwRaN h8FpWfZ+ytzVf9H6r0Wdjx4T9fmEYsxlMklRD4mS8vJwpeiye1vseUd+aduE5lkTeWcV Qd5Q== X-Forwarded-Encrypted: i=1; AHgh+RqBhV+MEQWUnO8OBHCES0GfmfqROX0bLigwW9sUXPZBK4QfeQLM3qeyi6XBpfMO1oHwvNUHMp9w6w1cdno=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0LrxBex4FN2qlIEco94fJn3B7xX/6Q3gvasAFBtSLaNrnZ2lU RnLJ677qH/APUi6QYWQ8guxfbdr8ZlgOHCIWi2XP/RCBreOBoWf1LxNJ X-Gm-Gg: AR+sD13nXuxfxvv6B8JhmVSnBojTzi70c5WQk8ZdyoraKUup8Kk2rhNj2w6cYP7LVBa 8dLvInA1H7+Ck22R9U+PNtWQNo/loSGB83k3MvTmFFlyrFoOTbKEdK4ZFi3UfQem2Q542s4PGjm uvdOWsMBvrot2hClg9qEoXvOP9Js+cpNQ6ydZcBvMweud+SFTEpz9npNtcKCiF4suANUFjJfP7Z 9+adcXppcvBGcgH8JmSowLNKCmFTs/1U8eoFon4x4zeKGu/5gewrHSaXWxx3IV3+UJT/WpbEXE2 x/pwQgXRdYHX704Q1q2ZZ2QqdJWfh69TpHNYoYRhTXVWykHAwEb7wdbMuqT6j6IpH6hSjAJsDn0 /OGETzB1GsocpVBQVuEhNbhz90CwKAuZKLosI0mC8/s3+2vgAnLCYqA2vlCYaYPLMRGvXzhKXMI CGt2PFt57H9DrstQwMBpKCsmbp/sdPH+AHXb8eqyFpDlpVTP0Zn0Qz4l8Bn44yFyKu4TI7REELD O2hQqoOLT4S2zFtACIL+ElVRBg= X-Received: by 2002:a17:90b:48c1:b0:38e:2517:5d1f with SMTP id 98e67ed59e1d1-3933b792c20mr37888076a91.9.1787046979310; Tue, 18 Aug 2026 02:56:19 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1415305a0afsm22096004c88.4.2026.08.18.02.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 02:56:18 -0700 (PDT) From: Malathi A To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Malathi A Subject: [PATCH v2 2/2] staging: rtl8723bs: remove unusual 'NDIS_802_11_RATES_EX' type Date: Tue, 18 Aug 2026 09:55:35 +0000 Message-ID: <20260818095535.1230025-2-malathi.a2000@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260818095535.1230025-1-malathi.a2000@gmail.com> References: <20260818095535.1230025-1-malathi.a2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the 'NDIS_802_11_RATES_EX' type and replace the variables of this type with an array of 'u8', which makes the code more understandable and gets rid of an unnecessary 'typedef'. 'u8' and the 'unsigned char' the typedef expanded to are the same type and the array length is unchanged, so there is no functional change. Also update the comment in wlan_bssdef.h that referred to the removed type. Signed-off-by: Malathi A --- v2: - Rebase onto staging-next. v1 was based on Linus' tree and did not apply, as staging-next already reworks wlan_bssdef.h. - Use my full name in From: and Signed-off-by:. --- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/include/wlan_bssdef.h | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index 179fae4d8fcc..deeaa9e46086 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -253,7 +253,7 @@ struct FW_Sta_Info { u32 status; u32 rx_pkt; u32 retry; - NDIS_802_11_RATES_EX SupportedRates; + u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX]; }; /* diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h index ff2cee2f3b99..9137057726ef 100644 --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h @@ -14,8 +14,6 @@ #define NDIS_802_11_LENGTH_SSID 32 #define NDIS_802_11_LENGTH_RATES_EX 16 -typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */ - struct ndis_802_11_ssid { u32 ssid_length; u8 ssid[32]; @@ -48,7 +46,7 @@ struct ndis_80211_var_ie { * ETH_ALEN + 2 + * sizeof (struct ndis_802_11_ssid) + sizeof (u32) + * sizeof (long) + - * sizeof (struct ndis_802_11_conf) + sizeof (NDIS_802_11_RATES_EX) + ie_length + * sizeof (struct ndis_802_11_conf) + NDIS_802_11_LENGTH_RATES_EX + ie_length * * Except for ie_length, all other fields are fixed length. Therefore, we can * define a macro to present the partial sum. @@ -140,7 +138,7 @@ struct wlan_bssid_ex { long rssi;/* in dBM, raw data , get from PHY) */ struct ndis_802_11_conf configuration; enum nl80211_iftype infrastructure_mode; - NDIS_802_11_RATES_EX supported_rates; + u8 supported_rates[NDIS_802_11_LENGTH_RATES_EX]; struct wlan_phy_info phy_info; u32 ie_length; u8 ies[MAX_IE_SZ]; /* timestamp, beacon interval, and capability information) */ -- 2.43.0