From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FE14376A06 for ; Tue, 18 Aug 2026 10:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787049945; cv=none; b=fMy3zBpHmdjqtDzHx5o0JKxrGVimNm4XjyxUNwyYIJ6UzyMIl7i9ytRNCMh7vcVrMji0ovJZQNViczcVNQN7H4bmChi0UPLByQdLoPv/8hZ/qBFA9U6LuCHUMTmQydj57/vKv7dPscHW22t+vczpHSSHpN4LBxEHEwmYQ1XfoNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787049945; c=relaxed/simple; bh=7kMgdJJnXW0nxyAw/LvLUQIUX1u0Knq4v1TFxjDOceo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uclQafJN3fhOgoQxnTzltvFZmqVHoRTVod3v5oedED+wSIC/9OpDMrHxHQkmCSYQnBCuw6f3kcBnvbtW63qgNLsqlXDWkJjsszxHOWiNfeA+75GzmmPEQPr7os9jPuC3dhH6bGhf7WZr1CHepMPI3yxWf26JAw6YC/Fq++1NyNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bKaUk8US; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bKaUk8US" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38511175ad3so4365577a91.2 for ; Tue, 18 Aug 2026 03:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787049943; x=1787654743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=shmmSGcBhVr0mO/l9YtNu+PS04UbaQ1RsT84Z7QOJuU=; b=bKaUk8USVJcuOst+X558wMNcXzMMDHtKXeKkqGUo7yiP7JnxVqQZzinonbO0pk54Df GS6zKlm/UDARNBP+l5VpLJl5CYbDOX4MTRLnb3LrYjLf9QREjRvzBd6RCc4x1y0UhAd7 7mh0+0eW47qP7otQCOcdA4YnkM9JIWyyR+LwYBixfc4ru+ElZ9a/THzIphlQETWvo7TN sbXbcp1AEH6MKVBa88b/woVado9mMThNeq6vDqjzeLyUrmT/v9lYTdi7/Z/eSRolnq3f Hwk1/lTubLGJUKKZwGQw11pvordv89F1SfEeSyKqfwx9NlUYGTuYttqW0hnDhlQSg9pY Xcmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787049943; x=1787654743; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=shmmSGcBhVr0mO/l9YtNu+PS04UbaQ1RsT84Z7QOJuU=; b=oeNmSyeH3Rm4DmKdDjCi1oApe5R2ZEIFHtHctJxpbKMkTM4rwQX0PZeaO3/7pMs5ji X6VYTI8pbcsuXkDC4/bFOyC0OQYOtNhRfPQ5zWQPiNaHQ495gnC/6FQwSqmqFJ8sTMuq Oxc8PMHLYQeKK62AqnOo1tk/ZkoKFTrinETghDN0/PfnD4Z8zfn/KH6NBjXDwNHU/XOA +hvzZeldISEKftQgmlUDJ1CYGBH65fzRwYXbG9RhFS0KxvHKlN6C4Bl8nTD/NmRtaiqU 4L+Tw48aD+gOHb2OcejO+YBQVDEM001BRQQpfRhgU4BuPzNrZYaTSZBpQZ4T8Tur3Tfh E7Xw== X-Forwarded-Encrypted: i=1; AHgh+RqfXmQVKEgXuxTwhGbl4UABQ3+9ZenBkT1Oqq2O0iTCprixvVDF9kUYyHcUmSmqxP+xXyshuWKXOgIMuhg=@vger.kernel.org X-Gm-Message-State: AOJu0YxFzhqWOJGcBViolbtsaCuRx1BYAHp3y3IxdUv+n5Okkzqlie3o Pgq92g805VrvN3fUBKvifRAGcJv8xqeyZeBapRTaZ7FJukWHub6Y71uU X-Gm-Gg: AR+sD12Mf3P57BjN5ZBDTi5e834gFJtpSQUJU9wvMTNjXuGlNpc85azQExFjobYFlrh VhceOK7/d2bZ452uvK5jUat1/2sRHre+y5px9v405gz3RVn6tzNhT6zf/GDd81WFYPj5oSs2mcY voKnQDtH4lRC28rN553Bu+loPxAACKOKLuibJgi5G/Fd2wW7lZXa8kjyepTNuR+nNY1tkn/Dl/j BxUPMzcqMcblmNuGM/R1C4oonAG4f0MBXE5fMeMrnUkwDV6HWKgbrsIdjouCtYRv3QTWCFBnXtL dvNfX6eAgv4qFtVh5RUK248205nBLeu0JlXaO5Ut4vLWzUiuaLGD7YJrYhJhoZWOBtJO16XPNl6 yjIWx9F4ya9Pjy7X1I86wSNtgPZDFGx5qIdyorS6sU2BEwfy3GFvC4rGOySEosdWXdXBRIX4kGT l0bjQgc0bvuYisU5SPGDSMsD1Wwp0pqtGgHJkC0BJQy2CAqtr0OEAWms4JawgVbn0GzgDX4MmWg yeI6oQTXhVBgAcTMD+n7CFWl/tTKfaWlfwvla+/PqP8PaOJpR3D9SILY2JrzBKw5DnwlfehJZGl 3IjU X-Received: by 2002:a17:90b:3f47:b0:37f:e177:f58 with SMTP id 98e67ed59e1d1-3955a774dbfmr9754597a91.9.1787049942887; Tue, 18 Aug 2026 03:45:42 -0700 (PDT) Received: from phuc-desktop.. ([14.160.25.72]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3267bf83fb2sm15056847eec.19.2026.08.18.03.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 03:45:42 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ASoC: mediatek: mt7986: Drop redundant probe error messages Date: Tue, 18 Aug 2026 17:45:26 +0700 Message-ID: <20260818104526.37904-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 8 ++++---- sound/soc/mediatek/mt7986/mt7986-dai-etdm.c | 2 +- sound/soc/mediatek/mt7986/mt7986-wm8960.c | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c b/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c index 7a6ad9116e55..e7ecb2761b4d 100644 --- a/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c +++ b/sound/soc/mediatek/mt7986/mt7986-afe-pcm.c @@ -334,7 +334,7 @@ static int mt7986_init_clock(struct mtk_base_afe *afe) ret = devm_clk_bulk_get(afe->dev, afe_priv->num_clks, afe_priv->clks); if (ret) - return dev_err_probe(afe->dev, ret, "Failed to get clocks\n"); + return ret; return 0; } @@ -414,7 +414,7 @@ static int mt7986_afe_runtime_resume(struct device *dev) ret = clk_bulk_prepare_enable(afe_priv->num_clks, afe_priv->clks); if (ret) - return dev_err_probe(afe->dev, ret, "Failed to enable clocks\n"); + return ret; if (!afe->regmap || afe_priv->pm_runtime_bypass_reg_ctl) return 0; @@ -484,7 +484,7 @@ static int mt7986_afe_pcm_dev_probe(struct platform_device *pdev) /* initial audio related clock */ ret = mt7986_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "Cannot initialize clocks\n"); + return ret; ret = devm_pm_runtime_enable(dev); if (ret) @@ -535,7 +535,7 @@ static int mt7986_afe_pcm_dev_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq_id, mt7986_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); if (ret) - return dev_err_probe(dev, ret, "Failed to request irq for asys-isr\n"); + return ret; /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); diff --git a/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c b/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c index fc55ff47b7bc..49f5b2bf565f 100644 --- a/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c +++ b/sound/soc/mediatek/mt7986/mt7986-dai-etdm.c @@ -124,7 +124,7 @@ static int mtk_dai_etdm_startup(struct snd_pcm_substream *substream, ret = clk_bulk_prepare_enable(afe_priv->num_clks, afe_priv->clks); if (ret) - return dev_err_probe(afe->dev, ret, "Failed to enable clocks\n"); + return ret; regmap_update_bits(afe->regmap, AUDIO_TOP_CON2, CLK_OUT5_PDN_MASK, 0); regmap_update_bits(afe->regmap, AUDIO_TOP_CON2, CLK_IN5_PDN_MASK, 0); diff --git a/sound/soc/mediatek/mt7986/mt7986-wm8960.c b/sound/soc/mediatek/mt7986/mt7986-wm8960.c index f1dc18222be7..4517af9e2d14 100644 --- a/sound/soc/mediatek/mt7986/mt7986-wm8960.c +++ b/sound/soc/mediatek/mt7986/mt7986-wm8960.c @@ -135,10 +135,8 @@ static int mt7986_wm8960_machine_probe(struct platform_device *pdev) } ret = snd_soc_of_parse_audio_routing(card, "audio-routing"); - if (ret) { - dev_err(&pdev->dev, "Failed to parse audio-routing: %d\n", ret); + if (ret) goto err_of_node_put; - } ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) { -- 2.43.0