From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6C3536215F for ; Tue, 18 Aug 2026 11:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787051839; cv=none; b=pmgIkq6YzDY8tous7BQzoMFOBu42p0l4ffZiSokNgFUGwPKyVp8XfY/Jf63nuvaGYe/sHYcP/FWJMIYpXeTodRhD4zdHrzwnbK7+oHvEmQR/uMoXWo0+APL1Y0EEyJIv6tPBIVXTN3g0oca6O92OnsdpSQmcYGLIZBIY5IOruis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787051839; c=relaxed/simple; bh=XOZ1C1WKX1Q/N+q97vmu/pBg6mYYy87yS7RYm+CZIq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HNHQ1XxhnRZb4MaCBPIW21IXGNCLlj40h/iCrTMTn3AFXi8/jHIIpu4spuz+p+c31JOgWMkBFyGg4XIqelAh8Z3EVUxL0Rqgy5t5yqzYPjI/c5DP5PM+joNLf68guJ9t0DmhwlHTn0qk1uPgyAGOUvUe9z+tSNIfabpOf8gTFt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=THVHSd6c; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THVHSd6c" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caea3f742bso75117695ad.0 for ; Tue, 18 Aug 2026 04:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787051838; x=1787656638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/MC+OZGjGzIkVi4Bke2RwJ2I/Y01BrvObCBkky9oI6Y=; b=THVHSd6ccuooFx/7/ty2TUozXULkt+U/mW7YUmeEPIFUSOdY9vBk8de2uo17Lb+Lyq Gds/8LPWmp2fhveC1drNjVSBVJxwcuVDtMGF4gFoXc8f9eK7Wr6N3S1x6ZcXE1VWsymw ixEDaWmKFPTpRvquwOrlqYHNQgbt4Eyz84XMnG8/qWCjG/IJ6wBRO0C9V+oU0OBtFQ+C IWyf2p410R44KzdUXXFz4DhLJqS+qtPfGj9/GZJDV89hJD+upql7j9wU5PX0P5nwwsPs E3ot+Ipe2doDMs4YaDUw6tHRMQU6l4zHSolR+klKA3i/eOnt9Fz307N2yNYl1LWmZgDf rh/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787051838; x=1787656638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/MC+OZGjGzIkVi4Bke2RwJ2I/Y01BrvObCBkky9oI6Y=; b=K8zESBDYW2tgTQ7T9Cic7Xy2/fcXrqH+546ycd3sCK1buJ7t17E2DtgX2XXCkxlGfe GdB4ZhBEhuvR3hcCDW1fu/A+XUhl0KqI9DmhwGI9G/YqSyw7WewWFxItg2D7WzYcyGd+ D9YP8T4ieLBForHADbCxw9U5RuvgIqp5Vwxv1nsMufx7LtKMdKMEBHy+aYgp3KuiDxGj /6EB6vcVEBqh0pst2MHT+IgBV4icugadv8/+uDfaBsL0NZSg8l6GbVwVjGzidFO7InCN mqSKoE/LV1jcFZkLwoXp7BBpdrnN+dQf9LFwdFGIArz1kPdMNwvywR1oXvOIjgqLhNR/ FbVQ== X-Forwarded-Encrypted: i=1; AHgh+RpFJXBdDBpbHkeoFaMQn9gbZ8M0LzOvB0fZy6O3Oxg2/L20Dlv52HU04XEpF/wXtAr9CPp6RxorDnaTYZ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsmb+DZ9e51xa237Y56JTVHC5k1ODf6wCE4czylKgKvaDUAVFB ECuQZOj5J9YltnsvCNPlqQWee4JOD7AgyoLREim+BbK47UJ1OU1u/QmFG8vxqEOmwWiu X-Gm-Gg: AR+sD10d2zAat9GOhkZ8uAl04II+L+4/v4TUsH8TKyb0Rvk0gIB4zydR5XP0404y+5m yoUnScQXGR5DiVTDRfLYyGf8hOYlsyj1qRu05gSHVbXg/D1S7OsRQevcPdYUOMBBkLxb57F3NVr 7FOHwognDjX/nH5VfnggZF6FW+8cvcqrmLEvX1+u5hwSlHcbW/p0KdeyEmnKv8bqxPUDk9hE0xR zmwDlxnC/1ZyuEJKkuUGhLOyvCXV26/T/l6hATtVSssbi40ujOOE6CO2Gy5D8wgkXdSKom6saH+ 2uOZOYwjg4d150ul8gIFFxkG30fBOn4khewasOyHih3bWitm5m3gWQwd5uf+9AcuLUrro+/pYPE b5AxrLDNxcdw7eaHyy98G46XLFAQR8PPindBrZ3L38NcqSornKsL5j8M4La+KHzUY12Zmrsv/mt z8DUrAc8H9P9Y5sd/AAaSyQlwSQMyn6XM4t+C0cp6URzkgEN3FvoPxdriyFGyhIhQmEoumQBiR2 BPOglF7sh3MED0TykMxwVth3GoOhZtHVCbA1fu33KhWiSkQv1lpvR1u8vvNzaL4ZDefF8N9BZhP UV02 X-Received: by 2002:a17:902:f691:b0:2ca:481:de45 with SMTP id d9443c01a7336-2d5c4f3b815mr95122705ad.6.1787051837903; Tue, 18 Aug 2026 04:17:17 -0700 (PDT) Received: from codespaces-2db70c.ktkhmpmw22vebpok31ngjx2qsb.ix.internal.cloudapp.net ([23.97.62.119]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1e542ebsm13534685ad.47.2026.08.18.04.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 04:17:17 -0700 (PDT) From: Triet Hoang To: triet.hoang.dev@gmail.com Cc: andi.shyti@kernel.org, bence98@sch.bme.hu, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] i2c: cp2615: handle allocation failure Date: Tue, 18 Aug 2026 11:17:01 +0000 Message-ID: <20260818111703.19604-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816161751.24840-1-triet.hoang.dev@gmail.com> References: <20260816161751.24840-1-triet.hoang.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the result of kzalloc_obj() and return -ENOMEM when the allocation fails instead of passing a NULL pointer to the message initialization helpers, which would return -EINVAL. Signed-off-by: Triet Hoang --- Changes in v2: - Clarify the commit message to describe the actual behavior change. - Fix coding style regression --- drivers/i2c/busses/i2c-cp2615.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i2c/busses/i2c-cp2615.c b/drivers/i2c/busses/i2c-cp2615.c index 951de6249834..c1275fcad636 100644 --- a/drivers/i2c/busses/i2c-cp2615.c +++ b/drivers/i2c/busses/i2c-cp2615.c @@ -128,6 +128,9 @@ cp2615_i2c_send(struct usb_interface *usbif, struct cp2615_i2c_transfer *i2c_w) struct usb_device *usbdev = interface_to_usbdev(usbif); int res = cp2615_init_i2c_msg(msg, i2c_w); + if (!msg) + return -ENOMEM; + if (!res) res = usb_bulk_msg(usbdev, usb_sndbulkpipe(usbdev, IOP_EP_OUT), msg, ntohs(msg->length), NULL, 0); @@ -176,6 +179,9 @@ static int cp2615_check_iop(struct usb_interface *usbif) struct usb_device *usbdev = interface_to_usbdev(usbif); int res = cp2615_init_iop_msg(msg, iop_GetAccessoryInfo, NULL, 0); + if (!msg) + return -ENOMEM; + if (res) goto out; -- 2.53.0