From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D64A73D25D2 for ; Tue, 18 Aug 2026 11:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787052798; cv=none; b=L+f5uPvCKRzrgpaJi5dNmVGA+yqk/n/Ugk2yS6Bec9wUfUElZusG2vWDxSdAjRZRkJ3A1PHR5HE8bIV/Txvr0pKctNJsX/31txOJXcVKOtK5r3JU4eGF5Bos9jJdTWx0H9tzFHEGKU2TXYtAuPLDXzOax0rjIiD9roAKlMusMTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787052798; c=relaxed/simple; bh=4D1vUM88O6c8JHx4tYs9LNhi9yvrNGvDHgy4bVWWi4s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EpzIJz9BwFJseRUP0P5w/caM+3dqa9P5ewPF9TXR9jPVSTEWI05HAQrVGkOdmtfFdHXJXlfzcnKfFd9Thu2j1ywnyKr2njSfYnA0rBMPGA9wzWouEl5beyCsRr6KlgiXxih9TXuBpvwSS97Jph8YFTWKGg32aYsA4LViBBJI+eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gzm1GoRs; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gzm1GoRs" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso2820350a12.2 for ; Tue, 18 Aug 2026 04:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787052796; x=1787657596; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ErnJauar7zJkf51R9QKk9qiVc4qZQuim79mLl/qt+gE=; b=Gzm1GoRscF6gzeDUT1PfIAftwunCOgs2Ly070P+aOrg4A9jT26GE6uaddtIWKUKc/T XblB/MZqEJ+TE36v3SocX6oFK/A67Nbz1P5g/F9pAdvjGPda9X4oguUkoIHAnMjGK6n9 HhoDCW5FjplHQLrKacPzxQXVsNWbTmicl4Le17+NnLHV61YyJXfqY6bMDQFEC/n9JqpK +fHZDpHwZgqdsYsjGlRu4gg4sgEPjh9FLmhB3h4AFE3UxqBWZQ7pq6SbvwaSJdKXV90i M3nBMvWn1TjQkVlAdF1IcAvBLcBn/+jGez6tgTSE0neoN6jGT2Ae4R8y5TwjtPi7uydH BtuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787052796; x=1787657596; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ErnJauar7zJkf51R9QKk9qiVc4qZQuim79mLl/qt+gE=; b=bspF8QJBrdsOXEm9vjPom4wKX8Z1XsnsXajzNVzhYb4Xr7N58tPJROqMsZaT6MlnJt lqoYP/dp1H2VJR7LLEFTU6J2nNuzSb6AtwoChumn5PPmL9Se8dQcXE2/dZU+vvjE7qKM 7HTzUgxYVUyYAEHtbPiJKr3/2+ONcTfqesToMy/FURFw8bdSJ8oqJNalcqV0W7fgA8Wi qeTSM/kn5GqtFbb8CeA9lYThVkDqjWgj8IqYif5id6rsBj30kHhj7Y6M8Rvpc2+HY5Ao vbYPxB0RXjz71pPtV4pQ1fjdC5Sk3CQnDln8xyp/gQzxrgmArd9X9Xm7+KbXRk7HCABw KUfw== X-Forwarded-Encrypted: i=1; AHgh+Ro1LCNlS2klpL15OMzuailAJt92MV6wFwI5hYb7YhYGH10FYJhqY+PUXFY8WKwNyjjU/ugJiSWTqNfug1o=@vger.kernel.org X-Gm-Message-State: AOJu0YwtSGtKizIBAYRdfURVbRw1rBChKDqLA70XL2m3CoLW8ty0fZOg jLQVRwwyW6cjgRibcEAAFNTuOaYrlRRx3Ank9baOVGSnRW6d5fJHUQk= X-Gm-Gg: AR+sD13ijdQ3Ny4BjkzKe6ZGmIUm+ChFxlSnrpjB8tbnlwVWRjCRUvgKiO9WShKHD/A qWLvy//TLwBp4G+udoSQKiE4Ar8blMlV8qbWj6MPrYcPUZjBX21Af+SlgqQ7RILyzstFS3uUzYu JDHq7DX6F7zjmNkwLAPJY8yxWP+/FZ2nYm7akuPcZpAVfTOfnwX5X40eBv1VHG5sp+5oXRfA3sA m+3r1vRNuTomWR0jgzwCDikgqJa9EQQugGqutlK3da5kA0eDRVIyK9JQsYp1Ci1i1KnxV23FbnK 6ydd/X1FN9aIz2iSOftdZAUqIDB7Lt+5bOW+efmvKoE4++xw3EPJNd8igCjJfEBsd+h6X/w9t3w yRy3alEyDzwiOt6UnHmELhVRXcFnA7vZ5oyDa6txt1rTzjUzhhYtBha0kuVt+MKy95XmAw0JiuL 6XzZdDZ37cGiq/hPJvvKk9Mxxr2LAoF2UAutwQwF4EkVoHrraY8KUj4ivVkZxPqMXZ8bWuqKtH8 ZAhAgAE0nuBk4BGij+5lXYaagwm3Pez46U4iX0qWHQdLe06dkhtUIV4x8aulnnpeIJq X-Received: by 2002:a05:6a20:72a7:b0:3cc:4f34:3733 with SMTP id adf61e73a8af0-3cc71a6804bmr34073028637.10.1787052796166; Tue, 18 Aug 2026 04:33:16 -0700 (PDT) Received: from codespaces-2db70c.ktkhmpmw22vebpok31ngjx2qsb.ix.internal.cloudapp.net ([23.97.62.119]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc13c00dbc2sm2036427a12.15.2026.08.18.04.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 04:33:15 -0700 (PDT) From: Triet Hoang To: dri-devel@lists.freedesktop.org Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, airlied@redhat.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, gurchetansingh@chromium.org, olvaffe@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, simona@ffwll.ch, Triet Hoang Subject: [PATCH] drm/virtio: Fix possible memory allocation failure Date: Tue, 18 Aug 2026 11:32:56 +0000 Message-ID: <20260818113256.27848-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When kmem_cache_zalloc in virtio_gpu_get_vbuf fails, it will return an error code. But none of its callers checks this error code, and a core dump will take place. Add __GFP_NOFAIL flag when calling kmem_cache_zalloc to make sure it won't fail Fixes: 6f3d9d0dd335 ("drm/virtio: Add drm_panic support") Signed-off-by: Triet Hoang --- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index e5e1af8b8e8a..fdf0f3c2d3b7 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -93,7 +93,7 @@ virtio_gpu_panic_get_vbuf(struct virtio_gpu_device *vgdev, int size) { struct virtio_gpu_vbuffer *vbuf; - vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_ATOMIC); + vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_ATOMIC | __GFP_NOFAIL); vbuf->buf = (void *)vbuf + sizeof(*vbuf); vbuf->size = size; -- 2.53.0