From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D24D1483820 for ; Tue, 18 Aug 2026 17:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072742; cv=none; b=qKQG86u1q2VMGORzY4n69buGroCZwAABBIDu+UNm0XRCFkLFdS30v/JLX7XusDgq5D6PZMmPg/t9lH1SrKiZxOnOt9JgK1uuIxvhhiUY1b/3AZBbQs5N1umRTYqZpk7aL92JL2ZjJbmUO2a43ZL0tFLzrX1YxgwGOYyL4cfBqQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072742; c=relaxed/simple; bh=jHnG0eH5q7BEzlFm5gzZRXwD/Poj3zqUFlrLsn5SGA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O5qMc36hBa9lTnA3De+g28MqHpYpoJGoXZ1+V1mMDjDmKT9RMG/ezjXpfnS6p/ZijsMfte7LRduHDqm75F3mn1MqtKcu1d5uHSik+5VBRAfEIVc5O4FOpOkLwaiv1iLQ0Z8Q80vi/eDgtllBEsTuvxdfjRefO4Ix8XNBux3g8Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gfD4nLgU; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gfD4nLgU" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-381b831d535so263094a91.0 for ; Tue, 18 Aug 2026 10:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787072740; x=1787677540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rx68bqDUVVVTQB5wmRY5hHoQzrY6WoPdWafYNYcX7x4=; b=gfD4nLgUnW8pPbNVR4a6HvcvgwRbjnfr3IyELEP81IHmn97sLnAnw5tHoVKGc6enAy 25C6tAxxkC2oNd2RV6320ztHs0KJyyCmg1kk90pLsjJbH8zSX6deXYJ9DvV1vZ1dk26z TK8pEdC+Srg/Djxo4OmSeGdjkT+mMb25zWj4NRebGZDIvDm6udYGnv9DK8rWoztD+sBC f4b9qNYfm5dRgVuuy0DxlKWs+yley/kQMSpszwmr01INevovIvx+avu5kmHapfp6nixW 7Fvc7Z9/JjNozr0BA+e26Gasw7sy5aP3savSCrFEkp2e5EHaOyK/sU35z1W5hlIIRZWP hDHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787072740; x=1787677540; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rx68bqDUVVVTQB5wmRY5hHoQzrY6WoPdWafYNYcX7x4=; b=lnklk8ans7YWkV62rIUCclbNgr9ZDpv1mCgiIqSN/BP7b4u5lCkAoTCdxcgFHJ+Ekt LR7TDwSL1gNEzr47qhP1l4nv/wYUnaZd7AalPTGv70HbdqKds4fqDLPq/uzzEQ7HULT6 5ZFHXqDGtD++vFY84E+NUC9ZEUExyuLAoyPwkRZz9Z1bxd1cqEowYye2rmPv9dY6nn9j h2qT5HGeaEctx5T/wfGT/6e6s9rAl5wp8ARxueZUqe/xzX91c93/11C1FqY+xwV1FTi5 VHg70y8LYBfNmRtjEwgU3M9Ts+wi+cpGLWLgYzN4S38cWFApE2xA5oYp2so/3QJoENSk /2PA== X-Gm-Message-State: AOJu0YxaN1OT0Mk10mXfOevkenrZ3PCDWnpZFu5gIuNyC/UmCDnUoAlJ eeeleLpURv9TugM2SNkl42LvOpF8PCJMhAb+Rc5OQI0xYSUQZRiCDfUZn6irwQ== X-Gm-Gg: AR+sD10tCwzTFK4yCQOZwzLXM89xZ12MiofsYVKPp6+oAY9YpOGgzR8UAjNIprvjrTC zWyyoLKahL0xCUYHZgyBFI+8FHrdXdLZvOLhncQPSWrxlTMTCCToOqw09OsEtwo0s3w+ETenwtz Qe/jwTrqLSMuUZOWvafP8fRE0zmMx4ldgnvurJVVk7wSrKyIAxEjB4uylxeUILDVS3Y7Xn5OGff xaQDAixE4Wqzs0lT8pdFnXGAU4hhwRVAj3ACBMnA35+RIZzJkAXXQhpyzwTVbafJuKoMKmd3uFS LfxmcieUuMBpy3c5dBAH1V1WDd1PPNzm42xw8uHRjsqmXN7VQDmTS7QV4Oyk1YOSNXwjJBCslme qCQ5elO5ATccsHWkFF1oamJcXl5y4p9u596sGM0Pswb3IhXgtlqzzQ3cmAlqlSDepcf8evQxHMK pcbZ3oj7sk+vj9lOMdrYqizYsxQVkcxim65hJyvdat8K6shKnYqZIZOTzsBs9QKuBs7qMbWhi73 Gq3KhNnRaK+Sa4lGaRhab2Um32bVSyytvJYVQaDwq3ZFXioGLlnzXdQXgMqHqJxg9XjGdZAUXeD aoryac+yephi X-Received: by 2002:a17:90a:ec83:b0:381:e74f:8a6a with SMTP id 98e67ed59e1d1-3933b8c1041mr40405564a91.16.1787072739811; Tue, 18 Aug 2026 10:05:39 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2a00:79e0:2e7c:8:50d9:e296:7754:dc83]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-326761d3539sm17447167eec.0.2026.08.18.10.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 10:05:38 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong , Sunmin Jeong Subject: [PATCH] f2fs: avoid setting SBI_NEED_FSCK on transient resize failure with -EAGAIN Date: Tue, 18 Aug 2026 10:05:35 -0700 Message-ID: <20260818170535.3190869-1-daeho43@gmail.com> X-Mailer: git-send-email 2.55.0.691.gc56d675ccc-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daeho Jeong When f2fs_resize_fs() fails due to transient lock contention or retryable GC failure in free_segment_range() returning -EAGAIN, no filesystem metadata has been modified on-disk yet. The filesystem remains completely consistent and clean. However, the current error recovery path unconditionally sets the SBI_NEED_FSCK flag on any error, forcing an unnecessary and time-consuming fsck.f2fs repair on the subsequent mount/reboot. Fix this by guarding set_sbi_flag(sbi, SBI_NEED_FSCK) with `if (err != -EAGAIN)`, avoiding false-positive filesystem corruption flags on transient resize retries. Signed-off-by: Daeho Jeong Signed-off-by: Sunmin Jeong --- fs/f2fs/gc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 192b16ac02f8..787133ee2eb2 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -2446,8 +2446,10 @@ int f2fs_resize_fs(struct file *filp, __u64 block_count) recover_out: clear_sbi_flag(sbi, SBI_IS_RESIZEFS); if (err) { - set_sbi_flag(sbi, SBI_NEED_FSCK); - f2fs_err(sbi, "resize_fs failed, should run fsck to repair!"); + if (err != -EAGAIN) { + set_sbi_flag(sbi, SBI_NEED_FSCK); + f2fs_err(sbi, "resize_fs failed, should run fsck to repair!"); + } spin_lock(&sbi->stat_lock); sbi->user_block_count += shrunk_blocks; -- 2.55.0.691.gc56d675ccc-goog