From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D09523ED5B for ; Tue, 18 Aug 2026 20:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787084031; cv=none; b=gON61SegdLAw4ahUxvouaNtEP86GKssBa1JWDx0hoYX/UpJOGhuEqxJ/5HK3znsqtfAre6srxCp2b/91q9h3geb35qIbAYMUL7dmwTYur6s32E2lYbdN/jJjQ0sk8egOiRi290+ndkl+Mqb39zVCak1j6in3rGMhKGcNyMlH1go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787084031; c=relaxed/simple; bh=dIxM6cyQYT3lRdXMRsduJ1Rk39cFZjXt4pynUWxmcvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pVjBLP8zfhfVUvtDyKS9BEMF04Luafp4Tq9GMXoREteXSt60x/aVB1flqXso+6BYZwbSIPUUZNSyN3a7PJvz2hIr1zf/C75K86ZbQGFE9vMNlCd3oTUDCjZAewy+qio5Qb4ui8rD3tDk0mjQCUjPrfWM4ju8H2L+eFvtK/qrtlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iEF+rXQw; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iEF+rXQw" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47de008b020so86768f8f.1 for ; Tue, 18 Aug 2026 13:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787084028; x=1787688828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9aelghBA4TaVvCFRFUwS+75eHiLyMl0AxVtE9OK5vvU=; b=iEF+rXQwADRgWyzZAsjnQ/gM031U7VK8zFUrgK6RCLW+vWSOo3AOb+rInLThgfDYQL cO0ttklX0P76XDWe1A+xNDyA2bP39gyAXdjiSht+ElvRDRHekwa00Q0BQAvab+yCE9DY Vz5ZYW6to7/k1lH/2wPmadN16UIx0p4m4ubljyHXgv1TUmADZUCAGF7km9KcPE9F9uYE I2bWoL2l5/J7mSHPXw+d/6IkHKlTvyTWFHhIXh8IGFFj2pBUS6QoyxGwieeFVlKprGuj T/GB/gHnsxOtFrt1VY4eGQHpljNb6qK1OpqIoZ4o1H8PnIQUT1EDX32/oABVPsJ6GKDp wJ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787084028; x=1787688828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9aelghBA4TaVvCFRFUwS+75eHiLyMl0AxVtE9OK5vvU=; b=nRKQu646GVLYEHWfsGBxOG4nOF+fe8asMXQp7+Luw1/5MH4Vt4RCWg2PTyOycb65hP 1ZgBEUbeBUFRkPYwRBd9OIYinIxhIx5oBvihRH9YTuGfJH240yW2mquEnl5x61ZHtGXz BENXfpj0uDjzUKXFyy4pvc1x/IXz8UDPBvSNpJ0XeLFjkF42njYyKnN366ZaNhaahWOd VQHdhxysAy0QQEU34awgqj1mvDmkTiONkOyWJzB+uU89e8XS6TY5NE5tJRAlIwkTyZUU iqdAdHhExQ7Cx077/DmbqKrpvbQesv1MvBPZBJWAVwthI9oW0UgArpT+8vD9++JK+3c/ LtXQ== X-Forwarded-Encrypted: i=1; AHgh+RpQm45sy9kaeHUbeRTPaRltuawHLr2IPkxPbYS+GRb0hh28X7lX7PIk8rhG4mMZItze5s7oI5hM+AuLRh4=@vger.kernel.org X-Gm-Message-State: AOJu0YyWgkXoL68+JIxv7mAttZZL3ymq42+XaEw8ATnjBiJF/OrmILWb 1rc/VC3/A3iYbHU8/8I63AHorjVeZ+B1DxKgX5wKX6K876rcv0xBoqra X-Gm-Gg: AR+sD11W6LoTdPuIwYSlajnCuL8ADmby1C3vtT1nEit83dUcC9vp+kyk9eeQ3aeDQ0A ljadL2buz4ZIPO31+Atieh/ABTzSG+3LL0KjjjmiquJHHr+Z0lQSY5/fgjkwONpU2eMfK1iZRCg FBLQ5O/PT7ernms4X2/sK/9tcus3zZgZWS7twIhQOZgVzm1P5GPFa5bAmChsQ+uhWA+4bTaJ2qo GKbdinSPrht2oQRlVwtjyge8T0vXMZvMYwIJhmYane8+myFHiBqwg/6wDSSew2m5czay0xvT8MK t4blhMdGTJJEdtcBko9eiqYg1V0qSdPNnBLlUVTCgwVjD0gAOmor1qgHgAGGF9xq+N9GSMs6cQo gaydGfpLvIJcnPscF2zbuSELQKiTtXjcTQybOTSYdwGDHxHZMEaiwWNrWbB5W0+NydGAnM/zJ00 pPKepphcqE4/BBZUe9eJ+juqzi4tluDGBkf9uQRAhRomks6KXglxqOn5LhwUJc04Vxr5fZIoH6c STSaAH2EPMxmrY= X-Received: by 2002:a05:6000:4013:b0:481:562d:6fb1 with SMTP id ffacd0b85a97d-482b06d1c7fmr1374197f8f.6.1787084028154; Tue, 18 Aug 2026 13:13:48 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b77fa3sm13932329f8f.26.2026.08.18.13.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 13:13:47 -0700 (PDT) From: Amit Barzilai To: Andy Shevchenko Cc: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 6/6] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support Date: Tue, 18 Aug 2026 23:13:29 +0300 Message-ID: <20260818201331.39232-1-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, Aug 18, 2026 at 11:55 AM Andy Shevchenko wrote: > > > +static int ssd135x_init(struct ssd130x_device *ssd130x) > > +{ > > + u8 remap = SSD135X_SET_REMAP_65K | SSD135X_SET_REMAP_COM_SPLIT | > > + SSD135X_SET_REMAP_COLOR_BGR | SSD135X_SET_REMAP_COM_SCAN; > > Same comment about const. Will do, same as in 2/6. > > + int ret; > > Why not placing it after cmds? No particular reason. Moved below cmds[] in v5. > > +static void ssd135x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array) > > +{ > > + const struct drm_format_info *fi = drm_format_info(DRM_FORMAT_RGB565); > > + unsigned int pitch; > > > + if (!fi) > > + return; > > It's less maintainable than > > const struct drm_format_info *fi; > unsigned int pitch; > > fi = drm_format_info(DRM_FORMAT_RGB565); > if (!fi) > return; > ... > > +static int ssd135x_fb_blit_rect(struct drm_framebuffer *fb, > > + const struct iosys_map *vmap, > > + struct drm_rect *rect, u8 *data_array, > > + struct drm_format_conv_state *fmtcnv_state) > > +{ > > + struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev); > > + const struct drm_format_info *fi = drm_format_info(DRM_FORMAT_RGB565); > > + unsigned int dst_pitch; > > + struct iosys_map dst; > > + > > + if (!fi) > > + return -EINVAL; > > Ditto. The problem is that the current style is tempting for subtle mistakes > such as defining more variables that may use fi in between. Noted, I'll move the fi assignment just before the guard in both functions. > > +static void ssd135x_primary_plane_atomic_disable(struct drm_plane *plane, > > + struct drm_atomic_commit *state) > > +{ > > + struct drm_device *drm = plane->dev; > > + struct ssd130x_device *ssd130x = drm_to_ssd130x(drm); > > + struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane); > > + struct drm_crtc_state *crtc_state; > > + struct ssd130x_crtc_state *ssd130x_crtc_state; > > + int idx; > > + > > + if (!plane_state->crtc) > > + return; > > In the similar way here. I'll move plane_state to just before this guard as well. -- Thanks, Amit