From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58F234887B for ; Tue, 18 Aug 2026 21:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787087026; cv=none; b=pbeEXj+KxjKgU74D0CZCAcp7f4gtF7DK2oILMKWofcjAVUK4iSHjSI+LwiDSu5IdPG3Mk9qAR05fp8Xk+2h2Y5gpzVN/p0505biQ4qNqD3qJgbi+To922kd8E9l2sazoKKcbjfNMKdxo1loiRPPUs1gAkYTUq7AO/WEI7TVcenw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787087026; c=relaxed/simple; bh=Ciga8fyK2UWC2s/b5cGw55pFzypHL9tfi1jBgKUzLFs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Jh3LSHfDuICf0oYQYMb1JIF7fJLRDrEvF8b5TOnUkooXFGxDvEE2tKYlgWPBi/s2B4Ww/QSRUG2wn+P3hUMUnSXUytJBfFE/yn36pSbJCyNpPcb2+8SWL44d2VF7ObBx3BRCRlMpAn+wJHMkVebw8IKNA7PtjivCM+vAscv0N7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G+4VXr4l; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G+4VXr4l" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-c197e7e4e94so41884666b.2 for ; Tue, 18 Aug 2026 14:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787087023; x=1787691823; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Su7JG/xj7C0P3Xla66ic7tZrV6Rekk1QPQ97x1ZodVQ=; b=G+4VXr4laiwUjYBDJc1iSH3kniDzehfdw8uOAascpIjCWHa/5Q3DLrc4CljbiLLp/1 AOS0wo4PWI756fIIMyECsXi4op87rwUevyawJ/XMIRNaC8ySurmze16B50WizNunSDsI +4Tc0A1nkRu69OAJZLqn+yikDxJqegqSr4Lbw4lo6zo3MZYTMtWMvoCM+orkMHRq8j1z vj1DxnMvFRLfOHmzcm1m2B+pTEcrvBS3nQCnLQ0zPwWshfp7DRemSKNBD71e9zB/M656 7wvOrLETx5dmQR2pmDUTLVp3e8iPmEVTP7ARwbPzoiabZlvaPAmM8jmGkA46CkmWyfzX TRmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787087023; x=1787691823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Su7JG/xj7C0P3Xla66ic7tZrV6Rekk1QPQ97x1ZodVQ=; b=oMQkY74sRPq7OJEteH34y/Nbaw+ZIoEQlwSeObgENdwuU4MnrYwNz+iBDTTgIqEVF1 dhO5d+DRdWXNPKrxCJ24Etmlgooqy+bo1VO88eSJbDJgpOUIrSIvzCIdTYQ79YAPxwRK 39f8X4SKK3m5ny9wM/Ycd92MpcgTP2UEAWuZORYWFNf3kkbBSSwmilub5O6D6+IotrMI oSIfnVFhwRG5OEATaQLibMTHKMekl+j6SE6mmivREAnQJNbAEbKXbdAyVqtNRb6hmpRF rM0QKxiplZYETId5NSDRyo6LGl/BMMqVzNNV7mmKDoZOqniCR3Sk8dXenYMzr/H1ZwHr QNMg== X-Forwarded-Encrypted: i=1; AHgh+RqxvnsaeBHFM7XIk/I114UG8/hF5peui6SWjBo8rAD7vhWmrkOmfaU4weSNQ41Uiyd/uMGn9qVPBEbsYGc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyii51m5G45IbyiFb31UkXrB8yQxPt6sKH9ufnv8YdzBF5TVSbq 27vyTPlpiLZE8BmWrciJJQSPzuSKJGjPN/jkzhMengsEV8Ur38Wrqe3N X-Gm-Gg: AR+sD11q6VOT1l8r2PsQDTSu6yMicXP6DEm/Lyh90sUYth3WGkbNeeYIIkRTEdbRukV EQCT3lpNoNV+TgmBiyQ2ASnH3D3/98hNw7bkThM29sk+r0u+oHpAZKpQd7UJmDBVIg9cHSwkqfI QgIvFyIo9rNKE+nq57kcP6Ox7wohPRpERwP58BLdtG/svoOZf/SuHfbUA/wl0BpkejS7AfPiAYq 2kHsjgfzrjxIZCrb86i8zGO4GLFY7UeiNoR5WaMS+39tOub09ZlU5Sy+QFgGBwQwytq4Tv7eZgj ElEsdUuBotyI0h1nhxALrOY2kqOoK7vMzzxW96QNLlx50490//LDZc5ldu16PUUWHjPk4pO9n1L loPD16Nt4oIOITMTPjVvKhRJ/AWOJNrsqWbZ2P1+QpgQ6zB49g5FzC91UWdi6VIUlAp+nhXUEb2 P3/zJ8cOf+xgz7eXFb7dSiMjHFnTNhPwuOl8ZHZ9++hyu5J4apyo1lMn6lTAXr3TU1Njtfmidj8 jzgitjeUTSbngychN8EG0Ou X-Received: by 2002:a17:907:94c7:b0:c21:f41:e192 with SMTP id a640c23a62f3a-c222a0ee20bmr66226666b.26.1787087022655; Tue, 18 Aug 2026 14:03:42 -0700 (PDT) Received: from fedora ([2a02:6ea0:5601:6307::13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c219e3f64d6sm51888466b.32.2026.08.18.14.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 14:03:40 -0700 (PDT) From: Muhammad Bilal To: Ulf Hansson , linux-mmc@vger.kernel.org Cc: Johan Hovold , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH] mmc: vub300: fix Use-After-Free of inactivity_timer on disconnect and probe failure Date: Wed, 19 Aug 2026 02:03:22 +0500 Message-ID: <20260818210322.53266-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The vub300 driver arms inactivity_timer during probe and acquires a kref reference for the running timer. However, vub300_disconnect() sets vub300->interface = NULL and drops the driver's kref without shutting down the timer via timer_shutdown_sync(). If the timer expires after the host is removed and vub300 is freed, or if concurrent work items re-arm the timer, vub300_inactivity_timer_expired() accesses the already freed vub300 structure, causing a Use-After-Free. Fix this by explicitly shutting down inactivity_timer via timer_shutdown_sync() and releasing the timer's kref reference in vub300_disconnect() and probe error cleanup paths. Fixes: 88095e7b473a ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver") Signed-off-by: Muhammad Bilal --- drivers/mmc/host/vub300.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index 8e45dc1a4a12..9f84bd1531e2 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @@ -2350,6 +2350,8 @@ static int vub300_probe(struct usb_interface *interface, err_stop_io: vub300->interface = NULL; + timer_shutdown_sync(&vub300->inactivity_timer); + kref_put(&vub300->kref, vub300_delete); kref_put(&vub300->kref, vub300_delete); return retval; @@ -2385,6 +2387,8 @@ static void vub300_disconnect(struct usb_interface *interface) usb_set_intfdata(interface, NULL); /* prevent more I/O from starting */ vub300->interface = NULL; + timer_shutdown_sync(&vub300->inactivity_timer); + kref_put(&vub300->kref, vub300_delete); mmc_remove_host(mmc); kref_put(&vub300->kref, vub300_delete); pr_info("USB vub300 remote SDIO host controller[%d]" -- 2.43.0