From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9288C3ACA5C for ; Wed, 19 Aug 2026 17:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787161667; cv=none; b=tJ57E+m1OC6mSj6vmMaizyQsicHgJLxRu3tcTK+g2y30T03ZhC+tN/g86XXi5d9m74yCn2DhX11o8UhjpDJYC1dISO8ouwMWr7JgTyxyW+oXVo6Sy3RSF6JJJiMCqn/HGhxj5p5awKmfmibDyCaYpSJV/3a6LJGl7cHFzuy9XH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787161667; c=relaxed/simple; bh=I+tlGYriOpQ1CWlXDJee6CaFz5rJ+2J5QxrZ+xTXvfY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=kQBKWX4P5/uNqd9GB2zmz53pCOAYqX0+bmGdVkXDoE0CnGNhNRY+nm7Y9CbJTonjvv6NA9KwODkuuv6ABCGmurIBFA6NIlBTV2J7AmYBX4ce3tGuOd9mbFBPP4b5o8I5xTR1BJZF1gCFy/ZwcMrBFtgdqNIiYqQpyvTdxuBIhXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jAEBPLlc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y/4OsD4f; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jAEBPLlc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y/4OsD4f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787161664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3rl9WRlfF1qhC6KkWtM+soeUVUGORv4VBrHtcu1jow0=; b=jAEBPLlcmF+BKITH8TGleFT9vovHQS0lg3cuvwNkIOkQ5QhG2RLiYAPq/+9Jc/67Lesd64 Qzj0CQj11lPExs8WShmR7JKMDv4PlnQZ1sv0A1SQQ8+qDbuEnigfzfVdUrkDnhgc3j3OSi 1Lti8Cq2QNU1DTNOwjfBMjTwA+5qXxM= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-j-VTjuQfMJu8dz5UY_R8SQ-1; Wed, 19 Aug 2026 13:47:38 -0400 X-MC-Unique: j-VTjuQfMJu8dz5UY_R8SQ-1 X-Mimecast-MFC-AGG-ID: j-VTjuQfMJu8dz5UY_R8SQ_1787161657 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38dbf293831so3351683a91.3 for ; Wed, 19 Aug 2026 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787161657; x=1787766457; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3rl9WRlfF1qhC6KkWtM+soeUVUGORv4VBrHtcu1jow0=; b=Y/4OsD4fZugMv1coPqHIjrMzCsOYh9ve+n61CTdBHzrQf/4+x9lFVjJIL32khN3Zuj ysuSNR7F0TRal/Q6e4mva1C22N3C6cB2TEh/b44uWUAP73WRSBg5FgM+Oxx2Fvpp8wOi OcYcrw3J5R2YVOOv0xAFqd5q5ELrbqRKoCYY+ZCaFMWo94Q32dU1qMlK11p+HgTSBk+V s1FV2RcLChPNk1sBjcOW7WLdh4ISDjM6FqUk0DbpHhRm6X4iTsTnoPqtmhgGol4beVLc 9rVzLWY61qc02Tu4JFy3Z2jH5BBmZII2oRYjLMMY54lsSvvHwRgPitWdRtLjGdOs1XQI w3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787161657; x=1787766457; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3rl9WRlfF1qhC6KkWtM+soeUVUGORv4VBrHtcu1jow0=; b=JuHMA8KR7MZHLbWRJymXrEPVudh29q2xc/90M2MBPq4rS5AsEW2Bmg7yd7bZpBpevu RRTLsQkEHFgIUk6AZhxKlIuvQRpMAeVjowRlZdPbEl8rORlBtKQzCwxydPvgS1AD2iRP 1Jh7fNY6UIP+ISkZWFUHaz2vgXJoDj1XFWGt3Vt8mdPmQN0AjkSx7vk/Ea/MgTVQ8RWe 50TsdtjLIvb0+03CSav8/W5ZPLAx8pTbE3+KwsYvJ+foehJrO6g7jhj6R+hHY9sFMiYf KTgjAbo1opXMoVE33Iv+ExVgVE/IbkNboi/o9dMMhgxOVFHBxgxLD0U+GjwcsPTFNuJE 6NGg== X-Forwarded-Encrypted: i=1; AHgh+RrchlwGRUwERbA6GHndMcY4szKhCs+zARQa4OiLeol5DzazD31EJV6ybIjubGFWOUKnNi94dKYCyJRzhVg=@vger.kernel.org X-Gm-Message-State: AFuF++kzTsc8F67SJl9CeF7vW9gTjCT0aFIgI2UluO2o+s7Fl63xnHjz joMVKzid/nCzhA6s8t6aVjgugMlHo87dYXmEVK/J3o3+KffRRsHGxSsMASQwHv0hokdJxRR4NKF dis1laokOk2ZB2Hpt3Z8hQbnUAmBpmUVz4VwcZRacMp+SRP/eQF3wQFIXhwSXC/Ej0A== X-Gm-Gg: AR+sD10nN0kuDSGfzHgeLRdoGkb2VyKdB5WRrJ6Xx8TdVaM5Iy62BvfWnPyUEiDIMrp tC3g9ilKPzxrR3ugJ1b3yZuNOx0c8cijPPoJtic15F+P+ZygHrMJXwGsifWZisdXNYeDcSv+CjI rNGniQAw2mSLE1BlCjLUJNiMQM9bbxvvEW5To+nNFA73+v+4jEDmvlSMAeZthraOTXwq0kxvuFm AFhbNU7VafnIcPDlwxH6uWdCo2MK27E4rA2hI4SO0B/G9ywj8xppi+Dz3ENOC+mDJd8hiivJbXz toVCTiZKdT5fk5dW9TCQm/H63CZciu2QFylFznVmIpWJQFFcfToaDpqRL372/4iFrzqHVHFuTv3 nQoBQY6ws3mdaL1K+ekgYsWsgKSXLX2D7 X-Received: by 2002:a17:90b:5289:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-39580aa5d7cmr13092145a91.6.1787161656983; Wed, 19 Aug 2026 10:47:36 -0700 (PDT) X-Received: by 2002:a17:90b:5289:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-39580aa5d7cmr13092025a91.6.1787161656348; Wed, 19 Aug 2026 10:47:36 -0700 (PDT) Received: from mpilaniy-mac.redhat.corp ([122.171.22.116]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957f96ca41sm3319861a91.4.2026.08.19.10.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 10:47:35 -0700 (PDT) From: Mukesh Pilaniya Subject: [PATCH v2 0/2] kexec: fix probe error codes and error propagation Date: Wed, 19 Aug 2026 23:17:21 +0530 Message-Id: <20260819-mpilaniy-v2-0-95e929ede0e5@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/22Nyw6CMBBFf4XM2po+jFVX/IdhAe3UjhFKWmwkp P8u4NblSc49d4GEkTDBrVogYqZEYVhBHiowvh0eyMiuDJLLM78IxfqRXu1AM3Ou48ZcpVFCwaq PER199tS9+XF6d08007bfDE9pCnHev7LYvD/ZLJhgWmt7shwVd7qOaH07HU3ooSmlfAFPzfzOs wAAAA== X-Change-ID: 20260813-mpilaniy-ffb0cc92c313 To: Catalin Marinas , Will Deacon , Mark Rutland , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Tao Liu , Philipp Rudo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, Mukesh Pilaniya X-Mailer: b4 0.15.2 While debugging a misleading error on s390x where kexec -s reported "syscall kexec_file_load not available" instead of the actual EINVAL from a kernel command line that exceeded the architecture limit, we found that some kexec image probe functions return -EINVAL instead of -ENOEXEC for format mismatches, and kexec_image_probe_default() has a bug where it returns whatever the last loader returned rather than always returning -ENOEXEC when no loader matches. Patch 1 fixes all probe functions to return -ENOEXEC when they do not recognize the image format. Patch 2 fixes kexec_image_probe_default() to distinguish format mismatches (-ENOEXEC) from real errors (e.g. -ENOMEM), propagating real errors immediately and only continuing to the next loader on -ENOEXEC. kexec-tools patch: https://lore.kernel.org/all/20260814075329.30203-1-mpilaniy@redhat.com/ Signed-off-by: Mukesh Pilaniya --- Changes in v2: - Added patch 2 to fix error propagation in kexec_image_probe_default(), as suggested by Pratyush Yadav. - Link to v1: https://patch.msgid.link/20260813-mpilaniy-v1-1-777d4d0e30f7@redhat.com To: Catalin Marinas To: Will Deacon To: Mark Rutland To: Huacai Chen To: WANG Xuerui To: Paul Walmsley To: Palmer Dabbelt To: Albert Ou To: Alexandre Ghiti To: Andrew Morton To: Baoquan He To: Mike Rapoport To: Pasha Tatashin To: Pratyush Yadav To: Philipp Rudo To: Tao Liu Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-riscv@lists.infradead.org Cc: kexec@lists.infradead.org --- Mukesh Pilaniya (2): kexec: return -ENOEXEC from image probe functions on mismatch kexec: fix error propagation in kexec_image_probe_default() arch/arm64/kernel/kexec_image.c | 4 ++-- arch/loongarch/kernel/kexec_efi.c | 4 ++-- arch/riscv/kernel/kexec_image.c | 4 ++-- kernel/kexec_elf.c | 4 ++-- kernel/kexec_file.c | 12 +++++++----- 5 files changed, 15 insertions(+), 13 deletions(-) --- base-commit: dd8c49a14f169d58e7a07a2c96fb588f3456efa0 change-id: 20260813-mpilaniy-ffb0cc92c313 Best regards, -- Mukesh Pilaniya