From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 827EB19D8AC for ; Wed, 19 Aug 2026 01:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787104143; cv=none; b=ewjKaWi2l+Y+H6LkaV6hnbXcXglc9J6OeSYuaf7PCi9oep4JzHcixjFRNZP2LU7tbfRP3w6241evsFWhZQAJHUODB9zZmZERerckKt1g3eZCxOJE7qhdeu5ACAn5xcCqgEz+7M4V2cVawabEucT0gqy+IdlWgszTBWc4Trp37Eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787104143; c=relaxed/simple; bh=EfZl991DxxzWp4Vdk3Ifm5w4z88KDCHFkedFl7PFTwo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iI2G3jxXv1asvqATYiLXrTksldwTrS1q49hMK4WMDY2GVz3XVfmMmt0grFYwQqIZp0nzZgMX8qyal6E5wf1wn+dLLo7kmcQv5P6GKajR4ALqByZt7pg40SGIhK6NbiSeaECW6198nN5lRCK9q6JBgU403KsHvPFjQLspWCbM/9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Aj2MAtwT; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Aj2MAtwT" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-836c5b01e82so9656697b3.0 for ; Tue, 18 Aug 2026 18:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787104141; x=1787708941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YXD//4YNkkxyIkb6wqjP8t3iz79+20/kYGvfIfnI6Gc=; b=Aj2MAtwTN8tMTKyWUupZGg9jEl+DuSJp85C7ZeZYBvWrv2/oqji05ihTfmrj2RwCyp JMmB+UT7agrnapQfLuA9Mk+pu684nx5+rZ1tD7iCf8M1T/fissxsbDGkjIK6JJ3CSeFG NWxoDHMk9FRw19CWnF++pqa6cY239ap0Gk4rEMXAxSl97CClcY3SORZJs7x7eDbWbqx6 XLGxcqrLnJ8ViRfdVmzm5wkjTt429RVJBFoi6jQhgtsm6iFye54dZzuZ/EnodJpOs81w sT959huldoJGZJlBl6d9ELFkH43CbdrrlqFsrmLfujy9rfMdaExocSp3FrBb6fXYbiHH fthA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787104141; x=1787708941; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YXD//4YNkkxyIkb6wqjP8t3iz79+20/kYGvfIfnI6Gc=; b=MPaDj9HUXYrBMJTM8vmCwzpr3ppo7bJYCrGG+miHKq1nB9P7VD1+LCHDaXGghd/zow aqgqlAdxlkzHXUv6QPrXC5TI8GjzBtjIC7RClJ5UkOkw5yJPXyAszO1n0Npfxlq2WDFn b1qFlZynIGzKESCgeyKDTMGjJeI+wmTxUAL49pgPBz467A16SJClnP9ip3+DoZSO8zaQ G+z25LQrE75JlMiyKLs5YJLKMMt7x0fZkFpds9k+XHKT+sxYdlfNp3/p1E97KNERMCz8 kRjMdo8R5/RbFdv8H2F0Xu44zhJmtt8z3ILKiGJb3TenZOKM8Wao5RTEdcpPmUDsHgng rdzA== X-Forwarded-Encrypted: i=1; AHgh+Rqgoon/ZoBPC6XfwKTo3QCo1hM0XWWR1Ev7y5F9TSkYb0WeVv/e6FAvUQgr+BUpdrcrn1Sxw4k4r3gwNPg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7ico8drdlHniBzY0W6a+oWn26wCJY5h+cuGlfT5V++aRwc0dD ++TOY3uoCQdJUBXAO3AFthPT97PsDhTfA/8wsZ0g32Lc6h8VwedoOfiG X-Gm-Gg: AR+sD13qPSMv0sXHgL+HyWElx3GSorvaEAEw2yA+Cf1M56eTXMFf6i+P6J1PtON7atR NoHxapbnaaG+KF9gBiYTiExvyHjbSeTC89C9tS7TcKfOUGaovenhfjSoKb12vk0hJGZqmAJfbxD riPy2c4JPkZes5jii2BhVdv+P3iX93UNEQVLP+DMH27OR3Rg6I4bdyhNfER6EqmlGFBUl9mcM/4 NOyZVD4BOQAw4W5Hty/3F2UMMZkZ6pmKXWiPVLEPN00gZ+Zz4qdGVDFKard1eWaB5TkpHabz+LK Hx88RNZGwVovPtN9CI7PciV9lvMj/+Ch/4df04aEQBVegLppmvkyZkEBRiZDE1cFF4FOzY/S35U fMpmeaFMHyo4JC74I8TL9hm+cJ22aRrqHYJTxyjpinhSVpF4Ig7njDbPvXiHsIAOgBROrYbbCPu SugzP72PJmT1EesQK7E+rJZ13Tz2d3wijfgrPdUJBLPpjUOQoXgTpA/emyS0x3s/+q6gZq X-Received: by 2002:a05:690c:e20f:20b0:81e:98d3:cac7 with SMTP id 00721157ae682-844de3bc1ccmr6528037b3.12.1787104141356; Tue, 18 Aug 2026 18:49:01 -0700 (PDT) Received: from mac.lan ([136.55.173.105]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8451275df9fsm1975047b3.14.2026.08.18.18.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 18:49:00 -0700 (PDT) From: "Cen Zhang (Microsoft)" To: pablo@netfilter.org, laforge@gnumonks.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, xmei5@asu.edu, tgopinath@linux.microsoft.com, kys@microsoft.com, blbllhy@gmail.com Subject: [PATCH] gtp: add synchronize_net() in gtp_newlink() error path to prevent use-after-free Date: Tue, 18 Aug 2026 21:48:58 -0400 Message-ID: <20260819014858.76707-1-blbllhy@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gtp_newlink()'s error path frees tid_hash and addr_hash without waiting for an RCU grace period after clearing sk_user_data. A concurrent gtp_encap_recv() in softirq may still hold the gtp_dev pointer obtained via rcu_dereference_sk_user_data() and access the freed memory. BUG: KASAN: slab-use-after-free in gtp0_pdp_find+0x1f6/0x200 (gtp.c:152) Call Trace: gtp0_pdp_find+0x1f6/0x200 gtp_encap_recv+0x527/0x24b0 udp_queue_rcv_one_skb+0x75f/0xc10 Add synchronize_net() before the kfree calls in out_hashtable, which covers all error paths from both gtp_encap_enable() and gtp_create_sockets(). Fixes: 459aa660eb1d8ce6 ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)") Reported-by: AutonomousCodeSecurity@microsoft.com Reported-by: Xiang Mei (Microsoft) Reported-by: Cen Zhang (Microsoft) Signed-off-by: Cen Zhang (Microsoft) --- drivers/net/gtp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 9a12cc53da00..f11bcc0c0ac4 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -1543,6 +1543,8 @@ static int gtp_newlink(struct net_device *dev, out_encap: gtp_encap_disable(gtp); out_hashtable: + /* Wait for RCU readers that may still reference this gtp_dev. */ + synchronize_net(); kfree(gtp->addr_hash); kfree(gtp->tid_hash); return err; -- 2.52.0