From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E8643D6662 for ; Wed, 19 Aug 2026 07:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787124460; cv=none; b=u/JdGoTgSKaKwufqgzC8XK7w4215DhUTCSeSG0CzBH58LE5BSTggCpZCVkTE72Pl5bL/d3bXs9VwH8+Kr4Y4X6qOxzyw+GVaDVjImdkXQtU7FCY/nSiFYEemgE2xx65rzqejzGlHDJxOslHRzROraHA+yJ5i8XeIVIgTJEpmkYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787124460; c=relaxed/simple; bh=NsNg7b/W+gQJwQrUUjP/I9QQ+ee0HZENvefznl2S0lQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EH2bMCiEL82S8U0ofjVj7EYFeoJLcBgDUBd2t3Xi2DTv9IE9A//iyBpyhUc3UldAkGomdRMI8GcgCEEoN8O+P/AtM2OyplckjtLvzfRxvUQC47tS6KkesqevaPv62vyt1jcZb/FhW/wNG2lVMMTXGECmmJb/cLHLv2ByUeaEK5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=uE3EC+td; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="uE3EC+td" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=NsNg7b/W+gQJwQrUUjP/I9QQ+ee0HZENvefznl2S0lQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787124454; v=1; x=1787729254; b=uE3EC+tdigtCPlxXHeGOhI5u2mc1yNZ8DS0k6LLPPEzxqF7W5HfYxiFpZ23a0xLkZf1PrwSu w7mvLDQ1z3nxx6SQqjXdikecpdMCP9WkGXxKEfkas14eSiK1Ds8sM0aljqG4mEjgp3mjIC4UPeU 9NA+alzxP/cb24niS7ewVDP8= X-Envelope-To: linux-kernel@vger.kernel.org Received: from kali (2a06:63c5:9b00:3900:e1b3:d7a6:6110:4f65) by smtp.migadu.com with ESMTPS id ac8c18744979f888; Wed, 19 Aug 2026 07:27:34 +0000 X-Migadu-Flow: FLOW_OUT From: luka.gejak@linux.dev To: Ping-Ke Shih , linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michael Straube , Bitterblue Smith , Peter Robinson , Hans de Goede , Luka Gejak Subject: [PATCH v6 2/6] wifi: rtw88: rx: mark zero length packets on RTL8723BS Date: Wed, 19 Aug 2026 07:27:13 +0000 Message-ID: <20260819072717.22648-3-luka.gejak@linux.dev> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260819072717.22648-1-luka.gejak@linux.dev> References: <20260819072717.22648-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luka Gejak Like the RTL8703B, the RTL8723BS reports receive descriptors with a zero packet length, which the vendor driver drops outright. rtw88 already flags these as having no PSDU for the RTL8703B, so extend the same handling rather than passing an empty frame up. This is gated on the SDIO interface rather than the chip id, because it has only been observed there; the USB variant is not known to do it. Co-developed-by: Michael Straube Signed-off-by: Michael Straube Signed-off-by: Luka Gejak Acked-by: Ping-Ke Shih --- Notes: Changes in v6: none. Changes in v5: the zero length test now evaluates pkt_stat->pkt_len first, so the unlikely case short circuits before the chip test. drivers/net/wireless/realtek/rtw88/rx.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/rx.c b/drivers/net/wireless/realtek/rtw88/rx.c index 01fd299abb7f..fde21c840ac0 100644 --- a/drivers/net/wireless/realtek/rtw88/rx.c +++ b/drivers/net/wireless/realtek/rtw88/rx.c @@ -253,10 +253,12 @@ static void rtw_rx_fill_rx_status(struct rtw_dev *rtwdev, rtw_rx_addr_match(rtwdev, pkt_stat, hdr); - /* Rtl8723cs driver checks for size < 14 or size > 8192 and - * simply drops the packet. + /* + * Rtl8723cs and rtl8723bs drivers check for size < 14 or size > 8192 + * and simply drop the packet. */ - if (rtwdev->chip->id == RTW_CHIP_TYPE_8703B && pkt_stat->pkt_len == 0) { + if (pkt_stat->pkt_len == 0 && + (rtwdev->chip->id == RTW_CHIP_TYPE_8703B || rtw_is_8723bs(rtwdev))) { rx_status->flag |= RX_FLAG_NO_PSDU; rtw_dbg(rtwdev, RTW_DBG_RX, "zero length packet"); } -- 2.53.0